I have a form attribute like so:
onsubmit="return valMyForm(this);"
And a jQuery function like so:
function valMyForm(f) {
$(f,"input").each(function() {
if($(this).length < 1) {
alert("All Fields Required.");
return false;
}
else
return false;
});
}
The form still submits even if I remove all of the code and just put return false;
The return false inside the each function is just exiting out of the each loop. It's not returning the value for valMyForm
You should use something like a valid variable and return that:
function valMyForm(f) {
var valid = true;
$("input", f).each(function() {
if($(this).val().length < 1) {
alert("All Fields Required.");
valid = false;
}
});
return valid;
}
Here is a working example for you: http://jsfiddle.net/adpMT/
[value=""] wot work from Darin's example. So +1 to you. ;-)When you return you are inside the .each function so you are not actually returning anything from the valMyForm method.
I would recommend you avoid mixing markup with javascript and do this unobtrusively:
<form action="/foo" id="myform">
... some input fields
</form>
and then:
$(function() {
$('#myform').submit(function() {
// see if the form contains some empty inputs
return $(this).find(':input[value=""]').length > 0;
});
});
$('input',f). But again, I don't know how the function's being called.
f within the context of all the input elements on the page. You should be looking for input elements in the context of f. $('input',f) or better $(f).find('input')$(f).find('input') is better. It doesn't need to run through a bunch of tests before it just flips it around and starts over. :o)
elseisn't necessary. ;-)