Laravel Eloquent : Getting object instead of array

Question

Trying to get a hotel in detail for hotel management API, in which for some hotels, getting

$hotel->rooms

as object and for some as array. The eloquent query in Hotel model as below.

public function detail($hotelid) { 
    return $this->with(['rooms','roomType'])->find($hotelid);
}

public function rooms() {
    return $this->hasMany(HotelRooms::class, 'hotels_id')->where('status','active');
}

HotelRoom Model

public function roomType(){
   return $this->hasOne(RoomType::class,'id','room_type_id')->where('status','active');
}

Controller

public function __construct(){
    $this->model = new Hotel();
}

public function hotelDetail(Request $request){

    $data = $this->model->detail($request->input('hotel_id'));

    foreach($data->rooms as $key=>$room){

        if(!$room->roomType){
            unset($data->rooms[$key]);
            continue;
        }

    }

    return response()->json([
         'status' => true,
         'status_message' => 'successful',
         'data' => $data,
    ]);
}

response

{
    "id":"id",
    "name":"name",
    "rooms":{
        "1":{},
        "2":{}
    }       
}

{
    "id":"id",
    "name":"name",
    "rooms":[
        {},
        {},
    ]       
}

I got both in response. For example, for hotel-1 I got the first response, and for hotel-2 got the second one. I prefer the second response @hoseinz3 — OutForCode
– OutForCode, Commented Mar 13, 2019 at 13:44
I think in the detail method you have tried some filtering, after use filter method you should add values method to re-index response — hoseinz3
– hoseinz3, Commented Mar 13, 2019 at 14:14

Nikola Kirincic · Accepted Answer · 2019-03-13 15:03:56Z

2

When you use unset on array, your array indexes remain for each item. Same as for collection->filter() or for array_filter() that is actually used in collection->filter(). That is why you need to rebuild the indexes:

$data->rooms = array_values($data->rooms->toArray());

to reindex the array.

Or use the foreach, but push values to new array:

$filteredRooms = [];
   foreach($data->rooms as $key=>$room){

        if(!$room->roomType){
           continue;
        }
        $filteredRooms[] = $room;

    }

$data->rooms = $filteredRooms;

Or instead of foreach loop, use filter for collection in combination with values() :

$filteredRooms = $data->rooms->filter(function ($room, $key) {
    return (!$room->roomType)? false : true;
})->values();

edited Mar 13, 2019 at 15:03

answered Mar 13, 2019 at 14:38

Nikola Kirincic

3,7871 gold badge28 silver badges32 bronze badges

Sign up to request clarification or add additional context in comments.

11 Comments

OutForCode Over a year ago

... "rooms": { "1": { "id": 2,...

Nikola Kirincic Over a year ago

@NoName, this replaces foreach. You can reassign value to $data->rooms = $filteredRooms after

OutForCode Over a year ago

$data->rooms = array_values($data->rooms->toArray()); tested this one @nikalz

OutForCode Over a year ago

this one works unset($data->rooms); $data->rooms = $fileteredRooms; after foreach. Where in foreach $filteredRooms[]=$room.

Nikola Kirincic Over a year ago

when you use unset, your array indexes remain for each item, same as for collection->filter() or for array_filter() that is actually used in collection->filter(). That is why you need to rebuild the indexes either way suggested in the answer above

|

hoseinz3 · Accepted Answer · 2019-03-13 14:35:18Z

1

After filtering array you have to re-index your array.

foreach($data->rooms as $key=>$room){

    if(!$room->roomType){
        unset($data->rooms[$key]);
        continue;
    }
}
$data->rooms = $data->rooms->values();

answered Mar 13, 2019 at 14:35

hoseinz3

6485 silver badges14 bronze badges

2 Comments

OutForCode Over a year ago

getting same response

OutForCode Over a year ago

but getting as array when the last line added inside foreach, is that correct format ?

Collectives™ on Stack Overflow

Laravel Eloquent : Getting object instead of array

2 Answers 2

11 Comments

2 Comments

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

11 Comments

2 Comments

Related