Progress indication with animation

Question

I have a game in which the player has to do something within a defined time.

E.g.: the player has 10 seconds to complete a level.

My current code animates an imageview (it's only a horizontal line) when the game starts:

progressAnimation = new TranslateAnimation(0, -Settings.screenWidth, 0, 0);
progressAnimation.setDuration(level * 10000);
progressAnimation.setFillAfter(true);
progressAnimation.setInterpolator(new LinearInterpolator());

progressView = new ProgressView(context);
progressView.startAnimation(progressAnimation);

Simultaneously I start a handler:

handler.postDelayed(new Runnable() {
    @Override
    public void run() {
        fireResultActivity(-1); // -1 means, time's up.
    }
}, level * 10000);

If the user can finish the game within 10 seconds an activity comes up and congratulates, if they can't another, "fail" activity comes up.

Is it a good practice to use animation to indicate the progress and start a handler simultaneously?

Could you recommend other (better) solution?

You've got 1 answer already, but check codereview.stackexchange.com/help/no-one-answers — Pimgd
– Pimgd, Commented Mar 22, 2016 at 9:19

Pimgd · Accepted Answer · 2016-03-22 09:52:36Z

2

First of All you should be using setAnimationListener on animation object. so no need of Handler

progressAnimation.setAnimationListener(new Animation.AnimationListener() {
    @Override
    public void onAnimationStart(Animation animation) {

    }

    @Override
    public void onAnimationEnd(Animation animation) {
       fireResultActivity(-1); // call your method here
    }

    @Override
    public void onAnimationRepeat(Animation animation) {

    }
});

As it has built-in listener for Animation, there is no need to create new thread using handler

edited Mar 22, 2016 at 9:52

Pimgd

22.6k5 gold badges68 silver badges144 bronze badges

answered Mar 22, 2016 at 7:08

N J

1465 bronze badges

\$\begingroup\$ Hi there, welcome to Code Review! Could you explain in your answer why setAnimationListener is better than using a handler? \$\endgroup\$

Pimgd
– Pimgd

2016-03-22 08:17:51 +00:00
Commented Mar 22, 2016 at 8:17
\$\begingroup\$ As its has in-build listener for Animation no need to create new thread using handler \$\endgroup\$

N J
– N J

2016-03-22 09:16:12 +00:00
Commented Mar 22, 2016 at 9:16
\$\begingroup\$ if you would write your explanation in your answer then we can delete the comments \$\endgroup\$

Pimgd
– Pimgd

2016-03-22 09:17:34 +00:00
Commented Mar 22, 2016 at 9:17
\$\begingroup\$ @Pimgd update answer \$\endgroup\$

N J
– N J

2016-03-22 09:41:13 +00:00
Commented Mar 22, 2016 at 9:41

Add a comment |

Stack Exchange Network

Progress indication with animation

1 Answer 1

You must log in to answer this question.

Hot Network Questions

Progress indication with animation

1 Answer 1

You must log in to answer this question.

Related

Hot Network Questions