Conversation
Sidsector9
left a comment
There was a problem hiding this comment.
@jayedul I am seeing the following error in the Settings > Writing page, can you have a look at it?
There was a problem hiding this comment.
@jayedul let me know if I'm understanding this correctly. Should we limit the post types shown to only those that support the block editor? I don't think oEmbed responses, template parts, etc should be a part of this for the same reason.
If so, we can check the support using:
if ( ! use_block_editor_for_post_type( $post_type ) ) {
continue;
}Let me know what you think.
|
@Sidsector9 I added the checking initially. Then removed as it doesn't exclude all the unnecessary types. You can see in the screenshot before and after adding the check. |
|
@jayedul So I checked, and it seems that template parts, oEmbed does have support for the block editor. |
|
@Sidsector9 Block editor check has been added. It can be re-reviewed though eslint test is failing here. There is no JS change in this PR, so I guess this issue is better to be fixed in a new ticket. |
There was a problem hiding this comment.
@jayedul I am seeing fatal error when I save settings after unchecking all the checkboxes.
|
@Sidsector9 back to you for review |





Description of the Change
As per current implementation, there is no way to resolve the issue other than explicitly adding
convert-to-blockssupport during custom post type registration. So, a new field added in writing setting page to enable/disableConvert to Blocksfor specific post types without editing code.Closes #57
How to test the Change
Convert to BlockssectionChangelog Entry
Credits
Props @jayedul
Checklist: