Merged
Conversation
Member
Author
jeffpaul
commented
Jun 20, 2023
Member
Author
There was a problem hiding this comment.
@Sidsector9 what was the PR/change that necessitated the WP/PHP minimum bumps here?
Sidsector9
previously approved these changes
Jun 22, 2023
Member
Author
|
Updated release date, so otherwise proceeding with the earlier release approval |
Member
Author
|
Oh for the love of all things automated and holy, now a failing E2E test on WP trunk. Looking at the string of commits, there's nothing from when that test was passing previously until now that should cause that failure here within the plugin repo. My gut is that something wonky is going on in WordPress 6.3 (in fact there's a bit of a hiccup in the Beta 1 release) so I'm choosing to chalk it up to oddities there that we'll catch & update when it gets to testing for WP 6.3 compatibility / "tested up to". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
Release and version bump to 1.2.0.
Closes #110.
How to test the Change
Verify manually via VS Code or the GitHub UI.
Checklist: