feat(tronscan): add security checks and validation - #71
Conversation
|
Thanks for the thorough implementation and test coverage. The repository branch and release workflow changed after this PR was opened, so this PR needs to be migrated before review can continue. PR #70 has been superseded by #75. Please update this work as follows:
Because GitHub closes an open PR when its head branch is renamed, opening a replacement PR from the compliant |
|
Thanks for the migration guidance. I rebuilt the contribution from the latest The replacement keeps the security command, local validation, transfer parameter fix, documentation, and tests; keeps the Skill/package versions at Replacement: #76 |
Summary
security.jscommand for TronScan account, token, URL, transaction, multi-signature permission, and token-approval security signals.unknownrather than a clean result.tronscan-skillto1.1.0.Motivation
The existing skill exposes general TronScan lookups but not the Security Service endpoints. Several security endpoints return default values or omit invalid inputs, so strict local validation is needed to avoid false clean results.
The transfer validation adjustment was found while running the repository's full live smoke suite. The current TronScan endpoints require both the account address and token identifier:
Testing
Commands run from
tronscan-skill/:Results:
git diff --checkpassed.Security
no_known_flagsis explicitly documented as not being proof that a target is safe.Related issues
None.
Coordination
PR #70 also touches the
tronscan-skillversion fields. If it lands first, this branch will need a small rebase/version adjustment.