fix for XSS vulnerability - #2437
Merged
Merged
Conversation
Contributor
|
Thanks for pulling this in @briri |
xsrust
approved these changes
Mar 23, 2020
briri
added a commit
to CDLUC3/dmptool
that referenced
this pull request
Mar 24, 2020
Added Rails4 monkey patch to address XSS vulnerability with (DMPRoadmap#2437)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added Rails4 monkey patch to address CVE-2020-5267 which is an XSS vulnerability in ActionView's
escape_javascriptmethod.The patch was shared with us from the Dryad team. Thanks @sfisher
Since Rails 4.x is no longer receiving updates we need to patch this ourselves.
We will need to remove this initializer after moving to Rails 5+