Release Candidate v2.1.6 by xsrust · Pull Request #2441 · DMPRoadmap/roadmap

xsrust · 2020-03-31T12:57:40Z

Release Notes v2.1.6

Upgrade Process

Run bundle install to update your rubygems dependancies
Run rake assets:precomipile to update your webpack assets and dependancies
The content of statistics objects has been restructured, and will need to be re-run for all previous months. Use rake stat:build or rake stat:build_parallel to update these. NOTE: this can take a long time to run if not parallel. See comments below around connection pooling if you hit issues with the parallel tasks

Changes

Researchers

The option to create a copy of an existing DMP is now called "Copy". Change "Make a copy" to "Copy" in plan actions list #2418

Org-admins

It's now possible to select a comma ,, pipe, |, or hash # characters as your delimiter for CSV exports from the usage dashboard. Delimiter to pipe in usage statititics instead of comma #2375
It's no longer possible to download an overview of tool usage from the usage dashboard. Changes to downloading usage reports #2345
It's possible to download a CSV with statistics on your New Plans, New Users, Downloads, and Plans Shared broken down by month from the usage dashboard. Changes to downloading usage reports #2345
There is an additional accordion on the usage dashboard to show statistics on how your templates are used (by all organisations) Usage stats for funder view #1682
Admins from Funder orgs have their usage-dashboard replaced with the statistics on their template usage (detailed above). Usage stats for funder view #1682
The CSV export of users now includes the School/Department field. Download users should show also the school/department field #2213

Bugfixes

Headers now follow hierarchical order, fixes an accessibility issue for screen-readers. Headings should follow proper hierarchical ordering #1451
Org-admins can now view plans shared by users of different organisations. Org admins cannot view plans explicitly shared by a user of another org #2415
The super-admin list of plans no longer throws an error when a plan's owner does not exist. User has all privileges (super admin) but cannot list plans #2428
The 'Opens in a new Window' tool-tip is no longer truncated on links within guidance. Issue with display of 'Opens in new window' tooltip when viewing guidance #2305
tinymce content css no longer fails to load. Fixed an issue where the tinymce content css was not being loaded #2379

Security

Update nokogiri to 1.10.8
Fix for XSS vulnerability. fix for XSS vulnerability #2437
Update Karma to 4.4.1

Developer Notes

Lots of changes to ensure GitHub workflows/tests are working correctly
Removed the feedjira Gem as it was un-used by the DMPRoadmap project. If your customization depended on the gem, see the suggested fix by @benjaminfaure in removed old unused Feedjira code and dependency #2412
The statistics rake-tasks are now able to be run in parallel to reduce the runtime. Use rake stat:build_parallel and rake stat:build_last_month_parallel. NOTE: there must be as many database connections available to Rails as total threads attempting to make connection, as such, you may need to increase your pool size in config/database.yml. The default in config/database.yml.sample has been changed to 16
It's now possible to use js.erb files from the asset-pipeline. See PR Fixed an issue where the tinymce content css was not being loaded #2379 for an example of usage

…, and properly get the asset_path for the tinymce content stylesheet

debug statement to test github workflow issue debug statement to test github workflow issue debug statement to test github workflow issue debug statement to test github workflow issue debug statement to test github workflow issue debug statement to test github workflow issue debug statement to test github workflow issue debug statement to test github workflow issue debug statement to test github workflow issue cleanup trying to fix wkhtmltopdf trying to fix wkhtmltopdf trying to fix wkhtmltopdf trying to fix wkhtmltopdf trying to fix wkhtmltopdf added wkhtmltopdf fix to mysql workflow added 'unique' to usage helper test

Bumps [nokogiri](https://github.com/sparklemotion/nokogiri) from 1.10.7 to 1.10.8. - [Release notes](https://github.com/sparklemotion/nokogiri/releases) - [Changelog](https://github.com/sparklemotion/nokogiri/blob/master/CHANGELOG.md) - [Commits](sparklemotion/nokogiri@v1.10.7...v1.10.8) Signed-off-by: dependabot[bot] <support@github.com>

* issue#2375 allow change of delimiter for csv download * fix eslint issues, bugfix usage-dashboard when no stats exist, Styling tweaks to csv separator * fix issues with tests by defaulting the separator to a comma NOTE: does not enforce tests on the separator param working * fix issues with new separator argument in stat-created-plan and spec Co-authored-by: Sam Rust <xsrust@gmail.com>

…can run the tests inside docker

…l related

Fixed an issue where the tinymce content css was not being loaded

* removed old unused Feedjira code and dependency * removed old Feedjira sanitize helper method and replaced with Rails'

…nto issue/1682

…1.10.8 Bump nokogiri from 1.10.7 to 1.10.8

Pulling changes to master

* capture status * Changes were made to the HTML h tags in order to make it more accessibility friendly and compliant * Changes to make merge with development possible * Fixe of the empty class

@v2

* add stat_shared_plan to track number of shares of plans owned by org members * add stat_exported_plan and stat_shared_plan to stats rake task * added parallelization to the stats tasks/services * make paralell stats more reliable with imports * additional import statements for parallel services * add csv download button for org-admins, make global download super-admin only * add gemfile.lock for parallel gem * fix policy and controller usage tests * refactor services to be non-concurrent by default * apply fix from PR#2430 to mysql workflow * upgrade github checkout action to v2 * upgrade remaining github checkout actions to v2 * remove @v2 from the ruby-setup on mysql

Issue/1682

Issue 2418

* remove monthly usage from funder-usage-dashboard, adjust spacing on page * rename usage statistic accordion partials * usage-dashboard accordions now conditional on the type of user, also made the js more robust to the charts not existing

briri · 2020-03-31T14:52:02Z

fantastic. thanks for the release notes @xsrust!

benjaminfaure · 2020-04-02T09:59:51Z

Thank you !

Quick fix : my fix for the Feedjira gem is at #2411

fix permissions bug for Notes#update and Roles#deactivate

briri · 2020-04-02T14:29:44Z

thanks @benjaminfaure. We will note the link to your fix in the official release notes :)

xsrust and others added 30 commits February 4, 2020 16:06

enable js.erb parsing with webpacker, rename references to tinymce.js…

6f2a547

…, and properly get the asset_path for the tinymce content stylesheet

fix import path for karma test (tinymce)

b087b57

pray to js-test gods

72605a9

add department to org-admin user export (#2399)

f1c7ce4

changed overflow setting for the guidance area (#2400)

af72f7f

Merge branch 'development' into dependabot/bundler/nokogiri-1.10.8

b25b4e0

let karma know where the webpacker config is, also --no-sandbox so I …

27408b7

…can run the tests inside docker

Merge branch 'development' into bug/tinymce_styling

00155a1

minor refactor of the template filter UI to make things align and fee…

b7d3bae

…l related

bring global usage button and csv separator off of header line

0ab8b02

horizontally align usage-filter with other elements

e3f01b0

Merge pull request #2379 from DigitalCurationCentre/bug/tinymce_styling

24a07a2

Fixed an issue where the tinymce content css was not being loaded

removed old unused Feedjira code and dependency (#2412)

76908e5

* removed old unused Feedjira code and dependency * removed old Feedjira sanitize helper method and replaced with Rails'

usage dashboard working but not dry, moving machines

2cb3c46

Merge branch 'development' of https://github.com/DMPRoadmap/roadmap i…

2dd0b80

…nto issue/1682

DRY up the stat and JS code

aec0d5a

fix eslint issues

f41cbe4

fix bug in stats generation logic

9fd650f

fix tests to check for plans_using_template

b065e2d

Merge branch 'development' into dependabot/bundler/nokogiri-1.10.8

2bdb250

Merge pull request #2404 from DMPRoadmap/dependabot/bundler/nokogiri-…

c9f4a5a

…1.10.8 Bump nokogiri from 1.10.7 to 1.10.8

Merge pull request #2424 from DMPRoadmap/master

b1bfb30

Pulling changes to master

Changes were made to the HTML h tags - Issue 1451 (#2423)

0d4d289

* capture status * Changes were made to the HTML h tags in order to make it more accessibility friendly and compliant * Changes to make merge with development possible * Fixe of the empty class

added nil check for feedback without an owner (#2429)

e9704da

pull in changes from development

ef95f91

add accordions to usage-dashboard, refactor views

efb74d8

briri and others added 7 commits March 17, 2020 11:17

changed text from 'Make a copy' to 'Copy'

e757ade

make requested changes (internationalization and data-access)

794a86a

Merge pull request #2433 from DMPRoadmap/issue/1682

b3801d1

Issue/1682

Merge branch 'development' into issue_2418

8a70d0e

Merge pull request #2426 from DMPRoadmap/issue_2418

37ea516

Issue 2418

Added Rails4 monkey patch to address XSS vulnerability with (#2437)

d8668b9

Issue/1682 (#2440)

003431d

* remove monthly usage from funder-usage-dashboard, adjust spacing on page * rename usage statistic accordion partials * usage-dashboard accordions now conditional on the type of user, also made the js more robust to the charts not existing

xsrust and others added 2 commits April 2, 2020 14:48

fix permissions bug for Notes#update and Roles#deactivate

497cd8a

Merge pull request #2443 from DMPRoadmap/bug/role_perms

47ab448

fix permissions bug for Notes#update and Roles#deactivate

briri merged commit aaa6d98 into master Apr 3, 2020

Navigation Menu

Uh oh!

Release Candidate v2.1.6 - #2441

Release Candidate v2.1.6#2441
briri merged 39 commits into
masterfrom
development

xsrust commented Mar 31, 2020 •

edited

Loading

briri commented Mar 31, 2020

benjaminfaure commented Apr 2, 2020

briri commented Apr 2, 2020

Labels

5 participants

Uh oh!

Conversation

xsrust commented Mar 31, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Release Notes v2.1.6

Upgrade Process

Changes

Researchers

Org-admins

Bugfixes

Security

Developer Notes

briri commented Mar 31, 2020

benjaminfaure commented Apr 2, 2020

briri commented Apr 2, 2020

Labels

5 participants

xsrust commented Mar 31, 2020 •

edited

Loading