Skip to content

remove margin settings from PDF stylesheet and set initial zoom level… #3157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
raycarrick-ed merged 2 commits into from
Apr 14, 2022
Merged

remove margin settings from PDF stylesheet and set initial zoom level… #3157

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b61b670
remove margin settings from PDF stylesheet and set initial zoom level…
briri Apr 13, 2022
5ab8d7d
Merge branch 'development' into patch-pdf-margin
raycarrick-ed Apr 14, 2022
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions app/controllers/plan_exports_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,9 @@ def show_docx
def show_pdf
render pdf: file_name,
margin: @formatting[:margin],
# wkhtmltopdf behavior is based on the OS so force the zoom level
# See 'Gotchas' section of https://github.com/mileszs/wicked_pdf
zoom: 0.78125,
footer: {
center: format(_('Created using %{application_name}. Last modified %{date}'),
application_name: ApplicationService.application_name,
Expand Down
1 change: 0 additions & 1 deletion app/views/shared/export/_plan_styling.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
body {
font-family: @font-face;
font-size: <%= font_size %>;
margin: <%= margin %>;
}
h1 {
font-size: 1.5rem;
Expand Down