Enhance checkAndUpdateSingleCollectibleOwnershipStatus to use use passed accountParams for selectedAddress and chainId - #672
Merged
adonesky1 merged 3 commits intoJan 7, 2022
Conversation
adonesky1
force-pushed
the
enhance-checkAndUpdateSingleCollectibleOwnershipStatus
branch
from
January 6, 2022 19:50
e7b27cb to
b91e203
Compare
…sed accountParams for selectedAddress and chainId
adonesky1
force-pushed
the
enhance-checkAndUpdateSingleCollectibleOwnershipStatus
branch
from
January 6, 2022 19:50
b91e203 to
cf8d2a3
Compare
adonesky1
changed the title
adonesky1
marked this pull request as ready for review
January 6, 2022 21:21
mcmire
previously approved these changes
Jan 6, 2022
mcmire
left a comment
mcmire
left a comment
Collaborator
There was a problem hiding this comment.
Have a few nits, but this seems kosher to me 👍🏻
mcmire
approved these changes
Jan 7, 2022
adonesky1
deleted the
enhance-checkAndUpdateSingleCollectibleOwnershipStatus
branch
January 7, 2022 17:21
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ADDED:
accountParams(an object containing auserAddressandchainId) to methodcheckAndUpdateSingleCollectibleOwnershipStatus, which when uses the passeduserAddressandchainIdto find the collectible that should be updated.