Use new rapids-logger library - #2566
Merged
rapids-bot[bot] merged 19 commits intoFeb 11, 2025
Merged
Conversation
vyasr
added
improvement
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
vyasr
force-pushed
the
feat/rapids_logger_library
branch
from
February 3, 2025 21:10
d4a9a82 to
cc29810
Compare
Contributor
Author
|
/ok to test |
Contributor
Author
|
/ok to test |
Contributor
Author
|
/ok to test |
Contributor
Author
|
/ok to test |
Contributor
Author
|
/ok to test |
Contributor
Author
|
/ok to test |
vyasr
marked this pull request as ready for review
February 4, 2025 22:10
cjnolet
approved these changes
Feb 4, 2025
bdice
reviewed
Feb 10, 2025
bdice
approved these changes
Feb 10, 2025
jameslamb
requested review from
jameslamb
and removed request for
raydouglass
February 10, 2025 23:03
jameslamb
approved these changes
Feb 10, 2025
jameslamb
left a comment
jameslamb
left a comment
Member
There was a problem hiding this comment.
Approving so I don't block merging, since we're now in the state where we need to start merging this sequence of PRs, assuming all the testing-specific stuff will be dropped before merging.
Please see my comment about declaring the dependency on rapids-logger... I think that is missing here.
…to feat/rapids_logger_library
Contributor
Author
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributes to rapidsai/build-planning#104.