Skip to content

Confusing/contradictory comment in primitives.py module #561

Description

@computbiolgeek

Lines 400 - 401 of openfold/model/primitives.py module have the following comment

        # DISCREPANCY: c_hidden is not the per-head channel dimension, as
        # stated in the supplement, but the overall channel dimension.

This comment is contradictory to description of c_hidden in the docstring of the init method as well as how c_hidden is used in the output dimension of the linear projections. Can the authors please clarify why there is a dicrepancy and how c_hidden is the overall channel dimension?

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions