update watch api: include schema changes#133
Merged
Merged
Conversation
miparnisari
force-pushed
the
update-watch-api-include-schema-changes
branch
from
f39a93f to
d90061c
Compare
miparnisari
force-pushed
the
update-watch-api-include-schema-changes
branch
2 times, most recently
from
180b035 to
e52b636
Compare
miparnisari
force-pushed
the
update-watch-api-include-schema-changes
branch
from
e52b636 to
70284c8
Compare
vroldanbet
reviewed
Mar 19, 2025
| // last watch response. | ||
| repeated ReflectionSchemaDiff schema_updates = 4; | ||
|
|
||
| // is_checkpoint, if true, indicates that a revision was reached. |
Contributor
There was a problem hiding this comment.
@miparnisari I think we should clarify this: "Reaching a revision" does not tell the client what guarantees they get from a checkpoint.
I would frame it as "a checkpoint indicates the server guarantees the client will not observe any changes at a revision below or equal to the revision in this response"
What do you think?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For authzed/spicedb#1995