Skip to content

modify watchResponse#135

Merged
miparnisari merged 2 commits into
mainfrom
modify-#133
Mar 20, 2025
Merged

modify watchResponse#135
miparnisari merged 2 commits into
mainfrom
modify-#133

Conversation

@miparnisari

Copy link
Copy Markdown
Contributor

Amendment to #133

@miparnisari

miparnisari commented Mar 20, 2025

Copy link
Copy Markdown
Contributor Author

Hmm need to figure out how to bypass the breaking change check for something that hasn't been released 🤔 the check is not required to merge the PR

@vroldanbet

Copy link
Copy Markdown
Contributor

the check is not required to merge the PR

@miparnisari that linter error is legit: you've introduced a breaking protobuf change. However, because we know the previous change was never officially released, we can override that linter error. We should do that by using GitHub's ability to "bypass with admin privileges" button once approved.

@josephschorr josephschorr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@miparnisari miparnisari merged commit 7144bbf into main Mar 20, 2025
@miparnisari miparnisari deleted the modify-#133 branch March 20, 2025 20:47
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 20, 2025
@tstirrat15

Copy link
Copy Markdown
Contributor

For the future, there's a different buf action where you can add a label to the PR to override the breaking schema change lint.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

4 participants