Improve error reporting for download failures#172
Open
dhruvildarji wants to merge 1 commit intocommaai:masterfrom
Open
Improve error reporting for download failures#172dhruvildarji wants to merge 1 commit intocommaai:masterfrom
dhruvildarji wants to merge 1 commit intocommaai:masterfrom
Conversation
Include URL, HTTP status code, and descriptive error messages when file downloads fail, making it easier to diagnose network/server issues. Previously, download failures were silently swallowed or reported with generic messages like "No orbit data found on either servers" with no indication of what actually went wrong. Now each failure is logged with the specific URL and error details. Fixes commaai#46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
download_parse_orbitinstead of silently swallowing themPreviously, when downloads failed, users would only see
RuntimeError: No orbit data found on either serverswith no indication of what actually went wrong (e.g., HTTP 404, connection timeout, DNS failure). Now each failure is logged with the specific URL and error, making it much easier to diagnose network/server issues.Test plan
Fixes #46