main_v2 - Optimize Crater Lake - Fix Warnings by DelphineChiu · Pull Request #224 · facebook/OpenBIC

DelphineChiu · 2022-04-01T04:06:24Z

Summary:

Fix all warnings in CL layer and common layer.
Refactor ME portion APIs

facebook-github-bot · 2022-04-01T17:48:52Z

@GoldenBug has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

GoldenBug · 2022-04-01T21:27:31Z


+int bat_3v_set_gpio(uint8_t sensor_num, void *arg)
+{
+	SET_GPIO_VALUE_CFG *cfg = arg;


Check to make sure arg != NULL

The optimization code is based on v2022.07.01. After that, the main branch has been phased in some
commits related to sensor monitoring. Those changes will be phased in main_v2 in the other PRs. This
problem will be solved in those PRs.
Please check #223 .

GoldenBug · 2022-04-01T21:28:40Z

+		*reading = (float)val * cfg->arg0 / cfg->arg1 / 1000;
+		cfg->cache = *reading;


check reading != NULL before use

The optimization code is based on v2022.07.01. After that, the main branch has been phased in some
commits related to sensor monitoring. Those changes will be phased in main_v2 in the other PRs. This
problem will be solved in those PRs.
Please check #223 .

GoldenBug · 2022-04-01T21:30:37Z

+		printf("Sensor number %x read fail\n", sensor_num);
+		return false;
+	}
+	*reading = val;


Check reading != NULL before use.

The optimization code is based on v2022.07.01. After that, the main branch has been phased in some
commits related to sensor monitoring. Those changes will be phased in main_v2 in the other PRs. This
problem will be solved in those PRs.
Please check #223 .

GoldenBug · 2022-04-01T21:32:36Z

+		return GUID_OUT_OF_RANGE;
+	}
+
+	memcpy(&entry->config, &guid_config[entry->config.dev_id], sizeof(EEPROM_CFG));


We should check that entry != NULL when passed in

The optimization code is based on v2022.07.01. After that, the main branch has been phased in some
commits related to sensor monitoring. Those changes will be phased in main_v2 in the other PRs. This
problem will be solved in those PRs.
Please check #223 .

Hi @GoldenBug
The optimization code is based on v2022.07.01. After that, the main branch has been phased in some
commits related to sensor monitoring. Those changes will be phased in main_v2 in the other PRs. This
problem will be solved in those PRs.
Please check #223 .

GoldenBug · 2022-04-01T21:33:18Z

+
+struct isl69260_page_data isl69260_page_data_args[] = { [0] = { 0x0, 0x0 }, [1] = { 0x0, 0x1 } };
+
+int isl69260_switch_page(uint8_t sensor_num, void *args)


check args != NULL

The optimization code is based on v2022.07.01. After that, the main branch has been phased in some
commits related to sensor monitoring. Those changes will be phased in main_v2 in the other PRs. This
problem will be solved in those PRs.
Please check #223 .

GoldenBug · 2022-04-01T21:42:00Z

+	} else {
+		// energy / unit time
+		*reading = ((float)diff_energy / (float)diff_time * 0.06103515625);
+		free(read_buf);


The optimization code is based on v2022.07.01. After that, the main branch has been phased in some
commits related to sensor monitoring. Those changes will be phased in main_v2 in the other PRs. This
problem will be solved in those PRs.
Please check #223 .

GoldenBug · 2022-04-01T21:42:23Z

+	}
+}
+
+bool peci_sensor_read(uint8_t sensor_num, float *reading)


check reading != NULL

The optimization code is based on v2022.07.01. After that, the main branch has been phased in some
commits related to sensor monitoring. Those changes will be phased in main_v2 in the other PRs. This
problem will be solved in those PRs.
Please check #223 .

GoldenBug · 2022-04-01T21:42:59Z

+		*reading = (float)val;
+		cfg->cache = *reading;
+		cfg->cache_status = SENSOR_READ_SUCCESS;
+		free(read_buf);


The optimization code is based on v2022.07.01. After that, the main branch has been phased in some
commits related to sensor monitoring. Those changes will be phased in main_v2 in the other PRs. This
problem will be solved in those PRs.
Please check #223 .

GoldenBug · 2022-04-01T21:43:25Z

+
+#define RETRY 5
+
+bool tmp75_read(uint8_t sensor_num, float *reading)


Check reading != NULL

The optimization code is based on v2022.07.01. After that, the main branch has been phased in some
commits related to sensor monitoring. Those changes will be phased in main_v2 in the other PRs. This
problem will be solved in those PRs.
Please check #223 .

GoldenBug · 2022-04-01T21:50:03Z

+	ipmi_message.InF_source = source_inft;
+	ipmi_message.InF_target = target_inft;
+	ipmi_message.data_len = data_len;
+	if (data_len != 0) {


&& data != NULL ?

We have fixed this and do the forced update.
Please review it. Thanks.

facebook-github-bot · 2022-04-07T07:45:48Z

@DelphineChiu has updated the pull request. You must reimport the pull request before landing.

facebook-github-bot · 2022-04-07T07:51:20Z

@DelphineChiu has updated the pull request. You must reimport the pull request before landing.

DelphineChiu · 2022-04-07T08:38:30Z

Dependency: #214

facebook-github-bot · 2022-04-07T21:18:21Z

@GoldenBug has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

GoldenBug · 2022-04-08T23:10:13Z

 	gpio_num = (group * GPIO_GROUP_SIZE) + pins;

 	if (gpio_cfg[gpio_num].int_cb == NULL) {
-		printk("CB func pointer NULL for gpio num %d\n", gpio_num);


CB -> Callback

Hi @GoldenBug
We have fixed this and done the forced update.
Please review it. Thanks.

GoldenBug · 2022-04-08T23:11:01Z

-	if (me_msg == NULL) {
-		printf("[%s] Failed to allocate memory\n", __func__);
+	if ((me_fw_mode != ME_FW_RECOVERY) && (me_fw_mode != ME_FW_RESTORE)) {
+		printf("Not support the ME frimware mode 0x%x setting", me_fw_mode);


"Unsupported ME firmware mode 0x%x setting"

We have fixed this and done the forced update.
Please review it. Thanks.

GoldenBug · 2022-04-08T23:12:21Z

+						 data_len, data);
+		ret = ipmb_read(me_msg, IPMB_inf_index_map[me_msg->InF_target]);
+		if (ret != IPMB_ERROR_SUCCESS) {
+			printf("Failed to set ME frimware mode to 0x%x, ret: 0x%x\n", me_fw_mode,


ME firmware

We have fixed this and done the forced update.
Please review it. Thanks.

GoldenBug · 2022-04-08T23:12:40Z

 		}
 	}
+	if (i == retry) {
+		printf("Failed to set ME frimware mode to 0x%x, retry time: %d\n", me_fw_mode,


ME firmware

We have fixed this and done the forced update.
Please review it. Thanks.

GoldenBug · 2022-04-08T23:22:25Z

 {
-	uint8_t proj_stage = (FIRMWARE_REVISION_1 & 0xf0) >> 4;
-	printk("Hello, wellcome to yv35 craterlake %x%x.%x.%x\n", BIC_FW_YEAR_MSB, BIC_FW_YEAR_LSB,
+	printf("Hello, wellcome to yv35 craterlake %x%x.%x.%x\n", BIC_FW_YEAR_MSB, BIC_FW_YEAR_LSB,


We have fixed this and done the forced update.
Please review it. Thanks.

Summary: - Fix all warnings in CL layer and common layer. - Refactor ME portion APIs

facebook-github-bot · 2022-04-12T02:48:59Z

@DelphineChiu has updated the pull request. You must reimport the pull request before landing.

facebook-github-bot · 2022-04-12T20:40:40Z

@GoldenBug has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Summary: - Fix all warnings in CL layer and common layer. - Refactor ME portion APIs Pull Request resolved: #224 Reviewed By: garnermic Differential Revision: D35319956 Pulled By: GoldenBug fbshipit-source-id: c5ec0e0806bd40c5a92ac1c9c8792446dd4cd88d

Summary: - Fix all warnings in CL layer and common layer. - Refactor ME portion APIs Pull Request resolved: #224 Reviewed By: garnermic Differential Revision: D35941608 Pulled By: GoldenBug fbshipit-source-id: 5537e193e18801062cd0acc728bd1c6466aeebbb

facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 1, 2022

GoldenBug suggested changes Apr 1, 2022

View reviewed changes

BonnieLo force-pushed the PR/cl-refactor branch from d63996c to d36fa1b Compare April 7, 2022 07:45

BonnieLo force-pushed the PR/cl-refactor branch from d36fa1b to cd5a7bc Compare April 7, 2022 07:51

BonnieLo mentioned this pull request Apr 7, 2022

Move sensor monitoring changes from main to main_v2 #223

Closed

DelphineChiu mentioned this pull request Apr 7, 2022

main_v2 - Refactor Baseboard layer #225

Closed

GoldenBug suggested changes Apr 8, 2022

View reviewed changes

GoldenBug reviewed Apr 8, 2022

View reviewed changes

Optimize Crater Lake - Fix Warnings

e0c347f

Summary: - Fix all warnings in CL layer and common layer. - Refactor ME portion APIs

BonnieLo force-pushed the PR/cl-refactor branch from cd5a7bc to e0c347f Compare April 12, 2022 02:48

DelphineChiu mentioned this pull request Apr 12, 2022

main_v2 - Move main to common layer #227

Closed

GoldenBug closed this Apr 13, 2022

		reading = (float)val cfg->arg0 / cfg->arg1 / 1000;
		cfg->cache = *reading;


		struct isl69260_page_data isl69260_page_data_args[] = { [0] = { 0x0, 0x0 }, [1] = { 0x0, 0x1 } };

		int isl69260_switch_page(uint8_t sensor_num, void *args)


		#define RETRY 5

		bool tmp75_read(uint8_t sensor_num, float *reading)

Uh oh!

Conversation

DelphineChiu commented Apr 1, 2022

facebook-github-bot commented Apr 1, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

facebook-github-bot commented Apr 7, 2022

facebook-github-bot commented Apr 7, 2022

DelphineChiu commented Apr 7, 2022

facebook-github-bot commented Apr 7, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

facebook-github-bot commented Apr 12, 2022

facebook-github-bot commented Apr 12, 2022

Labels

4 participants