main_v2 - Refactor Baseboard layer#225
Closed
DelphineChiu wants to merge 2 commits into
Closed
Conversation
facebook-github-bot
added
the
CLA Signed
Contributor
|
@GoldenBug has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
|
@DelphineChiu has updated the pull request. You must reimport the pull request before landing. |
Author
Contributor
|
@GoldenBug has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Summary:
- Fix all warnings in CL layer and common layer.
- Refactor ME portion APIs
Summary:
- Refactor Baseboard layer following Crater Lake
Contributor
|
@DelphineChiu has updated the pull request. You must reimport the pull request before landing. |
Contributor
|
@GoldenBug has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Apr 13, 2022
Summary: - Refactor Baseboard layer code following main_v2 Pull Request resolved: #225 Reviewed By: garnermic Differential Revision: D35319964 Pulled By: GoldenBug fbshipit-source-id: 83ed43488c004d17c2686b861b66232e4584a3c7
facebook-github-bot
pushed a commit
that referenced
this pull request
Apr 26, 2022
Summary: - Refactor Baseboard layer code following main_v2 Pull Request resolved: #225 Reviewed By: garnermic Differential Revision: D35941623 Pulled By: GoldenBug fbshipit-source-id: eddd2c8a93d02a79bbc1962b40ba09ce6a974544
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: