Skip to content

fby3.5: common:Improve sensor monitor#339

Closed
DelphineChiu wants to merge 1 commit into
facebook:mainfrom
Wiwynn:fby3.5-Optimize_sensor_monitor_arch
Closed

fby3.5: common:Improve sensor monitor#339
DelphineChiu wants to merge 1 commit into
facebook:mainfrom
Wiwynn:fby3.5-Optimize_sensor_monitor_arch

Conversation

@DelphineChiu

@DelphineChiu DelphineChiu commented Jun 16, 2022

Copy link
Copy Markdown

Summary:

  • Improve sensor monitor
    • Function sdr_init: the index used to store the SDR last id is represented by SDR count.
    • Function sdr_init: remove redundant debug messages.
    • Function get_sensor_config_index: remove unnecessary 'for' loop.
    • Function sensor_poll_handler: remove redundancy flag.
    • Function get_sensor_reading: update cache status in all cases.
    • Function sensor_polling_handler: sensor monitor check sensor number according to sensor config table.
    • Enum device_init_type: modify device type to increase sequentially.
    • Variable SDR_NUM: modify variable name to SDR_COUNT making name more readable.
    • Command platform: add sensor type/sensor status mapping table to get current sensor infomation in BIC console.

Test Plan:

  • Build code: Pass
  • Check sensor-util get sensor value is normal after optimizing sensor monitor architecture in different board: Pass
  • Check sensor-util get sensor value is normal after AC/DC cycle 50 times: Pass

Test Board Test result

Config A Craterlake BIC EVT2 Pass
Config A Craterlake BIC EVT3_ADI Pass
Config A Craterlake BIC EVT3_MP5990 Pass
Config B Craterlake BIC EVT2 + DPV2 Pass
Config B Craterlake BIC EVT3_ADI + DPV2 Pass
Config B Craterlake BIC EVT3_MP5990 + DPV2 Pass
Config C Craterlake BIC EVT2 + Rainbow falls BIC Pass
Config C Craterlake BIC EVT3_ADI + Rainbow falls BIC Pass
COnfig D Craterlake BIC EVT2 + Baseboard BIC Pass

Log:
[BMC console]

EVT2/EVT3 ADI/EVT3 MP5990
root@bmc-oob:~# sensor-util slot2 --threshold
slot2:
MB Inlet Temp (0x1) : 33.00 C | (ok) | UCR: 48.00 | UNC: NA | UNR: 150.00 | LCR: NA | LNC: NA | LNR: NA
MB Outlet Temp (0x2) : 50.00 C | (ok) | UCR: 93.00 | UNC: NA | UNR: 150.00 | LCR: NA | LNC: NA | LNR: NA
FIO Temp (0x3) : 31.00 C | (ok) | UCR: 40.00 | UNC: NA | UNR: NA | LCR: NA | LNC: NA | LNR: NA
PCH Temp (0x4) : 47.00 C | (ok) | UCR: 74.00 | UNC: NA | UNR: NA | LCR: NA | LNC: NA | LNR: NA
SOC CPU Temp (0x5) : 44.00 C | (ok) | UCR: 84.00 | UNC: NA | UNR: NA | LCR: NA | LNC: NA | LNR: NA
SOC Therm Margin (0x14) : -56.00 C | (ok) | UCR: NA | UNC: NA | UNR: 125.00 | LCR: NA | LNC: NA | LNR: NA
CPU TjMax (0x15) : 100.00 C | (ok) | UCR: NA | UNC: NA | UNR: 125.00 | LCR: NA | LNC: NA | LNR: NA
DIMMA Temp (0x6) : 47.00 C | (ok) | UCR: 85.00 | UNC: NA | UNR: NA | LCR: NA | LNC: NA | LNR: NA
DIMMC Temp (0x7) : 47.00 C | (ok) | UCR: 85.00 | UNC: NA | UNR: NA | LCR: NA | LNC: NA | LNR: NA
DIMMD Temp (0x9) : 44.00 C | (ok) | UCR: 85.00 | UNC: NA | UNR: NA | LCR: NA | LNC: NA | LNR: NA
DIMME Temp (0xA) : 46.00 C | (ok) | UCR: 85.00 | UNC: NA | UNR: NA | LCR: NA | LNC: NA | LNR: NA
DIMMG Temp (0xB) : 42.00 C | (ok) | UCR: 85.00 | UNC: NA | UNR: NA | LCR: NA | LNC: NA | LNR: NA
DIMMH Temp (0xC) : 39.00 C | (ok) | UCR: 85.00 | UNC: NA | UNR: NA | LCR: NA | LNC: NA | LNR: NA
SSD0 Temp (0xD) : 35.00 C | (ok) | UCR: 75.00 | UNC: NA | UNR: NA | LCR: NA | LNC: NA | LNR: NA
HSC Temp (0xE) : 46.67 C | (ok) | UCR: 86.00 | UNC: NA | UNR: 125.00 | LCR: NA | LNC: NA | LNR: NA
VCCIN SPS Temp (0xF) : 57.00 C | (ok) | UCR: 100.00 | UNC: NA | UNR: 125.00 | LCR: NA | LNC: NA | LNR: NA
FIVRA SPS Temp (0x10) : 54.00 C | (ok) | UCR: 100.00 | UNC: NA | UNR: 125.00 | LCR: NA | LNC: NA | LNR: NA
EHV SPS Temp (0x11) : 46.00 C | (ok) | UCR: 100.00 | UNC: NA | UNR: 125.00 | LCR: NA | LNC: NA | LNR: NA
VCCD SPS Temp (0x12) : 43.00 C | (ok) | UCR: 100.00 | UNC: NA | UNR: 125.00 | LCR: NA | LNC: NA | LNR: NA
FAON SPS Temp (0x13) : 48.00 C | (ok) | UCR: 100.00 | UNC: NA | UNR: 125.00 | LCR: NA | LNC: NA | LNR: NA
P12V_STBY Vol (0x20) : 12.68 Volts | (ok) | UCR: 13.36 | UNC: 13.23 | UNR: 14.36 | LCR: 10.71 | LNC: 10.84 | LNR: 10.08
P3V_BAT Vol (0x21) : 3.13 Volts | (ok) | UCR: 3.51 | UNC: 3.46 | UNR: NA | LCR: 2.76 | LNC: 2.79 | LNR: NA
P3V3_STBY Vol (0x22) : 3.34 Volts | (ok) | UCR: 3.56 | UNC: 3.53 | UNR: 4.00 | LCR: 3.04 | LNC: 3.08 | LNR: 2.30
P1V8_STBY Vol (0x23) : 1.81 Volts | (ok) | UCR: 1.92 | UNC: 1.90 | UNR: 2.09 | LCR: 1.67 | LNC: 1.69 | LNR: 1.44
P1V05_PCH Vol (0x24) : 1.06 Volts | (ok) | UCR: 1.12 | UNC: 1.10 | UNR: 1.22 | LCR: 0.97 | LNC: 0.98 | LNR: 0.84
P5V_STBY Vol (0x25) : 5.02 Volts | (ok) | UCR: 5.40 | UNC: 5.35 | UNR: 5.80 | LCR: 4.59 | LNC: 4.64 | LNR: 4.00
P12V_DIMM Vol (0x26) : 12.73 Volts | (ok) | UCR: 14.21 | UNC: 14.07 | UNR: NA | LCR: 9.87 | LNC: 10.01 | LNR: NA
P1V2_STBY Vol (0x27) : 1.20 Volts | (ok) | UCR: 1.30 | UNC: 1.28 | UNR: 1.39 | LCR: 1.10 | LNC: 1.12 | LNR: 0.96
P3V3_M2 Vol (0x28) : 3.33 Volts | (ok) | UCR: 3.71 | UNC: 3.67 | UNR: NA | LCR: 2.91 | LNC: 2.94 | LNR: NA
HSC Input Vol (0x29) : 12.51 Volts | (ok) | UCR: 13.36 | UNC: 13.23 | UNR: 14.36 | LCR: 10.71 | LNC: 10.84 | LNR: 10.08
VCCIN VR Vol (0x2A) : 1.77 Volts | (ok) | UCR: 1.93 | UNC: 1.91 | UNR: 2.20 | LCR: 1.64 | LNC: 1.66 | LNR: 0.40
FIVRA VR Vol (0x2C) : 1.82 Volts | (ok) | UCR: 1.92 | UNC: 1.90 | UNR: 2.20 | LCR: 1.69 | LNC: 1.71 | LNR: 0.40
EHV VR Vol (0x2D) : 1.80 Volts | (ok) | UCR: 1.90 | UNC: 1.88 | UNR: 2.20 | LCR: 1.70 | LNC: 1.72 | LNR: 0.40
VCCD VR Vol (0x2E) : 1.14 Volts | (ok) | UCR: 1.23 | UNC: 1.21 | UNR: 1.50 | LCR: 1.05 | LNC: 1.06 | LNR: 0.40
FAON VR Vol (0x2F) : 1.05 Volts | (ok) | UCR: 1.09 | UNC: 1.07 | UNR: 1.40 | LCR: 0.90 | LNC: 0.91 | LNR: 0.40
HSC Output Cur (0x30) : 6.10 Amps | (ok) | UCR: 31.96 | UNC: 28.73 | UNR: 39.95 | LCR: NA | LNC: NA | LNR: NA
VCCIN VR Cur (0x31) : 14.50 Amps | (ok) | UCR: 141.18 | UNC: 119.34 | UNR: 180.18 | LCR: NA | LNC: NA | LNR: NA
FIVRA VR Cur (0x32) : 3.60 Amps | (ok) | UCR: 53.01 | UNC: 48.05 | UNR: 70.99 | LCR: NA | LNC: NA | LNR: NA
EHV VR Cur (0x33) : 0.80 Amps | (ok) | UCR: 6.24 | UNC: 5.04 | UNR: 18.00 | LCR: NA | LNC: NA | LNR: NA
VCCD VR Cur (0x34) : 2.70 Amps | (ok) | UCR: 30.02 | UNC: 26.98 | UNR: 42.94 | LCR: NA | LNC: NA | LNR: NA
FAON VR Cur (0x35) : 7.60 Amps | (ok) | UCR: 46.02 | UNC: 42.12 | UNR: 60.06 | LCR: NA | LNC: NA | LNR: NA
CPU PWR (0x38) : 58.00 Watts | (ok) | UCR: NA | UNC: NA | UNR: NA | LCR: NA | LNC: NA | LNR: NA
HSC Input Pwr (0x39) : 81.69 Watts | (ok) | UCR: 399.28 | UNC: 360.22 | UNR: 499.10 | LCR: NA | LNC: NA | LNR: NA
VCCIN VR Pout (0x3A) : 23.00 Watts | (ok) | UCR: 253.80 | UNC: 214.32 | UNR: 324.30 | LCR: NA | LNC: NA | LNR: NA
FIVRA VR Pout (0x3C) : 6.00 Watts | (ok) | UCR: 95.19 | UNC: 86.64 | UNR: 127.68 | LCR: NA | LNC: NA | LNR: NA
EHV VR Pout (0x3D) : 1.00 Watts | (ok) | UCR: 11.25 | UNC: 8.97 | UNR: 32.38 | LCR: NA | LNC: NA | LNR: NA
VCCD VR Pout (0x3E) : 2.00 Watts | (ok) | UCR: 34.32 | UNC: 31.02 | UNR: 49.28 | LCR: NA | LNC: NA | LNR: NA
FAON VR Pout (0x3F) : 7.00 Watts | (ok) | UCR: 49.28 | UNC: 45.08 | UNR: 64.12 | LCR: NA | LNC: NA | LNR: NA
DIMMA PMIC_Pout (0x1E) : 0.38 Watts | (ok) | UCR: 32.20 | UNC: 31.50 | UNR: NA | LCR: NA | LNC: NA | LNR: NA
DIMMC PMIC_Pout (0x1F) : 0.62 Watts | (ok) | UCR: 32.20 | UNC: 31.50 | UNR: NA | LCR: NA | LNC: NA | LNR: NA
DIMMD PMIC_Pout (0x36) : 0.50 Watts | (ok) | UCR: 32.20 | UNC: 31.50 | UNR: NA | LCR: NA | LNC: NA | LNR: NA
DIMME PMIC_Pout (0x37) : 0.62 Watts | (ok) | UCR: 32.20 | UNC: 31.50 | UNR: NA | LCR: NA | LNC: NA | LNR: NA
DIMMG PMIC_Pout (0x42) : 0.50 Watts | (ok) | UCR: 32.20 | UNC: 31.50 | UNR: NA | LCR: NA | LNC: NA | LNR: NA
DIMMH PMIC_Pout (0x47) : 0.75 Watts | (ok) | UCR: 32.20 | UNC: 31.50 | UNR: NA | LCR: NA | LNC: NA | LNR: NA

Baseboard BIC
root@bmc-oob:~# sensor-util slot1 --threshold | grep BB
BB_INLET_TEMP (0xD1) : 23.76 C | (ok) | UCR: 50.00 | UNC: NA | UNR: 150.00 | LCR: NA | LNC: NA | LNR: NA
BB_OUTLET_TEMP (0xD2) : 25.76 C | (ok) | UCR: 55.00 | UNC: NA | UNR: 150.00 | LCR: NA | LNC: NA | LNR: NA
BB_HSC_TEMP (0xD3) : 22.14 C | (ok) | UCR: 55.00 | UNC: NA | UNR: 125.00 | LCR: NA | LNC: NA | LNR: NA
BB_P5V_STBY (0xD4) : 5.14 Volts | (ok) | UCR: 5.55 | UNC: 5.50 | UNR: 5.65 | LCR: 4.45 | LNC: 4.50 | LNR: 4.15
BB_P12V_STBY (0xD5) : 12.71 Volts | (ok) | UCR: 13.29 | UNC: 13.17 | UNR: 14.30 | LCR: 10.71 | LNC: 10.77 | LNR: 10.08
BB_P3V3_STBY (0xD6) : 3.36 Volts | (ok) | UCR: 3.57 | UNC: 3.54 | UNR: 3.73 | LCR: 3.04 | LNC: 3.07 | LNR: 2.74
BB_P5V_USB (0xE9) : 5.14 Volts | (ok) | UCR: 5.40 | UNC: 5.35 | UNR: 5.65 | LCR: 4.60 | LNC: 4.65 | LNR: 4.15
BB_P1V2_STBY (0xD9) : 1.21 Volts | (ok) | UCR: 1.30 | UNC: 1.28 | UNR: 1.36 | LCR: 1.10 | LNC: 1.12 | LNR: 1.00
BB_P1V0_STBY (0xDA) : 1.01 Volts | (ok) | UCR: 1.08 | UNC: 1.07 | UNR: 1.13 | LCR: 0.92 | LNC: 0.93 | LNR: 0.83
BB_MEDUSA_VIN (0xDB) : 12.55 Volts | (ok) | UCR: 13.88 | UNC: 13.75 | UNR: 14.00 | LCR: 11.12 | LNC: 11.25 | LNR: 9.25
BB_MEDUSA_VOUT (0xD7) : 12.55 Volts | (ok) | UCR: 13.88 | UNC: 13.75 | UNR: 14.00 | LCR: 11.12 | LNC: 11.25 | LNR: 9.25
BB_HSC_VIN (0xDC) : 12.52 Volts | (ok) | UCR: 13.29 | UNC: 13.17 | UNR: 14.30 | LCR: 10.71 | LNC: 10.77 | LNR: 10.08
BB_MEDUSA_CUR (0xDF) : 13.18 Amps | (ok) | UCR: 144.00 | UNC: NA | UNR: NA | LCR: NA | LNC: NA | LNR: NA
BB_HSC_IOUT (0xDE) : 5.97 Amps | (ok) | UCR: 22.96 | UNC: NA | UNR: 31.92 | LCR: NA | LNC: NA | LNR: NA
BB_FAN_IOUT (0xE8) : 2.69 Amps | (ok) | UCR: 14.56 | UNC: NA | UNR: 39.26 | LCR: NA | LNC: NA | LNR: NA
BB_MEDUSA_PWR (0xD8) : 165.45 Watts | (ok) | UCR: 1800.00 | UNC: NA | UNR: NA | LCR: NA | LNC: NA | LNR: NA
BB_HSC_PIN (0xDD) : 74.34 Watts | (ok) | UCR: 287.10 | UNC: NA | UNR: 398.46 | LCR: NA | LNC: NA | LNR: NA
BB_HSC_EIN (0xEA) : 72.65 Watts | (ok) | UCR: NA | UNC: NA | UNR: NA | LCR: NA | LNC: NA | LNR: NA
BB_HSC_PEAK_IOUT (0xEB) : 15.23 Amps | (ok) | UCR: NA | UNC: NA | UNR: NA | LCR: NA | LNC: NA | LNR: NA
BB_HSC_PEAK_PIN (0xEC) : 190.76 Watts | (ok) | UCR: NA | UNC: NA | UNR: NA | LCR: NA | LNC: NA | LNR: NA

DPV2
root@bmc-oob:~# sensor-util slot1 --threshold | grep DPV2
DPV2_1_12V_VIN (0x8C) : 12.40 Volts | (ok) | UCR: 13.20 | UNC: 12.96 | UNR: 14.00 | LCR: 10.80 | LNC: 11.04 | LNR: 10.00
DPV2_1_12V_VOUT (0x8D) : 12.42 Volts | (ok) | UCR: 13.20 | UNC: 12.96 | UNR: 14.00 | LCR: 10.80 | LNC: 11.04 | LNR: 10.00
DPV2_1_12V_IOUT (0x8E) : 0.14 Amps | (ok) | UCR: 15.47 | UNC: 15.17 | UNR: 18.90 | LCR: NA | LNC: NA | LNR: NA
DPV2_1_EFUSETemp (0x8F) : 22.38 C | (ok) | UCR: 100.00 | UNC: NA | UNR: 150.00 | LCR: NA | LNC: NA | LNR: NA
DPV2_1_EFUSEPWR (0x90) : 1.19 Watts | (ok) | UCR: 186.00 | UNC: NA | UNR: 226.80 | LCR: NA | LNC: NA | LNR: NA

[BIC console]

EVT3 ADI
uart:~$ platform sensor list_all

[0x1 ] Unsupported name : tmp75 | access[O] | 4byte_acur_read_success | 31
[0x2 ] Unsupported name : tmp431 | access[O] | 4byte_acur_read_success | 24576048
[0x3 ] Unsupported name : tmp75 | access[O] | 4byte_acur_read_success | 29
[0xd ] Unsupported name : nvme | access[O] | 4byte_acur_read_success | 32
[0x5 ] Unsupported name : peci | access[O] | 4byte_acur_read_success | 41
[0x14] Unsupported name : peci | access[O] | 4byte_acur_read_success | 59
[0x15] Unsupported name : peci | access[O] | 4byte_acur_read_success | 100
[0x6 ] Unsupported name : peci | access[O] | 4byte_acur_read_success | 45
[0x7 ] Unsupported name : peci | access[O] | 4byte_acur_read_success | 45
[0x9 ] Unsupported name : peci | access[O] | 4byte_acur_read_success | 43
[0xa ] Unsupported name : peci | access[O] | 4byte_acur_read_success | 44
[0xb ] Unsupported name : peci | access[O] | 4byte_acur_read_success | 42
[0xc ] Unsupported name : peci | access[O] | 4byte_acur_read_success | 38
[0x38] Unsupported name : peci | access[O] | 4byte_acur_read_success | 56
[0x20] Unsupported name : adc | access[O] | 4byte_acur_read_success | 34865164
[0x22] Unsupported name : adc | access[O] | 4byte_acur_read_success | 20578307
[0x24] Unsupported name : adc | access[O] | 4byte_acur_read_success | 3080193
[0x21] Unsupported name : adc | access[O] | 4byte_acur_read_success | 5898243
[0x25] Unsupported name : adc | access[O] | 4byte_acur_read_success | 1507333
[0x26] Unsupported name : adc | access[O] | 4byte_acur_read_success | 41418764
[0x27] Unsupported name : adc | access[O] | 4byte_acur_read_success | 13172737
[0x28] Unsupported name : adc | access[O] | 4byte_acur_read_success | 19922947
[0x23] Unsupported name : adc | access[O] | 4byte_acur_read_success | 52822017
[0x2e] Unsupported name : isl69259 | access[O] | 4byte_acur_read_success | 9306113
[0x2f] Unsupported name : isl69259 | access[O] | 4byte_acur_read_success | 3473409
[0x2d] Unsupported name : isl69259 | access[O] | 4byte_acur_read_success | 52428801
[0x2a] Unsupported name : isl69259 | access[O] | 4byte_acur_read_success | 40435713
[0x2c] Unsupported name : isl69259 | access[O] | 4byte_acur_read_success | 53608449
[0x34] Unsupported name : isl69259 | access[O] | 4byte_acur_read_success | 52428802
[0x35] Unsupported name : isl69259 | access[O] | 4byte_acur_read_success | 19660807
[0x33] Unsupported name : isl69259 | access[O] | 4byte_acur_read_success | 52428800
[0x31] Unsupported name : isl69259 | access[O] | 4byte_acur_read_success | 26214414
[0x32] Unsupported name : isl69259 | access[O] | 4byte_acur_read_success | 4
[0x12] Unsupported name : isl69259 | access[O] | 4byte_acur_read_success | 43
[0x13] Unsupported name : isl69259 | access[O] | 4byte_acur_read_success | 47
[0x11] Unsupported name : isl69259 | access[O] | 4byte_acur_read_success | 43
[0xf ] Unsupported name : isl69259 | access[O] | 4byte_acur_read_success | 55
[0x10] Unsupported name : isl69259 | access[O] | 4byte_acur_read_success | 52
[0x3e] Unsupported name : isl69259 | access[O] | 4byte_acur_read_success | 2
[0x3f] Unsupported name : isl69259 | access[O] | 4byte_acur_read_success | 8
[0x3d] Unsupported name : isl69259 | access[O] | 4byte_acur_read_success | 1
[0x3a] Unsupported name : isl69259 | access[O] | 4byte_acur_read_success | 33
[0x3c] Unsupported name : isl69259 | access[O] | 4byte_acur_read_success | 6
[0x4 ] Unsupported name : pch | access[O] | 4byte_acur_read_success | 48
[0x1e] Unsupported name : pmic | access[O] | 4byte_acur_read_success | 49152000
[0x1f] Unsupported name : pmic | access[O] | 4byte_acur_read_success | 32768000
[0x36] Unsupported name : pmic | access[O] | 4byte_acur_read_success | 49152000
[0x37] Unsupported name : pmic | access[O] | 4byte_acur_read_success | 40960000
[0x42] Unsupported name : pmic | access[O] | 4byte_acur_read_success | 32768000
[0x47] Unsupported name : pmic | access[O] | 4byte_acur_read_success | 32768000
[0xe ] Unsupported name : tmp431 | access[O] | 4byte_acur_read_success | 24576045
[0x29] Unsupported name : hsc | access[O] | 4byte_acur_read_success | 34144268
[0x30] Unsupported name : hsc | access[O] | 4byte_acur_read_success | 1572869
[0x39] Unsupported name : hsc | access[O] | 4byte_acur_read_success | 21692477

EVT3 MP5990
uart:~$ platform sensor list_all

[0x1 ] Unsupported name : tmp75 | access[O] | 4byte_acur_read_success | 26
[0x2 ] Unsupported name : tmp75 | access[O] | 4byte_acur_read_success | 30
[0x3 ] Unsupported name : tmp75 | access[O] | 4byte_acur_read_success | 27
[0xd ] Unsupported name : nvme | access[O] | 4byte_acur_read_success | 23
[0x5 ] Unsupported name : peci | access[O] | 4byte_acur_read_success | 31
[0x14] Unsupported name : peci | access[O] | 4byte_acur_read_success | 69
[0x15] Unsupported name : peci | access[O] | 4byte_acur_read_success | 100
[0x6 ] Unsupported name : peci | access[O] | 4byte_acur_read_success | 27
[0x7 ] Unsupported name : peci | access[O] | 4byte_acur_read_success | 27
[0x9 ] Unsupported name : peci | access[O] | 4byte_acur_read_success | 26
[0xa ] Unsupported name : peci | access[O] | 4byte_acur_read_success | 27
[0xb ] Unsupported name : peci | access[O] | 4byte_acur_read_success | 26
[0xc ] Unsupported name : peci | access[O] | 4byte_acur_read_success | 27
[0x38] Unsupported name : peci | access[O] | 4byte_acur_read_success | 74
[0x20] Unsupported name : adc | access[O] | 4byte_acur_read_success | 34865164
[0x22] Unsupported name : adc | access[O] | 4byte_acur_read_success | 21889027
[0x24] Unsupported name : adc | access[O] | 4byte_acur_read_success | 3538945
[0x21] Unsupported name : adc | access[O] | 4byte_acur_read_success | 2949123
[0x25] Unsupported name : adc | access[O] | 4byte_acur_read_success | 61407236
[0x26] Unsupported name : adc | access[O] | 4byte_acur_read_success | 25296908
[0x27] Unsupported name : adc | access[O] | 4byte_acur_read_success | 12320769
[0x28] Unsupported name : adc | access[O] | 4byte_acur_read_success | 19922947
[0x23] Unsupported name : adc | access[O] | 4byte_acur_read_success | 51707905
[0x2e] Unsupported name : isl69259 | access[O] | 4byte_acur_read_success | 9371649
[0x2f] Unsupported name : isl69259 | access[O] | 4byte_acur_read_success | 3276801
[0x2d] Unsupported name : isl69259 | access[O] | 4byte_acur_read_success | 52428801
[0x2a] Unsupported name : isl69259 | access[O] | 4byte_acur_read_success | 50593793
[0x2c] Unsupported name : isl69259 | access[O] | 4byte_acur_read_success | 53608449
[0x34] Unsupported name : isl69259 | access[O] | 4byte_acur_read_success | 52428802
[0x35] Unsupported name : isl69259 | access[O] | 4byte_acur_read_success | 58982408
[0x33] Unsupported name : isl69259 | access[O] | 4byte_acur_read_success | 52428800
[0x31] Unsupported name : isl69259 | access[O] | 4byte_acur_read_success | 6553632
[0x32] Unsupported name : isl69259 | access[O] | 4byte_acur_read_success | 45875203
[0x12] Unsupported name : isl69259 | access[O] | 4byte_acur_read_success | 33
[0x13] Unsupported name : isl69259 | access[O] | 4byte_acur_read_success | 37
[0x11] Unsupported name : isl69259 | access[O] | 4byte_acur_read_success | 32
[0xf ] Unsupported name : isl69259 | access[O] | 4byte_acur_read_success | 39
[0x10] Unsupported name : isl69259 | access[O] | 4byte_acur_read_success | 36
[0x3e] Unsupported name : isl69259 | access[O] | 4byte_acur_read_success | 2
[0x3f] Unsupported name : isl69259 | access[O] | 4byte_acur_read_success | 9
[0x3d] Unsupported name : isl69259 | access[O] | 4byte_acur_read_success | 1
[0x3a] Unsupported name : isl69259 | access[O] | 4byte_acur_read_success | 56
[0x3c] Unsupported name : isl69259 | access[O] | 4byte_acur_read_success | 7
[0x4 ] Unsupported name : pch | access[O] | 4byte_acur_read_success | 36
[0x1e] Unsupported name : pmic | access[O] | 4byte_acur_read_success | 32768000
[0x1f] Unsupported name : pmic | access[O] | 4byte_acur_read_success | 32768000
[0x36] Unsupported name : pmic | access[O] | 4byte_acur_read_success | 24576000
[0x37] Unsupported name : pmic | access[O] | 4byte_acur_read_success | 40960000
[0x42] Unsupported name : pmic | access[O] | 4byte_acur_read_success | 24576000
[0x47] Unsupported name : pmic | access[O] | 4byte_acur_read_success | 32768000
[0xe ] Unsupported name : mp5990 | access[O] | 4byte_acur_read_success | 31
[0x29] Unsupported name : mp5990 | access[O] | 4byte_acur_read_success | 26607628
[0x30] Unsupported name : mp5990 | access[O] | 4byte_acur_read_success | 32768007
[0x39] Unsupported name : mp5990 | access[O] | 4byte_acur_read_success | 93

EVT2 + DPV2
uart:~$ platform sensor list_all

[0x1 ] Unsupported name : tmp75 | access[O] | 4byte_acur_read_success | 26
[0x2 ] Unsupported name : tmp75 | access[O] | 4byte_acur_read_success | 36
[0x3 ] Unsupported name : tmp75 | access[O] | 4byte_acur_read_success | 25
[0xd ] Unsupported name : nvme | access[O] | 4byte_acur_read_success | 30
[0x5 ] Unsupported name : peci | access[O] | 4byte_acur_read_success | 34
[0x14] Unsupported name : peci | access[O] | 4byte_acur_read_success | 66
[0x15] Unsupported name : peci | access[O] | 4byte_acur_read_success | 100
[0x6 ] Unsupported name : peci | access[O] | 4byte_acur_read_success | 29
[0x7 ] Unsupported name : peci | access[O] | 4byte_acur_read_success | 28
[0x9 ] Unsupported name : peci | access[O] | 4byte_acur_read_success | 28
[0xa ] Unsupported name : peci | access[O] | 4byte_acur_read_success | 29
[0xb ] Unsupported name : peci | access[O] | 4byte_acur_read_success | 29
[0xc ] Unsupported name : peci | access[O] | 4byte_acur_read_success | 29
[0x38] Unsupported name : peci | access[O] | 4byte_acur_read_success | 79
[0x20] Unsupported name : adc | access[O] | 4byte_acur_read_success | 34865164
[0x22] Unsupported name : adc | access[O] | 4byte_acur_read_success | 21626883
[0x24] Unsupported name : adc | access[O] | 4byte_acur_read_success | 3211265
[0x21] Unsupported name : adc | access[O] | 4byte_acur_read_success | 6291459
[0x25] Unsupported name : adc | access[O] | 4byte_acur_read_success | 63045636
[0x26] Unsupported name : adc | access[O] | 4byte_acur_read_success | 31850508
[0x27] Unsupported name : adc | access[O] | 4byte_acur_read_success | 12648449
[0x28] Unsupported name : adc | access[O] | 4byte_acur_read_success | 20578307
[0x23] Unsupported name : adc | access[O] | 4byte_acur_read_success | 52494337
[0x2e] Unsupported name : isl69259 | access[O] | 4byte_acur_read_success | 9306113
[0x2f] Unsupported name : isl69259 | access[O] | 4byte_acur_read_success | 3211265
[0x2d] Unsupported name : isl69259 | access[O] | 4byte_acur_read_success | 52428801
[0x2a] Unsupported name : isl69259 | access[O] | 4byte_acur_read_success | 50397185
[0x2c] Unsupported name : isl69259 | access[O] | 4byte_acur_read_success | 53608449
[0x34] Unsupported name : isl69259 | access[O] | 4byte_acur_read_success | 52428802
[0x35] Unsupported name : isl69259 | access[O] | 4byte_acur_read_success | 6553609
[0x33] Unsupported name : isl69259 | access[O] | 4byte_acur_read_success | 58982400
[0x31] Unsupported name : isl69259 | access[O] | 4byte_acur_read_success | 6553634
[0x32] Unsupported name : isl69259 | access[O] | 4byte_acur_read_success | 6553604
[0x12] Unsupported name : isl69259 | access[O] | 4byte_acur_read_success | 35
[0x13] Unsupported name : isl69259 | access[O] | 4byte_acur_read_success | 38
[0x11] Unsupported name : isl69259 | access[O] | 4byte_acur_read_success | 34
[0xf ] Unsupported name : isl69259 | access[O] | 4byte_acur_read_success | 46
[0x10] Unsupported name : isl69259 | access[O] | 4byte_acur_read_success | 40
[0x3e] Unsupported name : isl69259 | access[O] | 4byte_acur_read_success | 2
[0x3f] Unsupported name : isl69259 | access[O] | 4byte_acur_read_success | 9
[0x3d] Unsupported name : isl69259 | access[O] | 4byte_acur_read_success | 1
[0x3a] Unsupported name : isl69259 | access[O] | 4byte_acur_read_success | 60
[0x3c] Unsupported name : isl69259 | access[O] | 4byte_acur_read_success | 6
[0x4 ] Unsupported name : pch | access[O] | 4byte_acur_read_success | 36
[0x1e] Unsupported name : pmic | access[O] | 4byte_acur_read_success | 32768000
[0x1f] Unsupported name : pmic | access[O] | 4byte_acur_read_success | 32768000
[0x36] Unsupported name : pmic | access[O] | 4byte_acur_read_success | 24576000
[0x37] Unsupported name : pmic | access[O] | 4byte_acur_read_success | 40960000
[0x42] Unsupported name : pmic | access[O] | 4byte_acur_read_success | 24576000
[0x47] Unsupported name : pmic | access[O] | 4byte_acur_read_success | 32768000
[0xe ] Unsupported name : hsc | access[O] | 4byte_acur_read_success | 40566816
[0x29] Unsupported name : hsc | access[O] | 4byte_acur_read_success | 25755660
[0x30] Unsupported name : hsc | access[O] | 4byte_acur_read_success | 29687816
[0x39] Unsupported name : hsc | access[O] | 4byte_acur_read_success | 63504487
[0x91] Unsupported name : max16550a | access[O] | 4byte_acur_read_success | 25624588
[0x92] Unsupported name : max16550a | access[O] | 4byte_acur_read_success | 24707084
[0x93] Unsupported name : max16550a | access[O] | 4byte_acur_read_success | 7667712
[0x94] Unsupported name : max16550a | access[O] | 4byte_acur_read_success | 24969238
[0x95] Unsupported name : max16550a | access[O] | 4byte_acur_read_success | 12386305

Rainbow falls BIC
uart:~$ platform sensor list_all

[0x50] Unsupported name : tmp75 | access[O] | 4byte_acur_read_success | 29
[0x52] Unsupported name : tmp75 | access[O] | 4byte_acur_read_success | 30
[0x5f] Unsupported name : adc | access[O] | 4byte_acur_read_success | 7798789
[0x60] Unsupported name : adc | access[O] | 4byte_acur_read_success | 12648449
[0x61] Unsupported name : adc | access[O] | 4byte_acur_read_success | 52166657
[0x68] Unsupported name : adc | access[O] | 4byte_acur_read_success | 32571394
[0x69] Unsupported name : adc | access[O] | 4byte_acur_read_success | 32571394
[0x6a] Unsupported name : adc | access[O] | 4byte_acur_read_success | 39190528
[0x6b] Unsupported name : adc | access[O] | 4byte_acur_read_success | 39190528
[0x5d] Unsupported name : ina233 | access[O] | 4byte_acur_read_success | 34078732
[0x5e] Unsupported name : ina233 | access[O] | 4byte_acur_read_success | 21102595
[0x6c] Unsupported name : ina233 | access[O] | 4byte_acur_read_success | 17629184
[0x6d] Unsupported name : ina233 | access[O] | 4byte_acur_read_success | 9895936
[0x73] Unsupported name : ina233 | access[O] | 4byte_acur_read_success | 4915203
[0x74] Unsupported name : ina233 | access[O] | 4byte_acur_read_success | 32768000
[0x58] Unsupported name : isl69254 | access[O] | 4byte_acur_read_success | 39
[0x59] Unsupported name : isl69254 | access[O] | 4byte_acur_read_success | 36
[0x5a] Unsupported name : isl69254 | access[O] | 4byte_acur_read_success | 32
[0x5b] Unsupported name : isl69254 | access[O] | 4byte_acur_read_success | 36
[0x5c] Unsupported name : isl69254 | access[O] | 4byte_acur_read_success | 39
[0x62] Unsupported name : isl69254 | access[O] | 4byte_acur_read_success | 3014657
[0x64] Unsupported name : isl69254 | access[O] | 4byte_acur_read_success | 53673984
[0x65] Unsupported name : isl69254 | access[O] | 4byte_acur_read_success | 53673984
[0x66] Unsupported name : isl69254 | access[O] | 4byte_acur_read_success | 13041665
[0x67] Unsupported name : isl69254 | access[O] | 4byte_acur_read_success | 12976129
[0x6e] Unsupported name : isl69254 | access[O] | 4byte_acur_read_success | -6553600
[0x6f] Unsupported name : isl69254 | access[O] | 4byte_acur_read_success | 13107200
[0x70] Unsupported name : isl69254 | access[O] | 4byte_acur_read_success | 19660800
[0x71] Unsupported name : isl69254 | access[O] | 4byte_acur_read_success | -6553600
[0x72] Unsupported name : isl69254 | access[O] | 4byte_acur_read_success | -26214400
[0x75] Unsupported name : isl69254 | access[O] | 4byte_acur_read_success | 65534
[0x76] Unsupported name : isl69254 | access[O] | 4byte_acur_read_success | 0
[0x77] Unsupported name : isl69254 | access[O] | 4byte_acur_read_success | 0
[0x78] Unsupported name : isl69254 | access[O] | 4byte_acur_read_success | 65535
[0x79] Unsupported name : isl69254 | access[O] | 4byte_acur_read_success | 0
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 16, 2022
@facebook-github-bot

facebook-github-bot commented Jun 17, 2022

Copy link
Copy Markdown
Contributor

@GoldenBug has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
@LoraLin1 LoraLin1 force-pushed the fby3.5-Optimize_sensor_monitor_arch branch from 7ac491c to 6fa94b8 Compare June 21, 2022 00:24
@facebook-github-bot

facebook-github-bot commented Jun 21, 2022

Copy link
Copy Markdown
Contributor

@DelphineChiu has updated the pull request. You must reimport the pull request before landing.
@DelphineChiu DelphineChiu mentioned this pull request Jun 21, 2022
Closed
@facebook-github-bot

facebook-github-bot commented Jun 21, 2022

Copy link
Copy Markdown
Contributor

@GoldenBug has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
@LoraLin1
fby3.5: common:Improve sensor monitor
35de187 
Summary:
- Improve sensor monitor
  - Function sdr_init: the index used to store the SDR last id is represented by SDR count.
  - Function sdr_init: remove redundant debug messages.
  - Function get_sensor_config_index: remove unnecessary 'for' loop.
  - Function sensor_poll_handler: remove redundancy flag.
  - Function get_sensor_reading: update cache status in all cases.
  - Function sensor_polling_handler: sensor monitor check sensor number according to sensor config table.
  - Enum device_init_type: modify device type to increase sequentially.
  - Variable SDR_NUM: modify variable name to SDR_COUNT making name more readable.
  - Command platform: add sensor type/sensor status mapping table to get current sensor infomation in BIC console.

Test Plan:
- Build code: Pass
- Check sensor-util get sensor value is normal after optimizing sensor monitor architecture in different board: Pass
- Check sensor-util get sensor value is normal after AC/DC cycle 50 times: Pass

Test Board                                             Test result
------------------------------------------------------------------
Config A Craterlake BIC EVT2                           Pass
Config A Craterlake BIC EVT3_ADI                       Pass
Config A Craterlake BIC EVT3_MP5990                    Pass
Config B Craterlake BIC EVT2 + DPV2                    Pass
Config B Craterlake BIC EVT3_ADI + DPV2                Pass
Config B Craterlake BIC EVT3_MP5990 + DPV2             Pass
Config C Craterlake BIC EVT2 + Rainbow falls BIC       Pass
Config C Craterlake BIC EVT3_ADI + Rainbow falls BIC   Pass
COnfig D Craterlake BIC EVT2 + Baseboard BIC           Pass

Log:
[BMC console]

EVT2/EVT3 ADI/EVT3 MP5990
root@bmc-oob:~# sensor-util slot2 --threshold
slot2:
MB Inlet Temp                (0x1) :   33.00 C     | (ok) | UCR: 48.00 | UNC: NA | UNR: 150.00 | LCR: NA | LNC: NA | LNR: NA
MB Outlet Temp               (0x2) :   50.00 C     | (ok) | UCR: 93.00 | UNC: NA | UNR: 150.00 | LCR: NA | LNC: NA | LNR: NA
FIO Temp                     (0x3) :   31.00 C     | (ok) | UCR: 40.00 | UNC: NA | UNR: NA | LCR: NA | LNC: NA | LNR: NA
PCH Temp                     (0x4) :   47.00 C     | (ok) | UCR: 74.00 | UNC: NA | UNR: NA | LCR: NA | LNC: NA | LNR: NA
SOC CPU Temp                 (0x5) :   44.00 C     | (ok) | UCR: 84.00 | UNC: NA | UNR: NA | LCR: NA | LNC: NA | LNR: NA
SOC Therm Margin             (0x14) :  -56.00 C     | (ok) | UCR: NA | UNC: NA | UNR: 125.00 | LCR: NA | LNC: NA | LNR: NA
CPU TjMax                    (0x15) :  100.00 C     | (ok) | UCR: NA | UNC: NA | UNR: 125.00 | LCR: NA | LNC: NA | LNR: NA
DIMMA Temp                   (0x6) :   47.00 C     | (ok) | UCR: 85.00 | UNC: NA | UNR: NA | LCR: NA | LNC: NA | LNR: NA
DIMMC Temp                   (0x7) :   47.00 C     | (ok) | UCR: 85.00 | UNC: NA | UNR: NA | LCR: NA | LNC: NA | LNR: NA
DIMMD Temp                   (0x9) :   44.00 C     | (ok) | UCR: 85.00 | UNC: NA | UNR: NA | LCR: NA | LNC: NA | LNR: NA
DIMME Temp                   (0xA) :   46.00 C     | (ok) | UCR: 85.00 | UNC: NA | UNR: NA | LCR: NA | LNC: NA | LNR: NA
DIMMG Temp                   (0xB) :   42.00 C     | (ok) | UCR: 85.00 | UNC: NA | UNR: NA | LCR: NA | LNC: NA | LNR: NA
DIMMH Temp                   (0xC) :   39.00 C     | (ok) | UCR: 85.00 | UNC: NA | UNR: NA | LCR: NA | LNC: NA | LNR: NA
SSD0 Temp                    (0xD) :   35.00 C     | (ok) | UCR: 75.00 | UNC: NA | UNR: NA | LCR: NA | LNC: NA | LNR: NA
HSC Temp                     (0xE) :   46.67 C     | (ok) | UCR: 86.00 | UNC: NA | UNR: 125.00 | LCR: NA | LNC: NA | LNR: NA
VCCIN SPS Temp               (0xF) :   57.00 C     | (ok) | UCR: 100.00 | UNC: NA | UNR: 125.00 | LCR: NA | LNC: NA | LNR: NA
FIVRA SPS Temp               (0x10) :   54.00 C     | (ok) | UCR: 100.00 | UNC: NA | UNR: 125.00 | LCR: NA | LNC: NA | LNR: NA
EHV SPS Temp                 (0x11) :   46.00 C     | (ok) | UCR: 100.00 | UNC: NA | UNR: 125.00 | LCR: NA | LNC: NA | LNR: NA
VCCD SPS Temp                (0x12) :   43.00 C     | (ok) | UCR: 100.00 | UNC: NA | UNR: 125.00 | LCR: NA | LNC: NA | LNR: NA
FAON SPS Temp                (0x13) :   48.00 C     | (ok) | UCR: 100.00 | UNC: NA | UNR: 125.00 | LCR: NA | LNC: NA | LNR: NA
P12V_STBY Vol                (0x20) :   12.68 Volts | (ok) | UCR: 13.36 | UNC: 13.23 | UNR: 14.36 | LCR: 10.71 | LNC: 10.84 | LNR: 10.08
P3V_BAT Vol                  (0x21) :    3.13 Volts | (ok) | UCR: 3.51 | UNC: 3.46 | UNR: NA | LCR: 2.76 | LNC: 2.79 | LNR: NA
P3V3_STBY Vol                (0x22) :    3.34 Volts | (ok) | UCR: 3.56 | UNC: 3.53 | UNR: 4.00 | LCR: 3.04 | LNC: 3.08 | LNR: 2.30
P1V8_STBY Vol                (0x23) :    1.81 Volts | (ok) | UCR: 1.92 | UNC: 1.90 | UNR: 2.09 | LCR: 1.67 | LNC: 1.69 | LNR: 1.44
P1V05_PCH Vol                (0x24) :    1.06 Volts | (ok) | UCR: 1.12 | UNC: 1.10 | UNR: 1.22 | LCR: 0.97 | LNC: 0.98 | LNR: 0.84
P5V_STBY Vol                 (0x25) :    5.02 Volts | (ok) | UCR: 5.40 | UNC: 5.35 | UNR: 5.80 | LCR: 4.59 | LNC: 4.64 | LNR: 4.00
P12V_DIMM Vol                (0x26) :   12.73 Volts | (ok) | UCR: 14.21 | UNC: 14.07 | UNR: NA | LCR: 9.87 | LNC: 10.01 | LNR: NA
P1V2_STBY Vol                (0x27) :    1.20 Volts | (ok) | UCR: 1.30 | UNC: 1.28 | UNR: 1.39 | LCR: 1.10 | LNC: 1.12 | LNR: 0.96
P3V3_M2 Vol                  (0x28) :    3.33 Volts | (ok) | UCR: 3.71 | UNC: 3.67 | UNR: NA | LCR: 2.91 | LNC: 2.94 | LNR: NA
HSC Input Vol                (0x29) :   12.51 Volts | (ok) | UCR: 13.36 | UNC: 13.23 | UNR: 14.36 | LCR: 10.71 | LNC: 10.84 | LNR: 10.08
VCCIN VR Vol                 (0x2A) :    1.77 Volts | (ok) | UCR: 1.93 | UNC: 1.91 | UNR: 2.20 | LCR: 1.64 | LNC: 1.66 | LNR: 0.40
FIVRA VR Vol                 (0x2C) :    1.82 Volts | (ok) | UCR: 1.92 | UNC: 1.90 | UNR: 2.20 | LCR: 1.69 | LNC: 1.71 | LNR: 0.40
EHV VR Vol                   (0x2D) :    1.80 Volts | (ok) | UCR: 1.90 | UNC: 1.88 | UNR: 2.20 | LCR: 1.70 | LNC: 1.72 | LNR: 0.40
VCCD VR Vol                  (0x2E) :    1.14 Volts | (ok) | UCR: 1.23 | UNC: 1.21 | UNR: 1.50 | LCR: 1.05 | LNC: 1.06 | LNR: 0.40
FAON VR Vol                  (0x2F) :    1.05 Volts | (ok) | UCR: 1.09 | UNC: 1.07 | UNR: 1.40 | LCR: 0.90 | LNC: 0.91 | LNR: 0.40
HSC Output Cur               (0x30) :    6.10 Amps  | (ok) | UCR: 31.96 | UNC: 28.73 | UNR: 39.95 | LCR: NA | LNC: NA | LNR: NA
VCCIN VR Cur                 (0x31) :   14.50 Amps  | (ok) | UCR: 141.18 | UNC: 119.34 | UNR: 180.18 | LCR: NA | LNC: NA | LNR: NA
FIVRA VR Cur                 (0x32) :    3.60 Amps  | (ok) | UCR: 53.01 | UNC: 48.05 | UNR: 70.99 | LCR: NA | LNC: NA | LNR: NA
EHV VR Cur                   (0x33) :    0.80 Amps  | (ok) | UCR: 6.24 | UNC: 5.04 | UNR: 18.00 | LCR: NA | LNC: NA | LNR: NA
VCCD VR Cur                  (0x34) :    2.70 Amps  | (ok) | UCR: 30.02 | UNC: 26.98 | UNR: 42.94 | LCR: NA | LNC: NA | LNR: NA
FAON VR Cur                  (0x35) :    7.60 Amps  | (ok) | UCR: 46.02 | UNC: 42.12 | UNR: 60.06 | LCR: NA | LNC: NA | LNR: NA
CPU PWR                      (0x38) :   58.00 Watts | (ok) | UCR: NA | UNC: NA | UNR: NA | LCR: NA | LNC: NA | LNR: NA
HSC Input Pwr                (0x39) :   81.69 Watts | (ok) | UCR: 399.28 | UNC: 360.22 | UNR: 499.10 | LCR: NA | LNC: NA | LNR: NA
VCCIN VR Pout                (0x3A) :   23.00 Watts | (ok) | UCR: 253.80 | UNC: 214.32 | UNR: 324.30 | LCR: NA | LNC: NA | LNR: NA
FIVRA VR Pout                (0x3C) :    6.00 Watts | (ok) | UCR: 95.19 | UNC: 86.64 | UNR: 127.68 | LCR: NA | LNC: NA | LNR: NA
EHV VR Pout                  (0x3D) :    1.00 Watts | (ok) | UCR: 11.25 | UNC: 8.97 | UNR: 32.38 | LCR: NA | LNC: NA | LNR: NA
VCCD VR Pout                 (0x3E) :    2.00 Watts | (ok) | UCR: 34.32 | UNC: 31.02 | UNR: 49.28 | LCR: NA | LNC: NA | LNR: NA
FAON VR Pout                 (0x3F) :    7.00 Watts | (ok) | UCR: 49.28 | UNC: 45.08 | UNR: 64.12 | LCR: NA | LNC: NA | LNR: NA
DIMMA PMIC_Pout              (0x1E) :    0.38 Watts | (ok) | UCR: 32.20 | UNC: 31.50 | UNR: NA | LCR: NA | LNC: NA | LNR: NA
DIMMC PMIC_Pout              (0x1F) :    0.62 Watts | (ok) | UCR: 32.20 | UNC: 31.50 | UNR: NA | LCR: NA | LNC: NA | LNR: NA
DIMMD PMIC_Pout              (0x36) :    0.50 Watts | (ok) | UCR: 32.20 | UNC: 31.50 | UNR: NA | LCR: NA | LNC: NA | LNR: NA
DIMME PMIC_Pout              (0x37) :    0.62 Watts | (ok) | UCR: 32.20 | UNC: 31.50 | UNR: NA | LCR: NA | LNC: NA | LNR: NA
DIMMG PMIC_Pout              (0x42) :    0.50 Watts | (ok) | UCR: 32.20 | UNC: 31.50 | UNR: NA | LCR: NA | LNC: NA | LNR: NA
DIMMH PMIC_Pout              (0x47) :    0.75 Watts | (ok) | UCR: 32.20 | UNC: 31.50 | UNR: NA | LCR: NA | LNC: NA | LNR: NA

Baseboard BIC
root@bmc-oob:~# sensor-util slot1 --threshold | grep BB
BB_INLET_TEMP                (0xD1) :   23.76 C     | (ok) | UCR: 50.00 | UNC: NA | UNR: 150.00 | LCR: NA | LNC: NA | LNR: NA
BB_OUTLET_TEMP               (0xD2) :   25.76 C     | (ok) | UCR: 55.00 | UNC: NA | UNR: 150.00 | LCR: NA | LNC: NA | LNR: NA
BB_HSC_TEMP                  (0xD3) :   22.14 C     | (ok) | UCR: 55.00 | UNC: NA | UNR: 125.00 | LCR: NA | LNC: NA | LNR: NA
BB_P5V_STBY                  (0xD4) :    5.14 Volts | (ok) | UCR: 5.55 | UNC: 5.50 | UNR: 5.65 | LCR: 4.45 | LNC: 4.50 | LNR: 4.15
BB_P12V_STBY                 (0xD5) :   12.71 Volts | (ok) | UCR: 13.29 | UNC: 13.17 | UNR: 14.30 | LCR: 10.71 | LNC: 10.77 | LNR: 10.08
BB_P3V3_STBY                 (0xD6) :    3.36 Volts | (ok) | UCR: 3.57 | UNC: 3.54 | UNR: 3.73 | LCR: 3.04 | LNC: 3.07 | LNR: 2.74
BB_P5V_USB                   (0xE9) :    5.14 Volts | (ok) | UCR: 5.40 | UNC: 5.35 | UNR: 5.65 | LCR: 4.60 | LNC: 4.65 | LNR: 4.15
BB_P1V2_STBY                 (0xD9) :    1.21 Volts | (ok) | UCR: 1.30 | UNC: 1.28 | UNR: 1.36 | LCR: 1.10 | LNC: 1.12 | LNR: 1.00
BB_P1V0_STBY                 (0xDA) :    1.01 Volts | (ok) | UCR: 1.08 | UNC: 1.07 | UNR: 1.13 | LCR: 0.92 | LNC: 0.93 | LNR: 0.83
BB_MEDUSA_VIN                (0xDB) :   12.55 Volts | (ok) | UCR: 13.88 | UNC: 13.75 | UNR: 14.00 | LCR: 11.12 | LNC: 11.25 | LNR: 9.25
BB_MEDUSA_VOUT               (0xD7) :   12.55 Volts | (ok) | UCR: 13.88 | UNC: 13.75 | UNR: 14.00 | LCR: 11.12 | LNC: 11.25 | LNR: 9.25
BB_HSC_VIN                   (0xDC) :   12.52 Volts | (ok) | UCR: 13.29 | UNC: 13.17 | UNR: 14.30 | LCR: 10.71 | LNC: 10.77 | LNR: 10.08
BB_MEDUSA_CUR                (0xDF) :   13.18 Amps  | (ok) | UCR: 144.00 | UNC: NA | UNR: NA | LCR: NA | LNC: NA | LNR: NA
BB_HSC_IOUT                  (0xDE) :    5.97 Amps  | (ok) | UCR: 22.96 | UNC: NA | UNR: 31.92 | LCR: NA | LNC: NA | LNR: NA
BB_FAN_IOUT                  (0xE8) :    2.69 Amps  | (ok) | UCR: 14.56 | UNC: NA | UNR: 39.26 | LCR: NA | LNC: NA | LNR: NA
BB_MEDUSA_PWR                (0xD8) :  165.45 Watts | (ok) | UCR: 1800.00 | UNC: NA | UNR: NA | LCR: NA | LNC: NA | LNR: NA
BB_HSC_PIN                   (0xDD) :   74.34 Watts | (ok) | UCR: 287.10 | UNC: NA | UNR: 398.46 | LCR: NA | LNC: NA | LNR: NA
BB_HSC_EIN                   (0xEA) :   72.65 Watts | (ok) | UCR: NA | UNC: NA | UNR: NA | LCR: NA | LNC: NA | LNR: NA
BB_HSC_PEAK_IOUT             (0xEB) :   15.23 Amps  | (ok) | UCR: NA | UNC: NA | UNR: NA | LCR: NA | LNC: NA | LNR: NA
BB_HSC_PEAK_PIN              (0xEC) :  190.76 Watts | (ok) | UCR: NA | UNC: NA | UNR: NA | LCR: NA | LNC: NA | LNR: NA

DPV2
root@bmc-oob:~# sensor-util slot1 --threshold | grep DPV2
DPV2_1_12V_VIN               (0x8C) :   12.40 Volts | (ok) | UCR: 13.20 | UNC: 12.96 | UNR: 14.00 | LCR: 10.80 | LNC: 11.04 | LNR: 10.00
DPV2_1_12V_VOUT              (0x8D) :   12.42 Volts | (ok) | UCR: 13.20 | UNC: 12.96 | UNR: 14.00 | LCR: 10.80 | LNC: 11.04 | LNR: 10.00
DPV2_1_12V_IOUT              (0x8E) :    0.14 Amps  | (ok) | UCR: 15.47 | UNC: 15.17 | UNR: 18.90 | LCR: NA | LNC: NA | LNR: NA
DPV2_1_EFUSETemp             (0x8F) :   22.38 C     | (ok) | UCR: 100.00 | UNC: NA | UNR: 150.00 | LCR: NA | LNC: NA | LNR: NA
DPV2_1_EFUSEPWR              (0x90) :    1.19 Watts | (ok) | UCR: 186.00 | UNC: NA | UNR: 226.80 | LCR: NA | LNC: NA | LNR: NA

[BIC console]

EVT3 ADI
uart:~$ platform sensor list_all
---------------------------------------------------------------------------------
[0x1 ] Unsupported name                   : tmp75      | access[O] | 4byte_acur_read_success        | 31
[0x2 ] Unsupported name                   : tmp431     | access[O] | 4byte_acur_read_success        | 24576048
[0x3 ] Unsupported name                   : tmp75      | access[O] | 4byte_acur_read_success        | 29
[0xd ] Unsupported name                   : nvme       | access[O] | 4byte_acur_read_success        | 32
[0x5 ] Unsupported name                   : peci       | access[O] | 4byte_acur_read_success        | 41
[0x14] Unsupported name                   : peci       | access[O] | 4byte_acur_read_success        | 59
[0x15] Unsupported name                   : peci       | access[O] | 4byte_acur_read_success        | 100
[0x6 ] Unsupported name                   : peci       | access[O] | 4byte_acur_read_success        | 45
[0x7 ] Unsupported name                   : peci       | access[O] | 4byte_acur_read_success        | 45
[0x9 ] Unsupported name                   : peci       | access[O] | 4byte_acur_read_success        | 43
[0xa ] Unsupported name                   : peci       | access[O] | 4byte_acur_read_success        | 44
[0xb ] Unsupported name                   : peci       | access[O] | 4byte_acur_read_success        | 42
[0xc ] Unsupported name                   : peci       | access[O] | 4byte_acur_read_success        | 38
[0x38] Unsupported name                   : peci       | access[O] | 4byte_acur_read_success        | 56
[0x20] Unsupported name                   : adc        | access[O] | 4byte_acur_read_success        | 34865164
[0x22] Unsupported name                   : adc        | access[O] | 4byte_acur_read_success        | 20578307
[0x24] Unsupported name                   : adc        | access[O] | 4byte_acur_read_success        | 3080193
[0x21] Unsupported name                   : adc        | access[O] | 4byte_acur_read_success        | 5898243
[0x25] Unsupported name                   : adc        | access[O] | 4byte_acur_read_success        | 1507333
[0x26] Unsupported name                   : adc        | access[O] | 4byte_acur_read_success        | 41418764
[0x27] Unsupported name                   : adc        | access[O] | 4byte_acur_read_success        | 13172737
[0x28] Unsupported name                   : adc        | access[O] | 4byte_acur_read_success        | 19922947
[0x23] Unsupported name                   : adc        | access[O] | 4byte_acur_read_success        | 52822017
[0x2e] Unsupported name                   : isl69259   | access[O] | 4byte_acur_read_success        | 9306113
[0x2f] Unsupported name                   : isl69259   | access[O] | 4byte_acur_read_success        | 3473409
[0x2d] Unsupported name                   : isl69259   | access[O] | 4byte_acur_read_success        | 52428801
[0x2a] Unsupported name                   : isl69259   | access[O] | 4byte_acur_read_success        | 40435713
[0x2c] Unsupported name                   : isl69259   | access[O] | 4byte_acur_read_success        | 53608449
[0x34] Unsupported name                   : isl69259   | access[O] | 4byte_acur_read_success        | 52428802
[0x35] Unsupported name                   : isl69259   | access[O] | 4byte_acur_read_success        | 19660807
[0x33] Unsupported name                   : isl69259   | access[O] | 4byte_acur_read_success        | 52428800
[0x31] Unsupported name                   : isl69259   | access[O] | 4byte_acur_read_success        | 26214414
[0x32] Unsupported name                   : isl69259   | access[O] | 4byte_acur_read_success        | 4
[0x12] Unsupported name                   : isl69259   | access[O] | 4byte_acur_read_success        | 43
[0x13] Unsupported name                   : isl69259   | access[O] | 4byte_acur_read_success        | 47
[0x11] Unsupported name                   : isl69259   | access[O] | 4byte_acur_read_success        | 43
[0xf ] Unsupported name                   : isl69259   | access[O] | 4byte_acur_read_success        | 55
[0x10] Unsupported name                   : isl69259   | access[O] | 4byte_acur_read_success        | 52
[0x3e] Unsupported name                   : isl69259   | access[O] | 4byte_acur_read_success        | 2
[0x3f] Unsupported name                   : isl69259   | access[O] | 4byte_acur_read_success        | 8
[0x3d] Unsupported name                   : isl69259   | access[O] | 4byte_acur_read_success        | 1
[0x3a] Unsupported name                   : isl69259   | access[O] | 4byte_acur_read_success        | 33
[0x3c] Unsupported name                   : isl69259   | access[O] | 4byte_acur_read_success        | 6
[0x4 ] Unsupported name                   : pch        | access[O] | 4byte_acur_read_success        | 48
[0x1e] Unsupported name                   : pmic       | access[O] | 4byte_acur_read_success        | 49152000
[0x1f] Unsupported name                   : pmic       | access[O] | 4byte_acur_read_success        | 32768000
[0x36] Unsupported name                   : pmic       | access[O] | 4byte_acur_read_success        | 49152000
[0x37] Unsupported name                   : pmic       | access[O] | 4byte_acur_read_success        | 40960000
[0x42] Unsupported name                   : pmic       | access[O] | 4byte_acur_read_success        | 32768000
[0x47] Unsupported name                   : pmic       | access[O] | 4byte_acur_read_success        | 32768000
[0xe ] Unsupported name                   : tmp431     | access[O] | 4byte_acur_read_success        | 24576045
[0x29] Unsupported name                   : hsc        | access[O] | 4byte_acur_read_success        | 34144268
[0x30] Unsupported name                   : hsc        | access[O] | 4byte_acur_read_success        | 1572869
[0x39] Unsupported name                   : hsc        | access[O] | 4byte_acur_read_success        | 21692477
---------------------------------------------------------------------------------

EVT3 MP5990
uart:~$ platform sensor list_all
---------------------------------------------------------------------------------
[0x1 ] Unsupported name                   : tmp75      | access[O] | 4byte_acur_read_success        | 26
[0x2 ] Unsupported name                   : tmp75      | access[O] | 4byte_acur_read_success        | 30
[0x3 ] Unsupported name                   : tmp75      | access[O] | 4byte_acur_read_success        | 27
[0xd ] Unsupported name                   : nvme       | access[O] | 4byte_acur_read_success        | 23
[0x5 ] Unsupported name                   : peci       | access[O] | 4byte_acur_read_success        | 31
[0x14] Unsupported name                   : peci       | access[O] | 4byte_acur_read_success        | 69
[0x15] Unsupported name                   : peci       | access[O] | 4byte_acur_read_success        | 100
[0x6 ] Unsupported name                   : peci       | access[O] | 4byte_acur_read_success        | 27
[0x7 ] Unsupported name                   : peci       | access[O] | 4byte_acur_read_success        | 27
[0x9 ] Unsupported name                   : peci       | access[O] | 4byte_acur_read_success        | 26
[0xa ] Unsupported name                   : peci       | access[O] | 4byte_acur_read_success        | 27
[0xb ] Unsupported name                   : peci       | access[O] | 4byte_acur_read_success        | 26
[0xc ] Unsupported name                   : peci       | access[O] | 4byte_acur_read_success        | 27
[0x38] Unsupported name                   : peci       | access[O] | 4byte_acur_read_success        | 74
[0x20] Unsupported name                   : adc        | access[O] | 4byte_acur_read_success        | 34865164
[0x22] Unsupported name                   : adc        | access[O] | 4byte_acur_read_success        | 21889027
[0x24] Unsupported name                   : adc        | access[O] | 4byte_acur_read_success        | 3538945
[0x21] Unsupported name                   : adc        | access[O] | 4byte_acur_read_success        | 2949123
[0x25] Unsupported name                   : adc        | access[O] | 4byte_acur_read_success        | 61407236
[0x26] Unsupported name                   : adc        | access[O] | 4byte_acur_read_success        | 25296908
[0x27] Unsupported name                   : adc        | access[O] | 4byte_acur_read_success        | 12320769
[0x28] Unsupported name                   : adc        | access[O] | 4byte_acur_read_success        | 19922947
[0x23] Unsupported name                   : adc        | access[O] | 4byte_acur_read_success        | 51707905
[0x2e] Unsupported name                   : isl69259   | access[O] | 4byte_acur_read_success        | 9371649
[0x2f] Unsupported name                   : isl69259   | access[O] | 4byte_acur_read_success        | 3276801
[0x2d] Unsupported name                   : isl69259   | access[O] | 4byte_acur_read_success        | 52428801
[0x2a] Unsupported name                   : isl69259   | access[O] | 4byte_acur_read_success        | 50593793
[0x2c] Unsupported name                   : isl69259   | access[O] | 4byte_acur_read_success        | 53608449
[0x34] Unsupported name                   : isl69259   | access[O] | 4byte_acur_read_success        | 52428802
[0x35] Unsupported name                   : isl69259   | access[O] | 4byte_acur_read_success        | 58982408
[0x33] Unsupported name                   : isl69259   | access[O] | 4byte_acur_read_success        | 52428800
[0x31] Unsupported name                   : isl69259   | access[O] | 4byte_acur_read_success        | 6553632
[0x32] Unsupported name                   : isl69259   | access[O] | 4byte_acur_read_success        | 45875203
[0x12] Unsupported name                   : isl69259   | access[O] | 4byte_acur_read_success        | 33
[0x13] Unsupported name                   : isl69259   | access[O] | 4byte_acur_read_success        | 37
[0x11] Unsupported name                   : isl69259   | access[O] | 4byte_acur_read_success        | 32
[0xf ] Unsupported name                   : isl69259   | access[O] | 4byte_acur_read_success        | 39
[0x10] Unsupported name                   : isl69259   | access[O] | 4byte_acur_read_success        | 36
[0x3e] Unsupported name                   : isl69259   | access[O] | 4byte_acur_read_success        | 2
[0x3f] Unsupported name                   : isl69259   | access[O] | 4byte_acur_read_success        | 9
[0x3d] Unsupported name                   : isl69259   | access[O] | 4byte_acur_read_success        | 1
[0x3a] Unsupported name                   : isl69259   | access[O] | 4byte_acur_read_success        | 56
[0x3c] Unsupported name                   : isl69259   | access[O] | 4byte_acur_read_success        | 7
[0x4 ] Unsupported name                   : pch        | access[O] | 4byte_acur_read_success        | 36
[0x1e] Unsupported name                   : pmic       | access[O] | 4byte_acur_read_success        | 32768000
[0x1f] Unsupported name                   : pmic       | access[O] | 4byte_acur_read_success        | 32768000
[0x36] Unsupported name                   : pmic       | access[O] | 4byte_acur_read_success        | 24576000
[0x37] Unsupported name                   : pmic       | access[O] | 4byte_acur_read_success        | 40960000
[0x42] Unsupported name                   : pmic       | access[O] | 4byte_acur_read_success        | 24576000
[0x47] Unsupported name                   : pmic       | access[O] | 4byte_acur_read_success        | 32768000
[0xe ] Unsupported name                   : mp5990     | access[O] | 4byte_acur_read_success        | 31
[0x29] Unsupported name                   : mp5990     | access[O] | 4byte_acur_read_success        | 26607628
[0x30] Unsupported name                   : mp5990     | access[O] | 4byte_acur_read_success        | 32768007
[0x39] Unsupported name                   : mp5990     | access[O] | 4byte_acur_read_success        | 93

EVT2 + DPV2
uart:~$ platform sensor list_all
---------------------------------------------------------------------------------
[0x1 ] Unsupported name                   : tmp75      | access[O] | 4byte_acur_read_success        | 26
[0x2 ] Unsupported name                   : tmp75      | access[O] | 4byte_acur_read_success        | 36
[0x3 ] Unsupported name                   : tmp75      | access[O] | 4byte_acur_read_success        | 25
[0xd ] Unsupported name                   : nvme       | access[O] | 4byte_acur_read_success        | 30
[0x5 ] Unsupported name                   : peci       | access[O] | 4byte_acur_read_success        | 34
[0x14] Unsupported name                   : peci       | access[O] | 4byte_acur_read_success        | 66
[0x15] Unsupported name                   : peci       | access[O] | 4byte_acur_read_success        | 100
[0x6 ] Unsupported name                   : peci       | access[O] | 4byte_acur_read_success        | 29
[0x7 ] Unsupported name                   : peci       | access[O] | 4byte_acur_read_success        | 28
[0x9 ] Unsupported name                   : peci       | access[O] | 4byte_acur_read_success        | 28
[0xa ] Unsupported name                   : peci       | access[O] | 4byte_acur_read_success        | 29
[0xb ] Unsupported name                   : peci       | access[O] | 4byte_acur_read_success        | 29
[0xc ] Unsupported name                   : peci       | access[O] | 4byte_acur_read_success        | 29
[0x38] Unsupported name                   : peci       | access[O] | 4byte_acur_read_success        | 79
[0x20] Unsupported name                   : adc        | access[O] | 4byte_acur_read_success        | 34865164
[0x22] Unsupported name                   : adc        | access[O] | 4byte_acur_read_success        | 21626883
[0x24] Unsupported name                   : adc        | access[O] | 4byte_acur_read_success        | 3211265
[0x21] Unsupported name                   : adc        | access[O] | 4byte_acur_read_success        | 6291459
[0x25] Unsupported name                   : adc        | access[O] | 4byte_acur_read_success        | 63045636
[0x26] Unsupported name                   : adc        | access[O] | 4byte_acur_read_success        | 31850508
[0x27] Unsupported name                   : adc        | access[O] | 4byte_acur_read_success        | 12648449
[0x28] Unsupported name                   : adc        | access[O] | 4byte_acur_read_success        | 20578307
[0x23] Unsupported name                   : adc        | access[O] | 4byte_acur_read_success        | 52494337
[0x2e] Unsupported name                   : isl69259   | access[O] | 4byte_acur_read_success        | 9306113
[0x2f] Unsupported name                   : isl69259   | access[O] | 4byte_acur_read_success        | 3211265
[0x2d] Unsupported name                   : isl69259   | access[O] | 4byte_acur_read_success        | 52428801
[0x2a] Unsupported name                   : isl69259   | access[O] | 4byte_acur_read_success        | 50397185
[0x2c] Unsupported name                   : isl69259   | access[O] | 4byte_acur_read_success        | 53608449
[0x34] Unsupported name                   : isl69259   | access[O] | 4byte_acur_read_success        | 52428802
[0x35] Unsupported name                   : isl69259   | access[O] | 4byte_acur_read_success        | 6553609
[0x33] Unsupported name                   : isl69259   | access[O] | 4byte_acur_read_success        | 58982400
[0x31] Unsupported name                   : isl69259   | access[O] | 4byte_acur_read_success        | 6553634
[0x32] Unsupported name                   : isl69259   | access[O] | 4byte_acur_read_success        | 6553604
[0x12] Unsupported name                   : isl69259   | access[O] | 4byte_acur_read_success        | 35
[0x13] Unsupported name                   : isl69259   | access[O] | 4byte_acur_read_success        | 38
[0x11] Unsupported name                   : isl69259   | access[O] | 4byte_acur_read_success        | 34
[0xf ] Unsupported name                   : isl69259   | access[O] | 4byte_acur_read_success        | 46
[0x10] Unsupported name                   : isl69259   | access[O] | 4byte_acur_read_success        | 40
[0x3e] Unsupported name                   : isl69259   | access[O] | 4byte_acur_read_success        | 2
[0x3f] Unsupported name                   : isl69259   | access[O] | 4byte_acur_read_success        | 9
[0x3d] Unsupported name                   : isl69259   | access[O] | 4byte_acur_read_success        | 1
[0x3a] Unsupported name                   : isl69259   | access[O] | 4byte_acur_read_success        | 60
[0x3c] Unsupported name                   : isl69259   | access[O] | 4byte_acur_read_success        | 6
[0x4 ] Unsupported name                   : pch        | access[O] | 4byte_acur_read_success        | 36
[0x1e] Unsupported name                   : pmic       | access[O] | 4byte_acur_read_success        | 32768000
[0x1f] Unsupported name                   : pmic       | access[O] | 4byte_acur_read_success        | 32768000
[0x36] Unsupported name                   : pmic       | access[O] | 4byte_acur_read_success        | 24576000
[0x37] Unsupported name                   : pmic       | access[O] | 4byte_acur_read_success        | 40960000
[0x42] Unsupported name                   : pmic       | access[O] | 4byte_acur_read_success        | 24576000
[0x47] Unsupported name                   : pmic       | access[O] | 4byte_acur_read_success        | 32768000
[0xe ] Unsupported name                   : hsc        | access[O] | 4byte_acur_read_success        | 40566816
[0x29] Unsupported name                   : hsc        | access[O] | 4byte_acur_read_success        | 25755660
[0x30] Unsupported name                   : hsc        | access[O] | 4byte_acur_read_success        | 29687816
[0x39] Unsupported name                   : hsc        | access[O] | 4byte_acur_read_success        | 63504487
[0x91] Unsupported name                   : max16550a  | access[O] | 4byte_acur_read_success        | 25624588
[0x92] Unsupported name                   : max16550a  | access[O] | 4byte_acur_read_success        | 24707084
[0x93] Unsupported name                   : max16550a  | access[O] | 4byte_acur_read_success        | 7667712
[0x94] Unsupported name                   : max16550a  | access[O] | 4byte_acur_read_success        | 24969238
[0x95] Unsupported name                   : max16550a  | access[O] | 4byte_acur_read_success        | 12386305
---------------------------------------------------------------------------------

Rainbow falls BIC
uart:~$ platform sensor list_all
---------------------------------------------------------------------------------
[0x50] Unsupported name                   : tmp75      | access[O] | 4byte_acur_read_success        | 29
[0x52] Unsupported name                   : tmp75      | access[O] | 4byte_acur_read_success        | 30
[0x5f] Unsupported name                   : adc        | access[O] | 4byte_acur_read_success        | 7798789
[0x60] Unsupported name                   : adc        | access[O] | 4byte_acur_read_success        | 12648449
[0x61] Unsupported name                   : adc        | access[O] | 4byte_acur_read_success        | 52166657
[0x68] Unsupported name                   : adc        | access[O] | 4byte_acur_read_success        | 32571394
[0x69] Unsupported name                   : adc        | access[O] | 4byte_acur_read_success        | 32571394
[0x6a] Unsupported name                   : adc        | access[O] | 4byte_acur_read_success        | 39190528
[0x6b] Unsupported name                   : adc        | access[O] | 4byte_acur_read_success        | 39190528
[0x5d] Unsupported name                   : ina233     | access[O] | 4byte_acur_read_success        | 34078732
[0x5e] Unsupported name                   : ina233     | access[O] | 4byte_acur_read_success        | 21102595
[0x6c] Unsupported name                   : ina233     | access[O] | 4byte_acur_read_success        | 17629184
[0x6d] Unsupported name                   : ina233     | access[O] | 4byte_acur_read_success        | 9895936
[0x73] Unsupported name                   : ina233     | access[O] | 4byte_acur_read_success        | 4915203
[0x74] Unsupported name                   : ina233     | access[O] | 4byte_acur_read_success        | 32768000
[0x58] Unsupported name                   : isl69254   | access[O] | 4byte_acur_read_success        | 39
[0x59] Unsupported name                   : isl69254   | access[O] | 4byte_acur_read_success        | 36
[0x5a] Unsupported name                   : isl69254   | access[O] | 4byte_acur_read_success        | 32
[0x5b] Unsupported name                   : isl69254   | access[O] | 4byte_acur_read_success        | 36
[0x5c] Unsupported name                   : isl69254   | access[O] | 4byte_acur_read_success        | 39
[0x62] Unsupported name                   : isl69254   | access[O] | 4byte_acur_read_success        | 3014657
[0x64] Unsupported name                   : isl69254   | access[O] | 4byte_acur_read_success        | 53673984
[0x65] Unsupported name                   : isl69254   | access[O] | 4byte_acur_read_success        | 53673984
[0x66] Unsupported name                   : isl69254   | access[O] | 4byte_acur_read_success        | 13041665
[0x67] Unsupported name                   : isl69254   | access[O] | 4byte_acur_read_success        | 12976129
[0x6e] Unsupported name                   : isl69254   | access[O] | 4byte_acur_read_success        | -6553600
[0x6f] Unsupported name                   : isl69254   | access[O] | 4byte_acur_read_success        | 13107200
[0x70] Unsupported name                   : isl69254   | access[O] | 4byte_acur_read_success        | 19660800
[0x71] Unsupported name                   : isl69254   | access[O] | 4byte_acur_read_success        | -6553600
[0x72] Unsupported name                   : isl69254   | access[O] | 4byte_acur_read_success        | -26214400
[0x75] Unsupported name                   : isl69254   | access[O] | 4byte_acur_read_success        | 65534
[0x76] Unsupported name                   : isl69254   | access[O] | 4byte_acur_read_success        | 0
[0x77] Unsupported name                   : isl69254   | access[O] | 4byte_acur_read_success        | 0
[0x78] Unsupported name                   : isl69254   | access[O] | 4byte_acur_read_success        | 65535
[0x79] Unsupported name                   : isl69254   | access[O] | 4byte_acur_read_success        | 0
---------------------------------------------------------------------------------
@LoraLin1 LoraLin1 force-pushed the fby3.5-Optimize_sensor_monitor_arch branch from 6fa94b8 to 35de187 Compare June 22, 2022 00:35
@facebook-github-bot

facebook-github-bot commented Jun 22, 2022

Copy link
Copy Markdown
Contributor

@DelphineChiu has updated the pull request. You must reimport the pull request before landing.
@LoraLin1

LoraLin1 commented Jun 22, 2022

Copy link
Copy Markdown
Collaborator

Hi @GoldenBug
We have fixed the conflict and do the forced update.
Please review it. Thanks.
@facebook-github-bot

facebook-github-bot commented Jun 22, 2022

Copy link
Copy Markdown
Contributor

@GoldenBug has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
facebook-github-bot pushed a commit that referenced this pull request Jun 23, 2022
@LoraLin1 @facebook-github-bot
fby3.5: common:Fix sensor monitor memcpy fail causing BIC crash issue (…
8e223c3 
…#349)

Summary:
- Fix sensor monitor memcpy fail causing BIC crash issue
  - Check SDR/sensor config table size before memcpy SDR/sensor config from platform to common.
    If SDR size not equal to sensor config size, BIC would not allocate SDR/sensor config table and monitor sensor.
- Improve sensor monitor
  - Array Config D BB BIC full_sdr_table: remove redundancy SDR.
  - Array full_sdr_table: allocate memory size according to different cards present.
  - Function add_full_sdr_table: check SDR table size before adding SDR.
  - Function add_sensor_config: check config table size before adding sensor config.
  - Function get_sensor_reading: check sensor information in sensor config table.
  - Variable sensor_config_num: modify variable name to sensor_config_count making name more readable.
  - Command platform: fix BIC crash when sensor list_all command fail to map sensor information.

Dependency: #339

Pull Request resolved: #349

Test Plan:
- Build code: Pass
- Check BIC status in error case with Config A/B/C/D: Pass
- Check sensor monitor in error case with Config A/B/C/D: Pass

error case                                            error handling
--------------------------------------------------------------------------------------------------------------------------------------------
SDR table size is not equal to config table size      Do not allocate memory to SDR/sensor config table, and BIC would not monitor sensor.
sensor monitor number doesn't match with SDR table    Print "[sensor_poll_handler] fail to find sensor SDR info, sensor number: 0xXX" and sensor would monitor this sensor,
                                                      if config table sensor number is not found in SDR table.
                                                      Print "[get_sensor_reading] fail to find sensor info in config table, sensor_num: 0xXX" and sensor would show NA on sensor-util,
                                                      if sdr table sensor number is not found in config table.
Log:
[normal case]

[BMC console]
root@bmc-oob:~# sensor-util slot2 --threshold
slot2:
MB Inlet Temp                (0x1) :   32.00 C     | (ok) | UCR: 48.00 | UNC: NA | UNR: 150.00 | LCR: NA | LNC: NA | LNR: NA
MB Outlet Temp               (0x2) :   49.00 C     | (ok) | UCR: 93.00 | UNC: NA | UNR: 150.00 | LCR: NA | LNC: NA | LNR: NA
FIO Temp                     (0x3) :   29.00 C     | (ok) | UCR: 40.00 | UNC: NA | UNR: NA | LCR: NA | LNC: NA | LNR: NA
PCH Temp                     (0x4) :   45.00 C     | (ok) | UCR: 74.00 | UNC: NA | UNR: NA | LCR: NA | LNC: NA | LNR: NA
SOC CPU Temp                 (0x5) :   44.00 C     | (ok) | UCR: 84.00 | UNC: NA | UNR: NA | LCR: NA | LNC: NA | LNR: NA
SOC Therm Margin             (0x14) :  -56.00 C     | (ok) | UCR: NA | UNC: NA | UNR: 125.00 | LCR: NA | LNC: NA | LNR: NA
CPU TjMax                    (0x15) :  100.00 C     | (ok) | UCR: NA | UNC: NA | UNR: 125.00 | LCR: NA | LNC: NA | LNR: NA
DIMMA Temp                   (0x6) :   46.00 C     | (ok) | UCR: 85.00 | UNC: NA | UNR: NA | LCR: NA | LNC: NA | LNR: NA
DIMMC Temp                   (0x7) :   46.00 C     | (ok) | UCR: 85.00 | UNC: NA | UNR: NA | LCR: NA | LNC: NA | LNR: NA
DIMMD Temp                   (0x9) :   43.00 C     | (ok) | UCR: 85.00 | UNC: NA | UNR: NA | LCR: NA | LNC: NA | LNR: NA
DIMME Temp                   (0xA) :   45.00 C     | (ok) | UCR: 85.00 | UNC: NA | UNR: NA | LCR: NA | LNC: NA | LNR: NA
DIMMG Temp                   (0xB) :   42.00 C     | (ok) | UCR: 85.00 | UNC: NA | UNR: NA | LCR: NA | LNC: NA | LNR: NA
DIMMH Temp                   (0xC) :   38.00 C     | (ok) | UCR: 85.00 | UNC: NA | UNR: NA | LCR: NA | LNC: NA | LNR: NA
SSD0 Temp                    (0xD) :   34.00 C     | (ok) | UCR: 75.00 | UNC: NA | UNR: NA | LCR: NA | LNC: NA | LNR: NA
HSC Temp                     (0xE) :   45.95 C     | (ok) | UCR: 86.00 | UNC: NA | UNR: 125.00 | LCR: NA | LNC: NA | LNR: NA
VCCIN SPS Temp               (0xF) :   57.00 C     | (ok) | UCR: 100.00 | UNC: NA | UNR: 125.00 | LCR: NA | LNC: NA | LNR: NA
FIVRA SPS Temp               (0x10) :   54.00 C     | (ok) | UCR: 100.00 | UNC: NA | UNR: 125.00 | LCR: NA | LNC: NA | LNR: NA
EHV SPS Temp                 (0x11) :   45.00 C     | (ok) | UCR: 100.00 | UNC: NA | UNR: 125.00 | LCR: NA | LNC: NA | LNR: NA
VCCD SPS Temp                (0x12) :   43.00 C     | (ok) | UCR: 100.00 | UNC: NA | UNR: 125.00 | LCR: NA | LNC: NA | LNR: NA
FAON SPS Temp                (0x13) :   47.00 C     | (ok) | UCR: 100.00 | UNC: NA | UNR: 125.00 | LCR: NA | LNC: NA | LNR: NA
P12V_STBY Vol                (0x20) :   12.68 Volts | (ok) | UCR: 13.36 | UNC: 13.23 | UNR: 14.36 | LCR: 10.71 | LNC: 10.84 | LNR: 10.08
P3V_BAT Vol                  (0x21) :    3.13 Volts | (ok) | UCR: 3.51 | UNC: 3.46 | UNR: NA | LCR: 2.76 | LNC: 2.79 | LNR: NA
P3V3_STBY Vol                (0x22) :    3.34 Volts | (ok) | UCR: 3.56 | UNC: 3.53 | UNR: 4.00 | LCR: 3.04 | LNC: 3.08 | LNR: 2.30
P1V8_STBY Vol                (0x23) :    1.81 Volts | (ok) | UCR: 1.92 | UNC: 1.90 | UNR: 2.09 | LCR: 1.67 | LNC: 1.69 | LNR: 1.44
P1V05_PCH Vol                (0x24) :    1.06 Volts | (ok) | UCR: 1.12 | UNC: 1.10 | UNR: 1.22 | LCR: 0.97 | LNC: 0.98 | LNR: 0.84
P5V_STBY Vol                 (0x25) :    5.02 Volts | (ok) | UCR: 5.40 | UNC: 5.35 | UNR: 5.80 | LCR: 4.59 | LNC: 4.64 | LNR: 4.00
P12V_DIMM Vol                (0x26) :   12.73 Volts | (ok) | UCR: 14.21 | UNC: 14.07 | UNR: NA | LCR: 9.87 | LNC: 10.01 | LNR: NA
P1V2_STBY Vol                (0x27) :    1.20 Volts | (ok) | UCR: 1.30 | UNC: 1.28 | UNR: 1.39 | LCR: 1.10 | LNC: 1.12 | LNR: 0.96
P3V3_M2 Vol                  (0x28) :    3.33 Volts | (ok) | UCR: 3.71 | UNC: 3.67 | UNR: NA | LCR: 2.91 | LNC: 2.94 | LNR: NA
HSC Input Vol                (0x29) :   12.51 Volts | (ok) | UCR: 13.36 | UNC: 13.23 | UNR: 14.36 | LCR: 10.71 | LNC: 10.84 | LNR: 10.08
VCCIN VR Vol                 (0x2A) :    1.77 Volts | (ok) | UCR: 1.93 | UNC: 1.91 | UNR: 2.20 | LCR: 1.64 | LNC: 1.66 | LNR: 0.40
FIVRA VR Vol                 (0x2C) :    1.82 Volts | (ok) | UCR: 1.92 | UNC: 1.90 | UNR: 2.20 | LCR: 1.69 | LNC: 1.71 | LNR: 0.40
EHV VR Vol                   (0x2D) :    1.80 Volts | (ok) | UCR: 1.90 | UNC: 1.88 | UNR: 2.20 | LCR: 1.70 | LNC: 1.72 | LNR: 0.40
VCCD VR Vol                  (0x2E) :    1.14 Volts | (ok) | UCR: 1.23 | UNC: 1.21 | UNR: 1.50 | LCR: 1.05 | LNC: 1.06 | LNR: 0.40
FAON VR Vol                  (0x2F) :    1.05 Volts | (ok) | UCR: 1.09 | UNC: 1.07 | UNR: 1.40 | LCR: 0.90 | LNC: 0.91 | LNR: 0.40
HSC Output Cur               (0x30) :    7.52 Amps  | (ok) | UCR: 31.96 | UNC: 28.73 | UNR: 39.95 | LCR: NA | LNC: NA | LNR: NA
VCCIN VR Cur                 (0x31) :   29.80 Amps  | (ok) | UCR: 141.18 | UNC: 119.34 | UNR: 180.18 | LCR: NA | LNC: NA | LNR: NA
FIVRA VR Cur                 (0x32) :    3.60 Amps  | (ok) | UCR: 53.01 | UNC: 48.05 | UNR: 70.99 | LCR: NA | LNC: NA | LNR: NA
EHV VR Cur                   (0x33) :    0.80 Amps  | (ok) | UCR: 6.24 | UNC: 5.04 | UNR: 18.00 | LCR: NA | LNC: NA | LNR: NA
VCCD VR Cur                  (0x34) :    2.60 Amps  | (ok) | UCR: 30.02 | UNC: 26.98 | UNR: 42.94 | LCR: NA | LNC: NA | LNR: NA
FAON VR Cur                  (0x35) :    8.70 Amps  | (ok) | UCR: 46.02 | UNC: 42.12 | UNR: 60.06 | LCR: NA | LNC: NA | LNR: NA
CPU PWR                      (0x38) :   55.00 Watts | (ok) | UCR: NA | UNC: NA | UNR: NA | LCR: NA | LNC: NA | LNR: NA
HSC Input Pwr                (0x39) :   90.08 Watts | (ok) | UCR: 399.28 | UNC: 360.22 | UNR: 499.10 | LCR: NA | LNC: NA | LNR: NA
VCCIN VR Pout                (0x3A) :   24.00 Watts | (ok) | UCR: 253.80 | UNC: 214.32 | UNR: 324.30 | LCR: NA | LNC: NA | LNR: NA
FIVRA VR Pout                (0x3C) :    5.00 Watts | (ok) | UCR: 95.19 | UNC: 86.64 | UNR: 127.68 | LCR: NA | LNC: NA | LNR: NA
EHV VR Pout                  (0x3D) :    1.00 Watts | (ok) | UCR: 11.25 | UNC: 8.97 | UNR: 32.38 | LCR: NA | LNC: NA | LNR: NA
VCCD VR Pout                 (0x3E) :    2.00 Watts | (ok) | UCR: 34.32 | UNC: 31.02 | UNR: 49.28 | LCR: NA | LNC: NA | LNR: NA
FAON VR Pout                 (0x3F) :    7.00 Watts | (ok) | UCR: 49.28 | UNC: 45.08 | UNR: 64.12 | LCR: NA | LNC: NA | LNR: NA
DIMMA PMIC_Pout              (0x1E) :    0.38 Watts | (ok) | UCR: 32.20 | UNC: 31.50 | UNR: NA | LCR: NA | LNC: NA | LNR: NA
DIMMC PMIC_Pout              (0x1F) :    0.62 Watts | (ok) | UCR: 32.20 | UNC: 31.50 | UNR: NA | LCR: NA | LNC: NA | LNR: NA
DIMMD PMIC_Pout              (0x36) :    0.50 Watts | (ok) | UCR: 32.20 | UNC: 31.50 | UNR: NA | LCR: NA | LNC: NA | LNR: NA
DIMME PMIC_Pout              (0x37) :    0.62 Watts | (ok) | UCR: 32.20 | UNC: 31.50 | UNR: NA | LCR: NA | LNC: NA | LNR: NA
DIMMG PMIC_Pout              (0x42) :    0.50 Watts | (ok) | UCR: 32.20 | UNC: 31.50 | UNR: NA | LCR: NA | LNC: NA | LNR: NA
DIMMH PMIC_Pout              (0x47) :    0.75 Watts | (ok) | UCR: 32.20 | UNC: 31.50 | UNR: NA | LCR: NA | LNC: NA | LNR: NA

[BIC console]
uart:~$ platform sensor list_all
---------------------------------------------------------------------------------
[0x1 ] Unsupported name                   : tmp75      | access[O] | 4byte_acur_read_success        | 32
[0x2 ] Unsupported name                   : tmp75      | access[O] | 4byte_acur_read_success        | 49
[0x3 ] Unsupported name                   : tmp75      | access[O] | 4byte_acur_read_success        | 29
[0xd ] Unsupported name                   : nvme       | access[O] | 4byte_acur_read_success        | 34
[0x5 ] Unsupported name                   : peci       | access[O] | 4byte_acur_read_success        | 44
[0x14] Unsupported name                   : peci       | access[O] | 4byte_acur_read_success        | 56
[0x15] Unsupported name                   : peci       | access[O] | 4byte_acur_read_success        | 100
[0x6 ] Unsupported name                   : peci       | access[O] | 4byte_acur_read_success        | 46
[0x7 ] Unsupported name                   : peci       | access[O] | 4byte_acur_read_success        | 46
[0x9 ] Unsupported name                   : peci       | access[O] | 4byte_acur_read_success        | 43
[0xa ] Unsupported name                   : peci       | access[O] | 4byte_acur_read_success        | 45
[0xb ] Unsupported name                   : peci       | access[O] | 4byte_acur_read_success        | 42
[0xc ] Unsupported name                   : peci       | access[O] | 4byte_acur_read_success        | 38
[0x38] Unsupported name                   : peci       | access[O] | 4byte_acur_read_success        | 57
[0x20] Unsupported name                   : adc        | access[O] | 4byte_acur_read_success        | 41418764
[0x22] Unsupported name                   : adc        | access[O] | 4byte_acur_read_success        | 21889027
[0x24] Unsupported name                   : adc        | access[O] | 4byte_acur_read_success        | 3735553
[0x21] Unsupported name                   : adc        | access[O] | 4byte_acur_read_success        | 9240579
[0x25] Unsupported name                   : adc        | access[O] | 4byte_acur_read_success        | 63045636
[0x26] Unsupported name                   : adc        | access[O] | 4byte_acur_read_success        | 40566796
[0x27] Unsupported name                   : adc        | access[O] | 4byte_acur_read_success        | 12517377
[0x28] Unsupported name                   : adc        | access[O] | 4byte_acur_read_success        | 20316163
[0x23] Unsupported name                   : adc        | access[O] | 4byte_acur_read_success        | 52166657
[0x2e] Unsupported name                   : isl69259   | access[O] | 4byte_acur_read_success        | 9371649
[0x2f] Unsupported name                   : isl69259   | access[O] | 4byte_acur_read_success        | 3276801
[0x2d] Unsupported name                   : isl69259   | access[O] | 4byte_acur_read_success        | 52428801
[0x2a] Unsupported name                   : isl69259   | access[O] | 4byte_acur_read_success        | 40435713
[0x2c] Unsupported name                   : isl69259   | access[O] | 4byte_acur_read_success        | 53608449
[0x34] Unsupported name                   : isl69259   | access[O] | 4byte_acur_read_success        | 52428802
[0x35] Unsupported name                   : isl69259   | access[O] | 4byte_acur_read_success        | 52428807
[0x33] Unsupported name                   : isl69259   | access[O] | 4byte_acur_read_success        | 52428800
[0x31] Unsupported name                   : isl69259   | access[O] | 4byte_acur_read_success        | 6553620
[0x32] Unsupported name                   : isl69259   | access[O] | 4byte_acur_read_success        | 6553603
[0x12] Unsupported name                   : isl69259   | access[O] | 4byte_acur_read_success        | 45
[0x13] Unsupported name                   : isl69259   | access[O] | 4byte_acur_read_success        | 47
[0x11] Unsupported name                   : isl69259   | access[O] | 4byte_acur_read_success        | 44
[0xf ] Unsupported name                   : isl69259   | access[O] | 4byte_acur_read_success        | 56
[0x10] Unsupported name                   : isl69259   | access[O] | 4byte_acur_read_success        | 53
[0x3e] Unsupported name                   : isl69259   | access[O] | 4byte_acur_read_success        | 3
[0x3f] Unsupported name                   : isl69259   | access[O] | 4byte_acur_read_success        | 7
[0x3d] Unsupported name                   : isl69259   | access[O] | 4byte_acur_read_success        | 1
[0x3a] Unsupported name                   : isl69259   | access[O] | 4byte_acur_read_success        | 24
[0x3c] Unsupported name                   : isl69259   | access[O] | 4byte_acur_read_success        | 6
[0x4 ] Unsupported name                   : pch        | access[O] | 4byte_acur_read_success        | 50
[0x1e] Unsupported name                   : pmic       | access[O] | 4byte_acur_read_success        | 40960000
[0x1f] Unsupported name                   : pmic       | access[O] | 4byte_acur_read_success        | 40960000
[0x36] Unsupported name                   : pmic       | access[O] | 4byte_acur_read_success        | 49152000
[0x37] Unsupported name                   : pmic       | access[O] | 4byte_acur_read_success        | 49152000
[0x42] Unsupported name                   : pmic       | access[O] | 4byte_acur_read_success        | 40960000
[0x47] Unsupported name                   : pmic       | access[O] | 4byte_acur_read_success        | 32768000
[0xe ] Unsupported name                   : hsc        | access[O] | 4byte_acur_read_success        | 15597613
[0x29] Unsupported name                   : hsc        | access[O] | 4byte_acur_read_success        | 33423372
[0x30] Unsupported name                   : hsc        | access[O] | 4byte_acur_read_success        | 9895942
[0x39] Unsupported name                   : hsc        | access[O] | 4byte_acur_read_success        | 35651659
---------------------------------------------------------------------------------

[error case - SDR size not equal to sensor config size]

BMC console
root@bmc-oob:~# sensor-util slot1 --threshold
slot1:

BIC console
Hello, welcome to yv35 craterlake 2022.22.1
BIC class type(class-1), 1ou present status(0), 2ou present status(0), board revision(0x3)
[init_sensor_size] init sdr size is not equal to config size, sdr size: 0x36, config size: 0x35
BIC should not monitor sensors if SDR size and sensor config size is not match, BIC would not start sensor thread
[sensor_init] init sensor size is zero
ipmi_init
[set_DC_status] gpio number(15) status(1)
[set_post_status] gpio number(1) status(1)
[00:00:00.001,000] <inf> usb_dc_aspeed: select ep[0x3] as OUT endpoint
[00:00:00.056,000] <inf> kcs_aspeed: KCS3: addr=0xca2, idr=0x2c, odr=0x38, str=0x44

[00:00:00.057,000] <err> spi_nor_multi_dev: [1216][spi1_cs0]SFDP magic 00000000 invalid
[00:00:00.057,000] <err> spi_nor_multi_dev: [1460]SFDP read failed: -22
[00:00:00.147,000] <inf> usb_cdc_acm: Device suspended
[00:00:00.361,000] <inf> usb_cdc_acm: from suspend
[00:00:00.666,000] <inf> usb_cdc_acm: Device configured
[00:00:00.361,000] <inf> usb_cdc_acm: Device resumed
[00:00:00.361,000] <inf> usb_cdc_acm: from suspend
[00:00:00.666,000] <inf> usb_cdc_acm: Device configured
uart:~$ BIC Ready
uart:~$ platform sensor list_all
[cmd_sensor_cfg_list_all]: sensor monitor count is zero

[error case - sensor monitor number doesn't match with SDR table]

BMC console

root@bmc-oob:~# sensor-util slot1 --threshold
slot1:
MB Inlet Temp                (0x1) :   25.00 C     | (ok) | UCR: 48.00 | UNC: NA | UNR: 150.00 | LCR: NA | LNC: NA | LNR: NA
MB Outlet Temp               (0x2) :   32.00 C     | (ok) | UCR: 93.00 | UNC: NA | UNR: 150.00 | LCR: NA | LNC: NA | LNR: NA
FIO Temp                     (0x3) :   26.00 C     | (ok) | UCR: 40.00 | UNC: NA | UNR: NA | LCR: NA | LNC: NA | LNR: NA
PCH Temp                     (0x4) :   38.00 C     | (ok) | UCR: 74.00 | UNC: NA | UNR: NA | LCR: NA | LNC: NA | LNR: NA
SOC CPU Temp                 (0x5) :   28.00 C     | (ok) | UCR: 84.00 | UNC: NA | UNR: NA | LCR: NA | LNC: NA | LNR: NA
SOC Therm Margin             (0x14) :  -72.00 C     | (ok) | UCR: NA | UNC: NA | UNR: 125.00 | LCR: NA | LNC: NA | LNR: NA
CPU TjMax                    (0x15) :  100.00 C     | (ok) | UCR: NA | UNC: NA | UNR: 125.00 | LCR: NA | LNC: NA | LNR: NA
DIMMA Temp                   (0x6) :   27.00 C     | (ok) | UCR: 85.00 | UNC: NA | UNR: NA | LCR: NA | LNC: NA | LNR: NA
DIMMC Temp                   (0x7) :   27.00 C     | (ok) | UCR: 85.00 | UNC: NA | UNR: NA | LCR: NA | LNC: NA | LNR: NA
DIMMD Temp                   (0x9) :   27.00 C     | (ok) | UCR: 85.00 | UNC: NA | UNR: NA | LCR: NA | LNC: NA | LNR: NA
DIMME Temp                   (0xA) :   27.00 C     | (ok) | UCR: 85.00 | UNC: NA | UNR: NA | LCR: NA | LNC: NA | LNR: NA
DIMMG Temp                   (0xB) :   27.00 C     | (ok) | UCR: 85.00 | UNC: NA | UNR: NA | LCR: NA | LNC: NA | LNR: NA
DIMMH Temp                   (0xC) :   27.00 C     | (ok) | UCR: 85.00 | UNC: NA | UNR: NA | LCR: NA | LNC: NA | LNR: NA
SSD0 Temp                    (0xD) :   22.00 C     | (ok) | UCR: 75.00 | UNC: NA | UNR: NA | LCR: NA | LNC: NA | LNR: NA
HSC Temp                     (0xE) :   33.00 C     | (ok) | UCR: 86.00 | UNC: NA | UNR: 125.00 | LCR: NA | LNC: NA | LNR: NA
VCCIN SPS Temp               (0xF) :   40.00 C     | (ok) | UCR: 100.00 | UNC: NA | UNR: 125.00 | LCR: NA | LNC: NA | LNR: NA
FIVRA SPS Temp               (0x10) :   37.00 C     | (ok) | UCR: 100.00 | UNC: NA | UNR: 125.00 | LCR: NA | LNC: NA | LNR: NA
EHV SPS Temp                 (0x11) :   31.00 C     | (ok) | UCR: 100.00 | UNC: NA | UNR: 125.00 | LCR: NA | LNC: NA | LNR: NA
VCCD SPS Temp                (0x12) :   33.00 C     | (ok) | UCR: 100.00 | UNC: NA | UNR: 125.00 | LCR: NA | LNC: NA | LNR: NA
FAON SPS Temp                (0x13) :   36.00 C     | (ok) | UCR: 100.00 | UNC: NA | UNR: 125.00 | LCR: NA | LNC: NA | LNR: NA
P12V_STBY Vol                (0x20) :   12.67 Volts | (ok) | UCR: 13.36 | UNC: 13.23 | UNR: 14.36 | LCR: 10.71 | LNC: 10.84 | LNR: 10.08
P3V_BAT Vol                  (0x21) :    3.05 Volts | (ok) | UCR: 3.51 | UNC: 3.46 | UNR: NA | LCR: 2.76 | LNC: 2.79 | LNR: NA
P3V3_STBY Vol                (0x22) :    3.33 Volts | (ok) | UCR: 3.56 | UNC: 3.53 | UNR: 4.00 | LCR: 3.04 | LNC: 3.08 | LNR: 2.30
P1V8_STBY Vol                (0x23) :    1.79 Volts | (ok) | UCR: 1.92 | UNC: 1.90 | UNR: 2.09 | LCR: 1.67 | LNC: 1.69 | LNR: 1.44
P1V05_PCH Vol                (0x24) :    1.05 Volts | (ok) | UCR: 1.12 | UNC: 1.10 | UNR: 1.22 | LCR: 0.97 | LNC: 0.98 | LNR: 0.84
P5V_STBY Vol                 (0x25) :    4.94 Volts | (ok) | UCR: 5.40 | UNC: 5.35 | UNR: 5.80 | LCR: 4.59 | LNC: 4.64 | LNR: 4.00
P12V_DIMM Vol                (0x26) :   12.49 Volts | (ok) | UCR: 14.21 | UNC: 14.07 | UNR: NA | LCR: 9.87 | LNC: 10.01 | LNR: NA
P1V2_STBY Vol                (0x27) :    1.19 Volts | (ok) | UCR: 1.30 | UNC: 1.28 | UNR: 1.39 | LCR: 1.10 | LNC: 1.12 | LNR: 0.96
P3V3_M2 Vol                  (0x28) :    3.30 Volts | (ok) | UCR: 3.71 | UNC: 3.67 | UNR: NA | LCR: 2.91 | LNC: 2.94 | LNR: NA
HSC Input Vol                (0x29) : NA | (na)
VCCIN VR Vol                 (0x2A) :    1.77 Volts | (ok) | UCR: 1.93 | UNC: 1.91 | UNR: 2.20 | LCR: 1.64 | LNC: 1.66 | LNR: 0.40
FIVRA VR Vol                 (0x2C) :    1.82 Volts | (ok) | UCR: 1.92 | UNC: 1.90 | UNR: 2.20 | LCR: 1.69 | LNC: 1.71 | LNR: 0.40
EHV VR Vol                   (0x2D) :    1.80 Volts | (ok) | UCR: 1.90 | UNC: 1.88 | UNR: 2.20 | LCR: 1.70 | LNC: 1.72 | LNR: 0.40
VCCD VR Vol                  (0x2E) :    1.14 Volts | (ok) | UCR: 1.23 | UNC: 1.21 | UNR: 1.50 | LCR: 1.05 | LNC: 1.06 | LNR: 0.40
FAON VR Vol                  (0x2F) :    1.05 Volts | (ok) | UCR: 1.09 | UNC: 1.07 | UNR: 1.40 | LCR: 0.90 | LNC: 0.91 | LNR: 0.40
HSC Output Cur               (0x30) :    7.50 Amps  | (ok) | UCR: 31.96 | UNC: 28.73 | UNR: 39.95 | LCR: NA | LNC: NA | LNR: NA
VCCIN VR Cur                 (0x31) :   31.80 Amps  | (ok) | UCR: 141.18 | UNC: 119.34 | UNR: 180.18 | LCR: NA | LNC: NA | LNR: NA
FIVRA VR Cur                 (0x32) :    3.30 Amps  | (ok) | UCR: 53.01 | UNC: 48.05 | UNR: 70.99 | LCR: NA | LNC: NA | LNR: NA
EHV VR Cur                   (0x33) :    0.80 Amps  | (ok) | UCR: 6.24 | UNC: 5.04 | UNR: 18.00 | LCR: NA | LNC: NA | LNR: NA
VCCD VR Cur                  (0x34) :    2.80 Amps  | (ok) | UCR: 30.02 | UNC: 26.98 | UNR: 42.94 | LCR: NA | LNC: NA | LNR: NA
FAON VR Cur                  (0x35) :    8.80 Amps  | (ok) | UCR: 46.02 | UNC: 42.12 | UNR: 60.06 | LCR: NA | LNC: NA | LNR: NA
CPU PWR                      (0x38) :   74.00 Watts | (ok) | UCR: NA | UNC: NA | UNR: NA | LCR: NA | LNC: NA | LNR: NA
HSC Input Pwr                (0x39) :   88.00 Watts | (ok) | UCR: 399.28 | UNC: 360.22 | UNR: 499.10 | LCR: NA | LNC: NA | LNR: NA
VCCIN VR Pout                (0x3A) :   56.00 Watts | (ok) | UCR: 253.80 | UNC: 214.32 | UNR: 324.30 | LCR: NA | LNC: NA | LNR: NA
FIVRA VR Pout                (0x3C) :    6.00 Watts | (ok) | UCR: 95.19 | UNC: 86.64 | UNR: 127.68 | LCR: NA | LNC: NA | LNR: NA
EHV VR Pout                  (0x3D) :    1.00 Watts | (ok) | UCR: 11.25 | UNC: 8.97 | UNR: 32.38 | LCR: NA | LNC: NA | LNR: NA
VCCD VR Pout                 (0x3E) :    2.00 Watts | (ok) | UCR: 34.32 | UNC: 31.02 | UNR: 49.28 | LCR: NA | LNC: NA | LNR: NA
FAON VR Pout                 (0x3F) :    8.00 Watts | (ok) | UCR: 49.28 | UNC: 45.08 | UNR: 64.12 | LCR: NA | LNC: NA | LNR: NA
DIMMA PMIC_Pout              (0x1E) :    0.62 Watts | (ok) | UCR: 32.20 | UNC: 31.50 | UNR: NA | LCR: NA | LNC: NA | LNR: NA
DIMMC PMIC_Pout              (0x1F) :    0.88 Watts | (ok) | UCR: 32.20 | UNC: 31.50 | UNR: NA | LCR: NA | LNC: NA | LNR: NA
DIMMD PMIC_Pout              (0x36) :    0.62 Watts | (ok) | UCR: 32.20 | UNC: 31.50 | UNR: NA | LCR: NA | LNC: NA | LNR: NA
DIMME PMIC_Pout              (0x37) :    0.62 Watts | (ok) | UCR: 32.20 | UNC: 31.50 | UNR: NA | LCR: NA | LNC: NA | LNR: NA
DIMMG PMIC_Pout              (0x42) :    0.50 Watts | (ok) | UCR: 32.20 | UNC: 31.50 | UNR: NA | LCR: NA | LNC: NA | LNR: NA
DIMMH PMIC_Pout              (0x47) :    0.50 Watts | (ok) | UCR: 32.20 | UNC: 31.50 | UNR: NA | LCR: NA | LNC: NA | LNR: NA

BIC console

uart:~$ platform sensor list_all
---------------------------------------------------------------------------------
[0x1 ] Unsupported name                   : tmp75      | access[O] | 4byte_acur_read_success        | 25
[0x2 ] Unsupported name                   : tmp75      | access[O] | 4byte_acur_read_success        | 32
[0x3 ] Unsupported name                   : tmp75      | access[O] | 4byte_acur_read_success        | 26
[0xd ] Unsupported name                   : nvme       | access[O] | 4byte_acur_read_success        | 22
[0x5 ] Unsupported name                   : peci       | access[O] | 4byte_acur_read_success        | 29
[0x14] Unsupported name                   : peci       | access[O] | 4byte_acur_read_success        | 71
[0x15] Unsupported name                   : peci       | access[O] | 4byte_acur_read_success        | 100
[0x6 ] Unsupported name                   : peci       | access[O] | 4byte_acur_read_success        | 27
[0x7 ] Unsupported name                   : peci       | access[O] | 4byte_acur_read_success        | 27
[0x9 ] Unsupported name                   : peci       | access[O] | 4byte_acur_read_success        | 27
[0xa ] Unsupported name                   : peci       | access[O] | 4byte_acur_read_success        | 27
[0xb ] Unsupported name                   : peci       | access[O] | 4byte_acur_read_success        | 27
[0xc ] Unsupported name                   : peci       | access[O] | 4byte_acur_read_success        | 27
[0x38] Unsupported name                   : peci       | access[O] | 4byte_acur_read_success        | 74
[0x20] Unsupported name                   : adc        | access[O] | 4byte_acur_read_success        | 42336268
[0x22] Unsupported name                   : adc        | access[O] | 4byte_acur_read_success        | 22151171
[0x24] Unsupported name                   : adc        | access[O] | 4byte_acur_read_success        | 3407873
[0x21] Unsupported name                   : adc        | access[O] | 4byte_acur_read_success        | 3538947
[0x25] Unsupported name                   : adc        | access[O] | 4byte_acur_read_success        | 61407236
[0x26] Unsupported name                   : adc        | access[O] | 4byte_acur_read_success        | 34013196
[0x27] Unsupported name                   : adc        | access[O] | 4byte_acur_read_success        | 12320769
[0x28] Unsupported name                   : adc        | access[O] | 4byte_acur_read_success        | 19922947
[0x23] Unsupported name                   : adc        | access[O] | 4byte_acur_read_success        | 51707905
[0x2e] Unsupported name                   : isl69259   | access[O] | 4byte_acur_read_success        | 9306113
[0x2f] Unsupported name                   : isl69259   | access[O] | 4byte_acur_read_success        | 3276801
[0x2d] Unsupported name                   : isl69259   | access[O] | 4byte_acur_read_success        | 52428801
[0x2a] Unsupported name                   : isl69259   | access[O] | 4byte_acur_read_success        | 50593793
[0x2c] Unsupported name                   : isl69259   | access[O] | 4byte_acur_read_success        | 53608449
[0x34] Unsupported name                   : isl69259   | access[O] | 4byte_acur_read_success        | 52428802
[0x35] Unsupported name                   : isl69259   | access[O] | 4byte_acur_read_success        | 52428808
[0x33] Unsupported name                   : isl69259   | access[O] | 4byte_acur_read_success        | 52428800
[0x31] Unsupported name                   : isl69259   | access[O] | 4byte_acur_read_success        | 52428831
[0x32] Unsupported name                   : isl69259   | access[O] | 4byte_acur_read_success        | 19660803
[0x12] Unsupported name                   : isl69259   | access[O] | 4byte_acur_read_success        | 33
[0x13] Unsupported name                   : isl69259   | access[O] | 4byte_acur_read_success        | 36
[0x11] Unsupported name                   : isl69259   | access[O] | 4byte_acur_read_success        | 31
[0xf ] Unsupported name                   : isl69259   | access[O] | 4byte_acur_read_success        | 40
[0x10] Unsupported name                   : isl69259   | access[O] | 4byte_acur_read_success        | 37
[0x3e] Unsupported name                   : isl69259   | access[O] | 4byte_acur_read_success        | 2
[0x3f] Unsupported name                   : isl69259   | access[O] | 4byte_acur_read_success        | 8
[0x3d] Unsupported name                   : isl69259   | access[O] | 4byte_acur_read_success        | 1
[0x3a] Unsupported name                   : isl69259   | access[O] | 4byte_acur_read_success        | 56
[0x3c] Unsupported name                   : isl69259   | access[O] | 4byte_acur_read_success        | 6
[0x4 ] Unsupported name                   : pch        | access[O] | 4byte_acur_read_success        | 38
[0x1e] Unsupported name                   : pmic       | access[O] | 4byte_acur_read_success        | 57344000
[0x1f] Unsupported name                   : pmic       | access[O] | 4byte_acur_read_success        | 49152000
[0x36] Unsupported name                   : pmic       | access[O] | 4byte_acur_read_success        | 32768000
[0x37] Unsupported name                   : pmic       | access[O] | 4byte_acur_read_success        | 40960000
[0x42] Unsupported name                   : pmic       | access[O] | 4byte_acur_read_success        | 40960000
[0x47] Unsupported name                   : pmic       | access[O] | 4byte_acur_read_success        | 32768000
[0xe ] Unsupported name                   : mp5990     | access[O] | 4byte_acur_read_success        | 33
[0x50] Unsupported name                   : mp5990     | access[O] | init_status                    | 0
[0x30] Unsupported name                   : mp5990     | access[O] | 4byte_acur_read_success        | 7
[0x39] Unsupported name                   : mp5990     | access[O] | 4byte_acur_read_success        | 88
---------------------------------------------------------------------------------
[get_sensor_reading] fail to find sensor info in config table, sensor_num: 0x29
[sensor_poll_handler] fail to find sensor SDR info, sensor number: 0x50

Reviewed By: garnermic

Differential Revision: D37326854

Pulled By: GoldenBug

fbshipit-source-id: fbece727731702fcf235034b067bdfc0182f6edc
MouchenHung-QUANTA added a commit to MouchenHung-QUANTA/OpenBIC that referenced this pull request Jun 27, 2022
@MouchenHung-QUANTA
wc: mb: Follow some pr from other projects
845c8cf 
[Features]
- Reference to facebook#355 / facebook#339 / facebook#349 .

[Fix]

[Note]
MouchenHung-QUANTA added a commit to MouchenHung-QUANTA/OpenBIC that referenced this pull request Jun 27, 2022
@MouchenHung-QUANTA
wc: mb: Modify some function based on some commits
6e8ff07 
Summary:
- Based on facebook#339 and facebook#349
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

3 participants

@DelphineChiu @facebook-github-bot @LoraLin1