fby3.5: common:Fix sensor monitor memcpy fail causing BIC crash issue by DelphineChiu · Pull Request #349 · facebook/OpenBIC

DelphineChiu · 2022-06-21T02:00:02Z

Summary:

Fix sensor monitor memcpy fail causing BIC crash issue
- Check SDR/sensor config table size before memcpy SDR/sensor config from platform to common.
  If SDR size not equal to sensor config size, BIC would not allocate SDR/sensor config table and monitor sensor.
Improve sensor monitor
- Array Config D BB BIC full_sdr_table: remove redundancy SDR.
- Array full_sdr_table: allocate memory size according to different cards present.
- Function add_full_sdr_table: check SDR table size before adding SDR.
- Function add_sensor_config: check config table size before adding sensor config.
- Function get_sensor_reading: check sensor information in sensor config table.
- Variable sensor_config_num: modify variable name to sensor_config_count making name more readable.
- Command platform: fix BIC crash when sensor list_all command fail to map sensor information.

Dependency: #339

Test Plan:

Build code: Pass
Check BIC status in error case with Config A/B/C/D: Pass
Check sensor monitor in error case with Config A/B/C/D: Pass

error case error handling

SDR table size is not equal to config table size Do not allocate memory to SDR/sensor config table, and BIC would not monitor sensor.
sensor monitor number doesn't match with SDR table Print "[sensor_poll_handler] fail to find sensor SDR info, sensor number: 0xXX" and sensor would monitor this sensor,
if config table sensor number is not found in SDR table.
Print "[get_sensor_reading] fail to find sensor info in config table, sensor_num: 0xXX" and sensor would show NA on sensor-util,
if sdr table sensor number is not found in config table.
Log:
[normal case]

[BMC console]
root@bmc-oob:~# sensor-util slot2:
MB Inlet Temp (0x1) : 32.00 C MB Outlet Temp (0x2) : 49.00 C FIO Temp (0x3) : 29.00 C PCH Temp (0x4) : 45.00 C SOC CPU Temp (0x5) : 44.00 C SOC Therm Margin (0x14) : -56.00 C CPU TjMax (0x15) : 100.00 C DIMMA Temp (0x6) : 46.00 C DIMMC Temp (0x7) : 46.00 C DIMMD Temp (0x9) : 43.00 C DIMME Temp (0xA) : 45.00 C DIMMG Temp (0xB) : 42.00 C DIMMH Temp (0xC) : 38.00 C SSD0 Temp (0xD) : 34.00 C HSC Temp (0xE) : 45.95 C VCCIN SPS Temp (0xF) : 57.00 C FIVRA SPS Temp (0x10) : 54.00 C EHV SPS Temp (0x11) : 45.00 C VCCD SPS Temp (0x12) : 43.00 C FAON SPS Temp (0x13) : 47.00 C P12V_STBY Vol (0x20) : P3V_BAT Vol (0x21) : P3V3_STBY Vol (0x22) : P1V8_STBY Vol (0x23) : P1V05_PCH Vol (0x24) : P5V_STBY Vol (0x25) : P12V_DIMM Vol (0x26) : P1V2_STBY Vol (0x27) : P3V3_M2 Vol (0x28) : HSC Input Vol (0x29) : VCCIN VR Vol (0x2A) : FIVRA VR Vol (0x2C) : EHV VR Vol (0x2D) : VCCD VR Vol (0x2E) : FAON VR Vol (0x2F) : HSC Output Cur (0x30) : VCCIN VR Cur (0x31) : FIVRA VR Cur (0x32) : EHV VR Cur (0x33) : VCCD VR Cur (0x34) : FAON VR Cur (0x35) : CPU PWR (0x38) : HSC Input Pwr (0x39) : VCCIN VR Pout (0x3A) : FIVRA VR Pout (0x3C) : EHV VR Pout (0x3D) : VCCD VR Pout (0x3E) : FAON VR Pout (0x3F) : DIMMA PMIC_Pout (0x1E) : DIMMC PMIC_Pout (0x1F) : DIMMD PMIC_Pout (0x36) : DIMME PMIC_Pout (0x37) : DIMMG PMIC_Pout (0x42) : DIMMH PMIC_Pout (0x47) : slot2 --threshold
| (ok) | UCR: 48.00 | UNC: NA | UNR: 150.00 | LCR: NA | LNC: NA | LNR: NA
| (ok) | UCR: 93.00 | UNC: NA | UNR: 150.00 | LCR: NA | LNC: NA | LNR: NA
| (ok) | UCR: 40.00 | UNC: NA | UNR: NA | LCR: NA | LNC: NA | LNR: NA
| (ok) | UCR: 74.00 | UNC: NA | UNR: NA | LCR: NA | LNC: NA | LNR: NA
| (ok) | UCR: 84.00 | UNC: NA | UNR: NA | LCR: NA | LNC: NA | LNR: NA
| (ok) | UCR: NA | UNC: NA | UNR: 125.00 | LCR: NA | LNC: NA | LNR: NA
| (ok) | UCR: NA | UNC: NA | UNR: 125.00 | LCR: NA | LNC: NA | LNR: NA
| (ok) | UCR: 85.00 | UNC: NA | UNR: NA | LCR: NA | LNC: NA | LNR: NA
| (ok) | UCR: 85.00 | UNC: NA | UNR: NA | LCR: NA | LNC: NA | LNR: NA
| (ok) | UCR: 85.00 | UNC: NA | UNR: NA | LCR: NA | LNC: NA | LNR: NA
| (ok) | UCR: 85.00 | UNC: NA | UNR: NA | LCR: NA | LNC: NA | LNR: NA
| (ok) | UCR: 85.00 | UNC: NA | UNR: NA | LCR: NA | LNC: NA | LNR: NA
| (ok) | UCR: 85.00 | UNC: NA | UNR: NA | LCR: NA | LNC: NA | LNR: NA
| (ok) | UCR: 75.00 | UNC: NA | UNR: NA | LCR: NA | LNC: NA | LNR: NA
| (ok) | UCR: 86.00 | UNC: NA | UNR: 125.00 | LCR: NA | LNC: NA | LNR: NA
| (ok) | UCR: 100.00 | UNC: NA | UNR: 125.00 | LCR: NA | LNC: NA | LNR: NA
| (ok) | UCR: 100.00 | UNC: NA | UNR: 125.00 | LCR: NA | LNC: NA | LNR: NA
| (ok) | UCR: 100.00 | UNC: NA | UNR: 125.00 | LCR: NA | LNC: NA | LNR: NA
| (ok) | UCR: 100.00 | UNC: NA | UNR: 125.00 | LCR: NA | LNC: NA | LNR: NA
| (ok) | UCR: 100.00 | UNC: NA | UNR: 125.00 | LCR: NA | LNC: NA | LNR: NA
12.68 Volts | (ok) | UCR: 13.36 | UNC: 13.23 | UNR: 14.36 | LCR: 10.71 | LNC: 10.84 | LNR: 10.08
3.13 Volts | (ok) | UCR: 3.51 | UNC: 3.46 | UNR: NA | LCR: 2.76 | LNC: 2.79 | LNR: NA
3.34 Volts | (ok) | UCR: 3.56 | UNC: 3.53 | UNR: 4.00 | LCR: 3.04 | LNC: 3.08 | LNR: 2.30
1.81 Volts | (ok) | UCR: 1.92 | UNC: 1.90 | UNR: 2.09 | LCR: 1.67 | LNC: 1.69 | LNR: 1.44
1.06 Volts | (ok) | UCR: 1.12 | UNC: 1.10 | UNR: 1.22 | LCR: 0.97 | LNC: 0.98 | LNR: 0.84
5.02 Volts | (ok) | UCR: 5.40 | UNC: 5.35 | UNR: 5.80 | LCR: 4.59 | LNC: 4.64 | LNR: 4.00
12.73 Volts | (ok) | UCR: 14.21 | UNC: 14.07 | UNR: NA | LCR: 9.87 | LNC: 10.01 | LNR: NA
1.20 Volts | (ok) | UCR: 1.30 | UNC: 1.28 | UNR: 1.39 | LCR: 1.10 | LNC: 1.12 | LNR: 0.96
3.33 Volts | (ok) | UCR: 3.71 | UNC: 3.67 | UNR: NA | LCR: 2.91 | LNC: 2.94 | LNR: NA
12.51 Volts | (ok) | UCR: 13.36 | UNC: 13.23 | UNR: 14.36 | LCR: 10.71 | LNC: 10.84 | LNR: 10.08
1.77 Volts | (ok) | UCR: 1.93 | UNC: 1.91 | UNR: 2.20 | LCR: 1.64 | LNC: 1.66 | LNR: 0.40
1.82 Volts | (ok) | UCR: 1.92 | UNC: 1.90 | UNR: 2.20 | LCR: 1.69 | LNC: 1.71 | LNR: 0.40
1.80 Volts | (ok) | UCR: 1.90 | UNC: 1.88 | UNR: 2.20 | LCR: 1.70 | LNC: 1.72 | LNR: 0.40
1.14 Volts | (ok) | UCR: 1.23 | UNC: 1.21 | UNR: 1.50 | LCR: 1.05 | LNC: 1.06 | LNR: 0.40
1.05 Volts | (ok) | UCR: 1.09 | UNC: 1.07 | UNR: 1.40 | LCR: 0.90 | LNC: 0.91 | LNR: 0.40
7.52 Amps | (ok) | UCR: 31.96 | UNC: 28.73 | UNR: 39.95 | LCR: NA | LNC: NA | LNR: NA
29.80 Amps | (ok) | UCR: 141.18 | UNC: 119.34 | UNR: 180.18 | LCR: NA | LNC: NA | LNR: NA
3.60 Amps | (ok) | UCR: 53.01 | UNC: 48.05 | UNR: 70.99 | LCR: NA | LNC: NA | LNR: NA
0.80 Amps | (ok) | UCR: 6.24 | UNC: 5.04 | UNR: 18.00 | LCR: NA | LNC: NA | LNR: NA
2.60 Amps | (ok) | UCR: 30.02 | UNC: 26.98 | UNR: 42.94 | LCR: NA | LNC: NA | LNR: NA
8.70 Amps | (ok) | UCR: 46.02 | UNC: 42.12 | UNR: 60.06 | LCR: NA | LNC: NA | LNR: NA
55.00 Watts | (ok) | UCR: NA | UNC: NA | UNR: NA | LCR: NA | LNC: NA | LNR: NA
90.08 Watts | (ok) | UCR: 399.28 | UNC: 360.22 | UNR: 499.10 | LCR: NA | LNC: NA | LNR: NA
24.00 Watts | (ok) | UCR: 253.80 | UNC: 214.32 | UNR: 324.30 | LCR: NA | LNC: NA | LNR: NA
5.00 Watts | (ok) | UCR: 95.19 | UNC: 86.64 | UNR: 127.68 | LCR: NA | LNC: NA | LNR: NA
1.00 Watts | (ok) | UCR: 11.25 | UNC: 8.97 | UNR: 32.38 | LCR: NA | LNC: NA | LNR: NA
2.00 Watts | (ok) | UCR: 34.32 | UNC: 31.02 | UNR: 49.28 | LCR: NA | LNC: NA | LNR: NA
7.00 Watts | (ok) | UCR: 49.28 | UNC: 45.08 | UNR: 64.12 | LCR: NA | LNC: NA | LNR: NA
0.38 Watts | (ok) | UCR: 32.20 | UNC: 31.50 | UNR: NA | LCR: NA | LNC: NA | LNR: NA
0.62 Watts | (ok) | UCR: 32.20 | UNC: 31.50 | UNR: NA | LCR: NA | LNC: NA | LNR: NA
0.50 Watts | (ok) | UCR: 32.20 | UNC: 31.50 | UNR: NA | LCR: NA | LNC: NA | LNR: NA
0.62 Watts | (ok) | UCR: 32.20 | UNC: 31.50 | UNR: NA | LCR: NA | LNC: NA | LNR: NA
0.50 Watts | (ok) | UCR: 32.20 | UNC: 31.50 | UNR: NA | LCR: NA | LNC: NA | LNR: NA
0.75 Watts | (ok) | UCR: 32.20 | UNC: 31.50 | UNR: NA | LCR: NA | LNC: NA | LNR: NA

[BIC console]
uart:~$ platform sensor list_all

[0x1 ] Unsupported name : tmp75 | access[O] | 4byte_acur_read_success | 32
[0x2 ] Unsupported name : tmp75 | access[O] | 4byte_acur_read_success | 49
[0x3 ] Unsupported name : tmp75 | access[O] | 4byte_acur_read_success | 29
[0xd ] Unsupported name : nvme | access[O] | 4byte_acur_read_success | 34
[0x5 ] Unsupported name : peci | access[O] | 4byte_acur_read_success | 44
[0x14] Unsupported name : peci | access[O] | 4byte_acur_read_success | 56
[0x15] Unsupported name : peci | access[O] | 4byte_acur_read_success | 100
[0x6 ] Unsupported name : peci | access[O] | 4byte_acur_read_success | 46
[0x7 ] Unsupported name : peci | access[O] | 4byte_acur_read_success | 46
[0x9 ] Unsupported name : peci | access[O] | 4byte_acur_read_success | 43
[0xa ] Unsupported name : peci | access[O] | 4byte_acur_read_success | 45
[0xb ] Unsupported name : peci | access[O] | 4byte_acur_read_success | 42
[0xc ] Unsupported name : peci | access[O] | 4byte_acur_read_success | 38
[0x38] Unsupported name : peci | access[O] | 4byte_acur_read_success | 57
[0x20] Unsupported name : adc | access[O] | 4byte_acur_read_success | 41418764
[0x22] Unsupported name : adc | access[O] | 4byte_acur_read_success | 21889027
[0x24] Unsupported name : adc | access[O] | 4byte_acur_read_success | 3735553
[0x21] Unsupported name : adc | access[O] | 4byte_acur_read_success | 9240579
[0x25] Unsupported name : adc | access[O] | 4byte_acur_read_success | 63045636
[0x26] Unsupported name : adc | access[O] | 4byte_acur_read_success | 40566796
[0x27] Unsupported name : adc | access[O] | 4byte_acur_read_success | 12517377
[0x28] Unsupported name : adc | access[O] | 4byte_acur_read_success | 20316163
[0x23] Unsupported name : adc | access[O] | 4byte_acur_read_success | 52166657
[0x2e] Unsupported name : isl69259 | access[O] | 4byte_acur_read_success | 9371649
[0x2f] Unsupported name : isl69259 | access[O] | 4byte_acur_read_success | 3276801
[0x2d] Unsupported name : isl69259 | access[O] | 4byte_acur_read_success | 52428801
[0x2a] Unsupported name : isl69259 | access[O] | 4byte_acur_read_success | 40435713
[0x2c] Unsupported name : isl69259 | access[O] | 4byte_acur_read_success | 53608449
[0x34] Unsupported name : isl69259 | access[O] | 4byte_acur_read_success | 52428802
[0x35] Unsupported name : isl69259 | access[O] | 4byte_acur_read_success | 52428807
[0x33] Unsupported name : isl69259 | access[O] | 4byte_acur_read_success | 52428800
[0x31] Unsupported name : isl69259 | access[O] | 4byte_acur_read_success | 6553620
[0x32] Unsupported name : isl69259 | access[O] | 4byte_acur_read_success | 6553603
[0x12] Unsupported name : isl69259 | access[O] | 4byte_acur_read_success | 45
[0x13] Unsupported name : isl69259 | access[O] | 4byte_acur_read_success | 47
[0x11] Unsupported name : isl69259 | access[O] | 4byte_acur_read_success | 44
[0xf ] Unsupported name : isl69259 | access[O] | 4byte_acur_read_success | 56
[0x10] Unsupported name : isl69259 | access[O] | 4byte_acur_read_success | 53
[0x3e] Unsupported name : isl69259 | access[O] | 4byte_acur_read_success | 3
[0x3f] Unsupported name : isl69259 | access[O] | 4byte_acur_read_success | 7
[0x3d] Unsupported name : isl69259 | access[O] | 4byte_acur_read_success | 1
[0x3a] Unsupported name : isl69259 | access[O] | 4byte_acur_read_success | 24
[0x3c] Unsupported name : isl69259 | access[O] | 4byte_acur_read_success | 6
[0x4 ] Unsupported name : pch | access[O] | 4byte_acur_read_success | 50
[0x1e] Unsupported name : pmic | access[O] | 4byte_acur_read_success | 40960000
[0x1f] Unsupported name : pmic | access[O] | 4byte_acur_read_success | 40960000
[0x36] Unsupported name : pmic | access[O] | 4byte_acur_read_success | 49152000
[0x37] Unsupported name : pmic | access[O] | 4byte_acur_read_success | 49152000
[0x42] Unsupported name : pmic | access[O] | 4byte_acur_read_success | 40960000
[0x47] Unsupported name : pmic | access[O] | 4byte_acur_read_success | 32768000
[0xe ] Unsupported name : hsc | access[O] | 4byte_acur_read_success | 15597613
[0x29] Unsupported name : hsc | access[O] | 4byte_acur_read_success | 33423372
[0x30] Unsupported name : hsc | access[O] | 4byte_acur_read_success | 9895942
[0x39] Unsupported name : hsc | access[O] | 4byte_acur_read_success | 35651659

[error case - SDR size not equal to sensor config size]

BMC console
root@bmc-oob:~# sensor-util slot1 --threshold
slot1:

BIC console
Hello, welcome to yv35 craterlake 2022.22.1
BIC class type(class-1), 1ou present status(0), 2ou present status(0), board revision(0x3)
[init_sensor_size] init sdr size is not equal to config size, sdr size: 0x36, config size: 0x35
BIC should not monitor sensors if SDR size and sensor config size is not match, BIC would not start sensor thread
[sensor_init] init sensor size is zero
ipmi_init
[set_DC_status] gpio number(15) status(1)
[set_post_status] gpio number(1) status(1)
[00:00:00.001,000] usb_dc_aspeed: select ep[0x3] as OUT endpoint
[00:00:00.056,000] kcs_aspeed: KCS3: addr=0xca2, idr=0x2c, odr=0x38, str=0x44

[00:00:00.057,000] spi_nor_multi_dev: [1216][spi1_cs0]SFDP magic 00000000 invalid
[00:00:00.057,000] spi_nor_multi_dev: [1460]SFDP read failed: -22
[00:00:00.147,000] usb_cdc_acm: Device suspended
[00:00:00.361,000] usb_cdc_acm: from suspend
[00:00:00.666,000] usb_cdc_acm: Device configured
[00:00:00.361,000] usb_cdc_acm: Device resumed
[00:00:00.361,000] usb_cdc_acm: from suspend
[00:00:00.666,000] usb_cdc_acm: Device configured
uart:$ BIC Ready
uart:$ platform sensor list_all
[cmd_sensor_cfg_list_all]: sensor monitor count is zero

[error case - sensor monitor number doesn't match with SDR table]

BMC console

root@bmc-oob:~# sensor-util slot1 --threshold
slot1:
MB Inlet Temp (0x1) : 25.00 C | (ok) | UCR: 48.00 | UNC: NA | UNR: 150.00 | LCR: NA | LNC: NA | LNR: NA
MB Outlet Temp (0x2) : 32.00 C | (ok) | UCR: 93.00 | UNC: NA | UNR: 150.00 | LCR: NA | LNC: NA | LNR: NA
FIO Temp (0x3) : 26.00 C | (ok) | UCR: 40.00 | UNC: NA | UNR: NA | LCR: NA | LNC: NA | LNR: NA
PCH Temp (0x4) : 38.00 C | (ok) | UCR: 74.00 | UNC: NA | UNR: NA | LCR: NA | LNC: NA | LNR: NA
SOC CPU Temp (0x5) : 28.00 C | (ok) | UCR: 84.00 | UNC: NA | UNR: NA | LCR: NA | LNC: NA | LNR: NA
SOC Therm Margin (0x14) : -72.00 C | (ok) | UCR: NA | UNC: NA | UNR: 125.00 | LCR: NA | LNC: NA | LNR: NA
CPU TjMax (0x15) : 100.00 C | (ok) | UCR: NA | UNC: NA | UNR: 125.00 | LCR: NA | LNC: NA | LNR: NA
DIMMA Temp (0x6) : 27.00 C | (ok) | UCR: 85.00 | UNC: NA | UNR: NA | LCR: NA | LNC: NA | LNR: NA
DIMMC Temp (0x7) : 27.00 C | (ok) | UCR: 85.00 | UNC: NA | UNR: NA | LCR: NA | LNC: NA | LNR: NA
DIMMD Temp (0x9) : 27.00 C | (ok) | UCR: 85.00 | UNC: NA | UNR: NA | LCR: NA | LNC: NA | LNR: NA
DIMME Temp (0xA) : 27.00 C | (ok) | UCR: 85.00 | UNC: NA | UNR: NA | LCR: NA | LNC: NA | LNR: NA
DIMMG Temp (0xB) : 27.00 C | (ok) | UCR: 85.00 | UNC: NA | UNR: NA | LCR: NA | LNC: NA | LNR: NA
DIMMH Temp (0xC) : 27.00 C | (ok) | UCR: 85.00 | UNC: NA | UNR: NA | LCR: NA | LNC: NA | LNR: NA
SSD0 Temp (0xD) : 22.00 C | (ok) | UCR: 75.00 | UNC: NA | UNR: NA | LCR: NA | LNC: NA | LNR: NA
HSC Temp (0xE) : 33.00 C | (ok) | UCR: 86.00 | UNC: NA | UNR: 125.00 | LCR: NA | LNC: NA | LNR: NA
VCCIN SPS Temp (0xF) : 40.00 C | (ok) | UCR: 100.00 | UNC: NA | UNR: 125.00 | LCR: NA | LNC: NA | LNR: NA
FIVRA SPS Temp (0x10) : 37.00 C | (ok) | UCR: 100.00 | UNC: NA | UNR: 125.00 | LCR: NA | LNC: NA | LNR: NA
EHV SPS Temp (0x11) : 31.00 C | (ok) | UCR: 100.00 | UNC: NA | UNR: 125.00 | LCR: NA | LNC: NA | LNR: NA
VCCD SPS Temp (0x12) : 33.00 C | (ok) | UCR: 100.00 | UNC: NA | UNR: 125.00 | LCR: NA | LNC: NA | LNR: NA
FAON SPS Temp (0x13) : 36.00 C | (ok) | UCR: 100.00 | UNC: NA | UNR: 125.00 | LCR: NA | LNC: NA | LNR: NA
P12V_STBY Vol (0x20) : 12.67 Volts | (ok) | UCR: 13.36 | UNC: 13.23 | UNR: 14.36 | LCR: 10.71 | LNC: 10.84 | LNR: 10.08
P3V_BAT Vol (0x21) : 3.05 Volts | (ok) | UCR: 3.51 | UNC: 3.46 | UNR: NA | LCR: 2.76 | LNC: 2.79 | LNR: NA
P3V3_STBY Vol (0x22) : 3.33 Volts | (ok) | UCR: 3.56 | UNC: 3.53 | UNR: 4.00 | LCR: 3.04 | LNC: 3.08 | LNR: 2.30
P1V8_STBY Vol (0x23) : 1.79 Volts | (ok) | UCR: 1.92 | UNC: 1.90 | UNR: 2.09 | LCR: 1.67 | LNC: 1.69 | LNR: 1.44
P1V05_PCH Vol (0x24) : 1.05 Volts | (ok) | UCR: 1.12 | UNC: 1.10 | UNR: 1.22 | LCR: 0.97 | LNC: 0.98 | LNR: 0.84
P5V_STBY Vol (0x25) : 4.94 Volts | (ok) | UCR: 5.40 | UNC: 5.35 | UNR: 5.80 | LCR: 4.59 | LNC: 4.64 | LNR: 4.00
P12V_DIMM Vol (0x26) : 12.49 Volts | (ok) | UCR: 14.21 | UNC: 14.07 | UNR: NA | LCR: 9.87 | LNC: 10.01 | LNR: NA
P1V2_STBY Vol (0x27) : 1.19 Volts | (ok) | UCR: 1.30 | UNC: 1.28 | UNR: 1.39 | LCR: 1.10 | LNC: 1.12 | LNR: 0.96
P3V3_M2 Vol (0x28) : 3.30 Volts | (ok) | UCR: 3.71 | UNC: 3.67 | UNR: NA | LCR: 2.91 | LNC: 2.94 | LNR: NA
HSC Input Vol (0x29) : NA | (na)
VCCIN VR Vol (0x2A) : 1.77 Volts | (ok) | UCR: 1.93 | UNC: 1.91 | UNR: 2.20 | LCR: 1.64 | LNC: 1.66 | LNR: 0.40
FIVRA VR Vol (0x2C) : 1.82 Volts | (ok) | UCR: 1.92 | UNC: 1.90 | UNR: 2.20 | LCR: 1.69 | LNC: 1.71 | LNR: 0.40
EHV VR Vol (0x2D) : 1.80 Volts | (ok) | UCR: 1.90 | UNC: 1.88 | UNR: 2.20 | LCR: 1.70 | LNC: 1.72 | LNR: 0.40
VCCD VR Vol (0x2E) : 1.14 Volts | (ok) | UCR: 1.23 | UNC: 1.21 | UNR: 1.50 | LCR: 1.05 | LNC: 1.06 | LNR: 0.40
FAON VR Vol (0x2F) : 1.05 Volts | (ok) | UCR: 1.09 | UNC: 1.07 | UNR: 1.40 | LCR: 0.90 | LNC: 0.91 | LNR: 0.40
HSC Output Cur (0x30) : 7.50 Amps | (ok) | UCR: 31.96 | UNC: 28.73 | UNR: 39.95 | LCR: NA | LNC: NA | LNR: NA
VCCIN VR Cur (0x31) : 31.80 Amps | (ok) | UCR: 141.18 | UNC: 119.34 | UNR: 180.18 | LCR: NA | LNC: NA | LNR: NA
FIVRA VR Cur (0x32) : 3.30 Amps | (ok) | UCR: 53.01 | UNC: 48.05 | UNR: 70.99 | LCR: NA | LNC: NA | LNR: NA
EHV VR Cur (0x33) : 0.80 Amps | (ok) | UCR: 6.24 | UNC: 5.04 | UNR: 18.00 | LCR: NA | LNC: NA | LNR: NA
VCCD VR Cur (0x34) : 2.80 Amps | (ok) | UCR: 30.02 | UNC: 26.98 | UNR: 42.94 | LCR: NA | LNC: NA | LNR: NA
FAON VR Cur (0x35) : 8.80 Amps | (ok) | UCR: 46.02 | UNC: 42.12 | UNR: 60.06 | LCR: NA | LNC: NA | LNR: NA
CPU PWR (0x38) : 74.00 Watts | (ok) | UCR: NA | UNC: NA | UNR: NA | LCR: NA | LNC: NA | LNR: NA
HSC Input Pwr (0x39) : 88.00 Watts | (ok) | UCR: 399.28 | UNC: 360.22 | UNR: 499.10 | LCR: NA | LNC: NA | LNR: NA
VCCIN VR Pout (0x3A) : 56.00 Watts | (ok) | UCR: 253.80 | UNC: 214.32 | UNR: 324.30 | LCR: NA | LNC: NA | LNR: NA
FIVRA VR Pout (0x3C) : 6.00 Watts | (ok) | UCR: 95.19 | UNC: 86.64 | UNR: 127.68 | LCR: NA | LNC: NA | LNR: NA
EHV VR Pout (0x3D) : 1.00 Watts | (ok) | UCR: 11.25 | UNC: 8.97 | UNR: 32.38 | LCR: NA | LNC: NA | LNR: NA
VCCD VR Pout (0x3E) : 2.00 Watts | (ok) | UCR: 34.32 | UNC: 31.02 | UNR: 49.28 | LCR: NA | LNC: NA | LNR: NA
FAON VR Pout (0x3F) : 8.00 Watts | (ok) | UCR: 49.28 | UNC: 45.08 | UNR: 64.12 | LCR: NA | LNC: NA | LNR: NA
DIMMA PMIC_Pout (0x1E) : 0.62 Watts | (ok) | UCR: 32.20 | UNC: 31.50 | UNR: NA | LCR: NA | LNC: NA | LNR: NA
DIMMC PMIC_Pout (0x1F) : 0.88 Watts | (ok) | UCR: 32.20 | UNC: 31.50 | UNR: NA | LCR: NA | LNC: NA | LNR: NA
DIMMD PMIC_Pout (0x36) : 0.62 Watts | (ok) | UCR: 32.20 | UNC: 31.50 | UNR: NA | LCR: NA | LNC: NA | LNR: NA
DIMME PMIC_Pout (0x37) : 0.62 Watts | (ok) | UCR: 32.20 | UNC: 31.50 | UNR: NA | LCR: NA | LNC: NA | LNR: NA
DIMMG PMIC_Pout (0x42) : 0.50 Watts | (ok) | UCR: 32.20 | UNC: 31.50 | UNR: NA | LCR: NA | LNC: NA | LNR: NA
DIMMH PMIC_Pout (0x47) : 0.50 Watts | (ok) | UCR: 32.20 | UNC: 31.50 | UNR: NA | LCR: NA | LNC: NA | LNR: NA

BIC console

uart:~$ platform sensor list_all

[0x1 ] Unsupported name : tmp75 | access[O] | 4byte_acur_read_success | 25
[0x2 ] Unsupported name : tmp75 | access[O] | 4byte_acur_read_success | 32
[0x3 ] Unsupported name : tmp75 | access[O] | 4byte_acur_read_success | 26
[0xd ] Unsupported name : nvme | access[O] | 4byte_acur_read_success | 22
[0x5 ] Unsupported name : peci | access[O] | 4byte_acur_read_success | 29
[0x14] Unsupported name : peci | access[O] | 4byte_acur_read_success | 71
[0x15] Unsupported name : peci | access[O] | 4byte_acur_read_success | 100
[0x6 ] Unsupported name : peci | access[O] | 4byte_acur_read_success | 27
[0x7 ] Unsupported name : peci | access[O] | 4byte_acur_read_success | 27
[0x9 ] Unsupported name : peci | access[O] | 4byte_acur_read_success | 27
[0xa ] Unsupported name : peci | access[O] | 4byte_acur_read_success | 27
[0xb ] Unsupported name : peci | access[O] | 4byte_acur_read_success | 27
[0xc ] Unsupported name : peci | access[O] | 4byte_acur_read_success | 27
[0x38] Unsupported name : peci | access[O] | 4byte_acur_read_success | 74
[0x20] Unsupported name : adc | access[O] | 4byte_acur_read_success | 42336268
[0x22] Unsupported name : adc | access[O] | 4byte_acur_read_success | 22151171
[0x24] Unsupported name : adc | access[O] | 4byte_acur_read_success | 3407873
[0x21] Unsupported name : adc | access[O] | 4byte_acur_read_success | 3538947
[0x25] Unsupported name : adc | access[O] | 4byte_acur_read_success | 61407236
[0x26] Unsupported name : adc | access[O] | 4byte_acur_read_success | 34013196
[0x27] Unsupported name : adc | access[O] | 4byte_acur_read_success | 12320769
[0x28] Unsupported name : adc | access[O] | 4byte_acur_read_success | 19922947
[0x23] Unsupported name : adc | access[O] | 4byte_acur_read_success | 51707905
[0x2e] Unsupported name : isl69259 | access[O] | 4byte_acur_read_success | 9306113
[0x2f] Unsupported name : isl69259 | access[O] | 4byte_acur_read_success | 3276801
[0x2d] Unsupported name : isl69259 | access[O] | 4byte_acur_read_success | 52428801
[0x2a] Unsupported name : isl69259 | access[O] | 4byte_acur_read_success | 50593793
[0x2c] Unsupported name : isl69259 | access[O] | 4byte_acur_read_success | 53608449
[0x34] Unsupported name : isl69259 | access[O] | 4byte_acur_read_success | 52428802
[0x35] Unsupported name : isl69259 | access[O] | 4byte_acur_read_success | 52428808
[0x33] Unsupported name : isl69259 | access[O] | 4byte_acur_read_success | 52428800
[0x31] Unsupported name : isl69259 | access[O] | 4byte_acur_read_success | 52428831
[0x32] Unsupported name : isl69259 | access[O] | 4byte_acur_read_success | 19660803
[0x12] Unsupported name : isl69259 | access[O] | 4byte_acur_read_success | 33
[0x13] Unsupported name : isl69259 | access[O] | 4byte_acur_read_success | 36
[0x11] Unsupported name : isl69259 | access[O] | 4byte_acur_read_success | 31
[0xf ] Unsupported name : isl69259 | access[O] | 4byte_acur_read_success | 40
[0x10] Unsupported name : isl69259 | access[O] | 4byte_acur_read_success | 37
[0x3e] Unsupported name : isl69259 | access[O] | 4byte_acur_read_success | 2
[0x3f] Unsupported name : isl69259 | access[O] | 4byte_acur_read_success | 8
[0x3d] Unsupported name : isl69259 | access[O] | 4byte_acur_read_success | 1
[0x3a] Unsupported name : isl69259 | access[O] | 4byte_acur_read_success | 56
[0x3c] Unsupported name : isl69259 | access[O] | 4byte_acur_read_success | 6
[0x4 ] Unsupported name : pch | access[O] | 4byte_acur_read_success | 38
[0x1e] Unsupported name : pmic | access[O] | 4byte_acur_read_success | 57344000
[0x1f] Unsupported name : pmic | access[O] | 4byte_acur_read_success | 49152000
[0x36] Unsupported name : pmic | access[O] | 4byte_acur_read_success | 32768000
[0x37] Unsupported name : pmic | access[O] | 4byte_acur_read_success | 40960000
[0x42] Unsupported name : pmic | access[O] | 4byte_acur_read_success | 40960000
[0x47] Unsupported name : pmic | access[O] | 4byte_acur_read_success | 32768000
[0xe ] Unsupported name : mp5990 | access[O] | 4byte_acur_read_success | 33
[0x50] Unsupported name : mp5990 | access[O] | init_status | 0
[0x30] Unsupported name : mp5990 | access[O] | 4byte_acur_read_success | 7
[0x39] Unsupported name : mp5990 | access[O] | 4byte_acur_read_success | 88

[get_sensor_reading] fail to find sensor info in config table, sensor_num: 0x29
[sensor_poll_handler] fail to find sensor SDR info, sensor number: 0x50

DelphineChiu · 2022-06-21T02:00:10Z

Dependency: #339

facebook-github-bot · 2022-06-21T21:27:21Z

@GoldenBug has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot · 2022-06-22T00:43:10Z

@DelphineChiu has updated the pull request. You must reimport the pull request before landing.

LoraLin1 · 2022-06-22T00:46:30Z

Hi @GoldenBug
We have fixed the conflict and do the forced update.
Please review it. Thanks.

facebook-github-bot · 2022-06-22T22:24:26Z

@GoldenBug has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

GoldenBug

Many changes more than I requested but if we are going to change full_sdr_table to a pointer instead of a statically allocated array then we need to check to make sure full_sdr_table isn't null everywhere we want to use it.

GoldenBug · 2022-06-22T23:33:32Z

-__weak void pal_fix_full_sdr_table(void)
+__weak void pal_extend_full_sdr_table(void)
 {
-	printf("Function %s is not implemented\n", __func__);


I think we should keep this here or print out the fact that it's a no-op

@GoldenBug For the BIC which doesn't need to run into this pal function, for example, RF/WF BIC, I think this messages will confuse and think about something wrong. BMC firmware common code also doesn't add the messages in common layer.

Would like to get your input to decide if we need to keep this message?

GoldenBug · 2022-06-22T23:44:07Z

-			}
+	uint8_t i = 0;
+	for (i = 0; i < sdr_count; ++i) {
+		if (sensor_num == full_sdr_table[i].sensor_num) {


If we are going to change full_sdr_table to a pointer, then we need to check that it isn't null everywhere we use it.

Hi @GoldenBug
We add the judgment condition for checking NULL pointer and fix the conflict.
Please review it. Thanks.

GoldenBug · 2022-06-22T23:47:51Z

-		printf("add sensor num [0x%x] - sensor already exists\n", add_item.sensor_num);
+	uint8_t index = get_sdr_index(add_item.sensor_num);
+	if (index != SENSOR_NUM_MAX) {
+		memcpy(&full_sdr_table[index], &add_item, sizeof(SDR_Full_sensor));


If we are going to change full_sdr_table to a pointer, then we need to check that it isn't null everywhere we use it.

Hi @GoldenBug
We add the judgment condition for checking NULL pointer and fix the conflict.
Please review it. Thanks.

facebook-github-bot · 2022-06-23T00:55:29Z

@DelphineChiu has updated the pull request. You must reimport the pull request before landing.

facebook-github-bot · 2022-06-23T01:12:58Z

@GoldenBug has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[Features] - Reference to facebook#355 / facebook#339 / facebook#349 . [Fix] [Note]

Summary: - Based on facebook#339 and facebook#349

facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 21, 2022

LoraLin1 force-pushed the fby3.5-Fix_sensor_monitor_memcpy_fail_issue branch from 3869d69 to 39137f8 Compare June 22, 2022 00:43

GoldenBug suggested changes Jun 22, 2022

View reviewed changes

LoraLin1 force-pushed the fby3.5-Fix_sensor_monitor_memcpy_fail_issue branch from 39137f8 to 19c210c Compare June 23, 2022 00:55

facebook-github-bot closed this in 8e223c3 Jun 23, 2022

MouchenHung-QUANTA added a commit to MouchenHung-QUANTA/OpenBIC that referenced this pull request Jun 27, 2022

wc: mb: Follow some pr from other projects

845c8cf

[Features] - Reference to facebook#355 / facebook#339 / facebook#349 . [Fix] [Note]

MouchenHung-QUANTA added a commit to MouchenHung-QUANTA/OpenBIC that referenced this pull request Jun 27, 2022

wc: mb: Modify some function based on some commits

6e8ff07

Summary: - Based on facebook#339 and facebook#349

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fby3.5: common:Fix sensor monitor memcpy fail causing BIC crash issue#349

fby3.5: common:Fix sensor monitor memcpy fail causing BIC crash issue#349
DelphineChiu wants to merge 1 commit into
facebook:mainfrom
Wiwynn:fby3.5-Fix_sensor_monitor_memcpy_fail_issue

DelphineChiu commented Jun 21, 2022

DelphineChiu commented Jun 21, 2022

facebook-github-bot commented Jun 21, 2022

facebook-github-bot commented Jun 22, 2022

LoraLin1 commented Jun 22, 2022

facebook-github-bot commented Jun 22, 2022

GoldenBug left a comment

GoldenBug Jun 22, 2022

DelphineChiu Jun 23, 2022 •

edited

Loading

GoldenBug Jun 22, 2022

LoraLin1 Jun 23, 2022

GoldenBug Jun 22, 2022

LoraLin1 Jun 23, 2022 •

edited

Loading

facebook-github-bot commented Jun 23, 2022

facebook-github-bot commented Jun 23, 2022

Labels

4 participants

Uh oh!

Conversation

DelphineChiu commented Jun 21, 2022

error case error handling

[BIC console] uart:~$ platform sensor list_all

uart:~$ platform sensor list_all

DelphineChiu commented Jun 21, 2022

facebook-github-bot commented Jun 21, 2022

facebook-github-bot commented Jun 22, 2022

LoraLin1 commented Jun 22, 2022

facebook-github-bot commented Jun 22, 2022

GoldenBug left a comment

Choose a reason for hiding this comment

GoldenBug Jun 22, 2022

Choose a reason for hiding this comment

DelphineChiu Jun 23, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

GoldenBug Jun 22, 2022

Choose a reason for hiding this comment

LoraLin1 Jun 23, 2022

Choose a reason for hiding this comment

GoldenBug Jun 22, 2022

Choose a reason for hiding this comment

LoraLin1 Jun 23, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

facebook-github-bot commented Jun 23, 2022

facebook-github-bot commented Jun 23, 2022

Labels

4 participants

[BIC console]
uart:~$ platform sensor list_all

DelphineChiu Jun 23, 2022 •

edited

Loading

LoraLin1 Jun 23, 2022 •

edited

Loading