Skip to content

fby35: hd: Modify battery voltage poll time#435

Closed
Yi-Shum wants to merge 1 commit into
facebook:mainfrom
Yi-Shum:fby3.5-hd-modify_battery_voltage_poll_time
Closed

fby35: hd: Modify battery voltage poll time#435
Yi-Shum wants to merge 1 commit into
facebook:mainfrom
Yi-Shum:fby3.5-hd-modify_battery_voltage_poll_time

Conversation

@Yi-Shum

@Yi-Shum Yi-Shum commented Jul 26, 2022

Copy link
Copy Markdown
Collaborator

Summary:

  • Set the polling time of battery voltage to 1 hour.
  • Modify the polling time check function.

Test plan:

  • Build code: PASS
Summary:
- Set the polling time of battery voltage to 1 hour.
- Modify the polling time check function.

Test plan:
- Build code: PASS
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 26, 2022
@facebook-github-bot

Copy link
Copy Markdown
Contributor

@GoldenBug has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot pushed a commit that referenced this pull request Aug 3, 2022
Summary:
- Add error callback function to handle failures when accessing apml.
- Support AMD CPU temperature and power sensor.
- Support DIMM temperature and power sensor.

Dependency: #435

Pull Request resolved: #436

Test Plan:
- Build Code: PASS
- Sensor Read: PASS

Log:
```
root@bmc-oob:~# sensor-util slot1
...
CPU Temp                     (0x4) :   61.75 C     | (ok)
DIMMA Temp                   (0x5) :   31.75 C     | (ok)
DIMMB Temp                   (0x6) :   32.00 C     | (ok)
DIMMC Temp                   (0x7) :   33.00 C     | (ok)
DIMME Temp                   (0x8) :   32.25 C     | (ok)
DIMMG Temp                   (0x9) :   34.00 C     | (ok)
DIMMH Temp                   (0xA) :   34.75 C     | (ok)
DIMMI Temp                   (0xB) :   34.75 C     | (ok)
DIMMK Temp                   (0xC) :   33.75 C     | (ok)
...
CPU Pwr                      (0x32) :  139.14 Watts | (ok)
DIMMA Pwr                    (0x33) :    0.50 Watts | (ok)
DIMMB Pwr                    (0x34) :    0.50 Watts | (ok)
DIMMC Pwr                    (0x35) :    1.62 Watts | (ok)
DIMME Pwr                    (0x36) :    0.50 Watts | (ok)
DIMMG Pwr                    (0x37) :    0.88 Watts | (ok)
DIMMH Pwr                    (0x38) :    0.75 Watts | (ok)
DIMMI Pwr                    (0x39) :    0.88 Watts | (ok)
DIMMK Pwr                    (0x3A) :    0.75 Watts | (ok)
```

Reviewed By: williamspatrick

Differential Revision: D38228684

Pulled By: garnermic

fbshipit-source-id: 818cac056aadffb5f9bcd63cbd171fe74ef685a3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

2 participants