Skip to content

fby3.5: hd: Support apml sensor#436

Closed
Yi-Shum wants to merge 5 commits into
facebook:mainfrom
Yi-Shum:fby3.5-hd-support_apml_sensor
Closed

fby3.5: hd: Support apml sensor#436
Yi-Shum wants to merge 5 commits into
facebook:mainfrom
Yi-Shum:fby3.5-hd-support_apml_sensor

Conversation

@Yi-Shum

@Yi-Shum Yi-Shum commented Jul 26, 2022

Copy link
Copy Markdown
Collaborator

Summary:

  • Add error callback function to handle failures when accessing apml.
  • Support AMD CPU temperature and power sensor.
  • Support DIMM temperature and power sensor.

Dependency: #435

Test Plan:

  • Build Code: PASS
  • Sensor Read: PASS

Log:

root@bmc-oob:~# sensor-util slot1
...
CPU Temp                     (0x4) :   61.75 C     | (ok)
DIMMA Temp                   (0x5) :   31.75 C     | (ok)
DIMMB Temp                   (0x6) :   32.00 C     | (ok)
DIMMC Temp                   (0x7) :   33.00 C     | (ok)
DIMME Temp                   (0x8) :   32.25 C     | (ok)
DIMMG Temp                   (0x9) :   34.00 C     | (ok)
DIMMH Temp                   (0xA) :   34.75 C     | (ok)
DIMMI Temp                   (0xB) :   34.75 C     | (ok)
DIMMK Temp                   (0xC) :   33.75 C     | (ok)
...
CPU Pwr                      (0x32) :  139.14 Watts | (ok)
DIMMA Pwr                    (0x33) :    0.50 Watts | (ok)
DIMMB Pwr                    (0x34) :    0.50 Watts | (ok)
DIMMC Pwr                    (0x35) :    1.62 Watts | (ok)
DIMME Pwr                    (0x36) :    0.50 Watts | (ok)
DIMMG Pwr                    (0x37) :    0.88 Watts | (ok)
DIMMH Pwr                    (0x38) :    0.75 Watts | (ok)
DIMMI Pwr                    (0x39) :    0.88 Watts | (ok)
DIMMK Pwr                    (0x3A) :    0.75 Watts | (ok)
Yi-Shum added 2 commits July 26, 2022 09:27
Summary:
- Set the polling time of battery voltage to 1 hour.
- Modify the polling time check function.

Test plan:
- Build code: PASS
Summary:
- Add error callback function to handle failures when accessing apml.
- Support AMD CPU temperature and power sensor.
- Support DIMM temperature and power sensor.

Test Plan:
- Build Code: PASS
- Sensor Read: PASS

Log:
```
root@bmc-oob:~# sensor-util slot1
...
CPU Temp                     (0x4) :   61.75 C     | (ok)
DIMMA Temp                   (0x5) :   31.75 C     | (ok)
DIMMB Temp                   (0x6) :   32.00 C     | (ok)
DIMMC Temp                   (0x7) :   33.00 C     | (ok)
DIMME Temp                   (0x8) :   32.25 C     | (ok)
DIMMG Temp                   (0x9) :   34.00 C     | (ok)
DIMMH Temp                   (0xA) :   34.75 C     | (ok)
DIMMI Temp                   (0xB) :   34.75 C     | (ok)
DIMMK Temp                   (0xC) :   33.75 C     | (ok)
...
CPU Pwr                      (0x32) :  139.14 Watts | (ok)
DIMMA Pwr                    (0x33) :    0.50 Watts | (ok)
DIMMB Pwr                    (0x34) :    0.50 Watts | (ok)
DIMMC Pwr                    (0x35) :    1.62 Watts | (ok)
DIMME Pwr                    (0x36) :    0.50 Watts | (ok)
DIMMG Pwr                    (0x37) :    0.88 Watts | (ok)
DIMMH Pwr                    (0x38) :    0.75 Watts | (ok)
DIMMI Pwr                    (0x39) :    0.88 Watts | (ok)
DIMMK Pwr                    (0x3A) :    0.75 Watts | (ok)
```
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 26, 2022
@facebook-github-bot

Copy link
Copy Markdown
Contributor

@GoldenBug has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot

Copy link
Copy Markdown
Contributor

@Yi-Shum has updated the pull request. You must reimport the pull request before landing.

@Yi-Shum

Yi-Shum commented Jul 29, 2022

Copy link
Copy Markdown
Collaborator Author

Hi @GoldenBug ,
I have fixed the conflict.
Please review again, thank you

@facebook-github-bot

Copy link
Copy Markdown
Contributor

@Yi-Shum has updated the pull request. You must reimport the pull request before landing.

@Yi-Shum

Yi-Shum commented Aug 1, 2022

Copy link
Copy Markdown
Collaborator Author

Hi @GoldenBug ,
I have fixed the build error.
Please review again, thank you.

@facebook-github-bot

Copy link
Copy Markdown
Contributor

@garnermic has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

2 participants