fby3: vf: modify plat_class & plat_gpio#448
Conversation
Summary: - Add plat_hwmon.c - Add plat_m2 - Add plat_power_seq - Modify sensor table Test plan: - Build code: PASS
Summary: - Add plat_isr - Add plat_led - Add plat_util Test plan: - Build code : This will be tested after a few commit.
Summary: - Modify plat_class - Modify plat_gpio Test plan: - Build code : This will be tested after a few commit.
facebook-github-bot
added
the
CLA Signed
garnermic
left a comment
garnermic
left a comment
There was a problem hiding this comment.
Few minor issues to resolve.
| case RAINBOW_FALLS: | ||
| system_board_id = RAINBOW_FALLS; | ||
| break; | ||
| case WAIMANO_FALLS: |
There was a problem hiding this comment.
Please remove WF code as it will not be needed.
| gpio_name_to_num(HSC_SEL_ID1) \ | ||
| gpio_name_to_num(HSC_SEL_ID0) | ||
| #define name_gpioA \ | ||
| gpio_name_to_num(IRQ_P12V_E1S_3_FLT_N) gpio_name_to_num(IRQ_P12V_E1S_2_FLT_N) \ |
There was a problem hiding this comment.
Please reformat to make reading easier for the GPIO #defines.
| } | ||
|
|
||
| buf = msg.data[0]; | ||
| buf = (buf & ~(1 << prsnt_ofs)) | (!val << prsnt_ofs); |
There was a problem hiding this comment.
Please fix the linter error.
| case SSD_STOP_BLINK: | ||
| stop_blink_timer(idx); | ||
| break; | ||
| } |
There was a problem hiding this comment.
Please add a default case statement.
| fm_p3v3_sw_en(idx, en_3v3); | ||
| } else if (force_ctl_3v3 && (enable == 1)) { | ||
| is_force_disable_3v3[idx] = 0; | ||
| } |
There was a problem hiding this comment.
Please add an else statement to handle any fall through from the if/else-if statements.
|
|
||
| uint8_t device_all_power_set(uint8_t idx, uint8_t set_val) | ||
| { | ||
| uint8_t is_on = (set_val & DEV_PWR_ON ? 1 : 0); |
There was a problem hiding this comment.
Please fix the linter issues in lines 227, 228 and 229.
|
@garnermic has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Summary: - Modification based on comments 20220808 - Add USB configure - Modify pwrdis pin to push-pull Test plan: - Build code : This will be tested after a few commit.
|
@HungYi-Li has updated the pull request. You must reimport the pull request before landing. |
3 participants
Summary:
Test plan:
Dependency: #447