Skip to content

fby3: vf: Modification based on comments 20220808#469

Closed
HungYi-Li wants to merge 4 commits into
facebook:mainfrom
HungYi-Li:fby3-vf-Modification_comments_20220808
Closed

fby3: vf: Modification based on comments 20220808#469
HungYi-Li wants to merge 4 commits into
facebook:mainfrom
HungYi-Li:fby3-vf-Modification_comments_20220808

Conversation

@HungYi-Li

Copy link
Copy Markdown
Contributor

Summary:

  • Modification based on comments 20220808
  • Add USB configure
  • Modify pwrdis pin to push-pull

Test plan:

  • Build code : This will be tested after a few commit.
Summary:
- Add plat_hwmon.c
- Add plat_m2
- Add plat_power_seq
- Modify sensor table

Test plan:
- Build code: PASS
Summary:
- Add plat_isr
- Add plat_led
- Add plat_util

Test plan:
- Build code : This will be tested after a few commit.
Summary:
- Modify plat_class
- Modify plat_gpio

Test plan:
- Build code : This will be tested after a few commit.
Summary:
- Modification based on comments 20220808
- Add USB configure
- Modify pwrdis pin to push-pull

Test plan:
- Build code : This will be tested after a few commit.
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 8, 2022
@HungYi-Li

Copy link
Copy Markdown
Contributor Author

Hi @garnermic ,
this pull request fix #446 #447 #448 comments.
Please review again, thank you

@facebook-github-bot

Copy link
Copy Markdown
Contributor

@GoldenBug has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@GoldenBug

Copy link
Copy Markdown
Contributor

Please Fix the comments on the PRs that request the changes.
We should not submit extra PRs for fixing comments.

@HungYi-Li

Copy link
Copy Markdown
Contributor Author

add commit on #448 , close this.

@HungYi-Li HungYi-Li closed this Aug 9, 2022
facebook-github-bot pushed a commit that referenced this pull request Aug 12, 2022
Summary:
- Reformat based on expansion_board.c
- Add oem_1s_handler 0x34,0x39,0x3A
- Add usb configure
- Fix ina231 init args
- Fix sdr P12V_STBY to P1V2_STBY

Pull Request resolved: #470

Test Plan:
- Build code : Pass

Dependency: #469

Reviewed By: peterdelevoryas

Differential Revision: D38518280

Pulled By: GoldenBug

fbshipit-source-id: 9c04524cd57c82cba92115a45a24bb377d2ef2b6
@HungYi-Li HungYi-Li deleted the fby3-vf-Modification_comments_20220808 branch April 15, 2025 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

3 participants