Skip to content

[Nexthop][NPI] "asic_config_v3" part 2 - JSON schemas and validation script#1199

Closed
marif-nexthop wants to merge 1 commit into
facebook:mainfrom
nexthop-ai:marif.fboss-asic-config-v3-2
Closed

[Nexthop][NPI] "asic_config_v3" part 2 - JSON schemas and validation script#1199
marif-nexthop wants to merge 1 commit into
facebook:mainfrom
nexthop-ai:marif.fboss-asic-config-v3-2

Conversation

@marif-nexthop

@marif-nexthop marif-nexthop commented May 14, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Pre-submission checklist

  • I've ran the linters locally and fixed lint errors related to the files I modified in this PR. You can install the linters by running pip install -r requirements-dev.txt && pre-commit install
  • pre-commit run

Summary

Implements asic_config_v3 design.

Add strict JSON schemas for the Broadcom XGS ASIC config, the platform config, and the shared vendor common JSONs. Include a validation script that scans the asic_config_v3 directory tree and validates every matching file against its schema.

Test Plan

Install required package python3 -m pip install jsonschema
Run schema validation

python3 fboss/lib/asic_config_v3/validation/validate_asic_configs.py
Vendor common configs (vendor_common.schema.json):
  No files found.
Broadcom XGS ASIC configs (broadcom_xgs_asic_config.schema.json):
  No files found.
Platform configs (platform_config.schema.json):
  No files found.
0 passed, 0 failed

Note: There are no json files to validate at this point. Will be added in the next PR.

This PR is created on top of

so it contains diff from these PRs. When these PRs will merge, this PR will have a shorter diff.
@marif-nexthop marif-nexthop requested review from a team as code owners May 14, 2026 19:01
@meta-cla meta-cla Bot added the CLA Signed label May 14, 2026
@marif-nexthop marif-nexthop force-pushed the marif.fboss-asic-config-v3-2 branch from 5927fc1 to 8289e96 Compare May 21, 2026 04:06
This was referenced May 21, 2026
Closed
Closed
@marif-nexthop marif-nexthop force-pushed the marif.fboss-asic-config-v3-2 branch 2 times, most recently from 01bf56e to f7f4e06 Compare May 26, 2026 05:51
This was referenced May 28, 2026
Open
Open
@marif-nexthop marif-nexthop force-pushed the marif.fboss-asic-config-v3-2 branch 3 times, most recently from e070735 to 5219eef Compare June 17, 2026 20:08
joseph5wu
joseph5wu reviewed Jun 18, 2026
View reviewed changes
Comment thread fboss/lib/asic_config_v3/gen.py
return platforms


def generate_all_asic_configs() -> None:

@joseph5wu joseph5wu Jun 18, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also support generate asic config based on the specific platform?
This will be helpful for the users who are working on a specific platform and don't have to wait to generate other unrelated platforms.
We could support specific platform asic config gen logic in the future PR
But eventually fboss will generate all configs.

@marif-nexthop marif-nexthop Jun 18, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After rebasing on the latest main, the file gen.py is not part of this PR (it was of the base PR) but I have noted your suggestion to add the feature to generate platform specific asic_config. Thanks.
@marif-nexthop
"asic_config_v3" part 2 - JSON schemas and validation script
9198c4a 
Add strict JSON schemas for the Broadcom `XGS` ASIC config, the platform
config, and the shared vendor common JSONs. Include a validation script
that scans the `asic_config_v3` directory tree and validates every
matching file
against its schema.
@marif-nexthop marif-nexthop force-pushed the marif.fboss-asic-config-v3-2 branch from 5219eef to 9198c4a Compare June 18, 2026 20:06
@meta-codesync

meta-codesync Bot commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

@joseph5wu has imported this pull request. If you are a Meta employee, you can view this in D109061608.
@meta-codesync meta-codesync Bot closed this in d0689fe Jun 19, 2026
@meta-codesync meta-codesync Bot added the Merged label Jun 19, 2026
@meta-codesync

meta-codesync Bot commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

@joseph5wu merged this pull request in d0689fe.
@rabbit-nexthop rabbit-nexthop deleted the marif.fboss-asic-config-v3-2 branch June 19, 2026 08:16
meta-codesync Bot pushed a commit that referenced this pull request Jun 24, 2026
@marif-nexthop @meta-codesync
"asic_config_v3" part 3 - Broadcom XGS generator and vendor data (#1220)
80b6b8e 
Summary:
**Pre-submission checklist**
- [x] I've ran the linters locally and fixed lint errors related to the files I modified in this PR. You can install the linters by running `pip install -r requirements-dev.txt && pre-commit install`
- [x] `pre-commit run`

Implements `asic_config_v3` design.

In this PR, introduce the `asic_config_v3` Broadcom XGS generator class along with the shared XGS SDK and SAI common JSONs, and per-ASIC JSONs for Tomahawk 5 and Tomahawk 6. Registered both ASICs in gen.py's `_GENERATOR_REGISTRY` and extend the CMake target SOURCES with the new generator file.

After this commit the `asic_config_v3` package can generate XGS configs for any platform whose `asic_config.json` references `tomahawk5` or `tomahawk6`.

No platforms are registered yet but will be added in the following PRs.

Pull Request resolved: #1220

Test Plan:
Running `fboss/lib/asic_config_v3/run-helper.sh` is no-op as there are no platforms added yet. The platforms will be added in the following PRs.

Schema validation passes for all files.
```
$ python3 ./fboss/lib/asic_config_v3/validation/validate_asic_configs.py
Vendor common configs (vendor_common.schema.json):
  vendors/broadcom/xgs/sai_common.json: PASSED
  vendors/broadcom/xgs/sdk_common.json: PASSED

Broadcom XGS ASIC configs (broadcom_xgs_asic_config.schema.json):
  vendors/broadcom/xgs/asics/tomahawk5.json: PASSED
  vendors/broadcom/xgs/asics/tomahawk6.json: PASSED

Platform configs (platform_config.schema.json):
  No files found.
4 passed, 0 failed
```

----

**This PR is created on top of**
- #1131
- #1149
- #1198
- #1199

**so it contains diff from these PRs. When these PRs will merge, this PR will have a shorter diff.**

Reviewed By: daiwei1983

Differential Revision: D109338944

Pulled By: joseph5wu

fbshipit-source-id: 454fd40e05ba8504a5929ceee1efdd328e8c2b68
meta-codesync Bot pushed a commit that referenced this pull request Jun 25, 2026
@marif-nexthop @meta-codesync
"asic_config_v3" part 4 - Add platform configurations (#1221)
e05feac 
Summary:
**Pre-submission checklist**
- [x] I've ran the linters locally and fixed lint errors related to the files I modified in this PR. You can install the linters by running `pip install -r requirements-dev.txt && pre-commit install`
- [x] `pre-commit run`

Implements `asic_config_v3` design.

In this PR, add platform configurations for the four core XGS platforms which were originally generated by `asic_config_v2`:
- montblanc
- icecube800bc
- icecube800banw
- wedge800bact

After this commit the `asic_config_v3` generator produces four XGS output files which should be identical to the `asic_config_v2` output.

**Note: After review comments, changed variant name `base` to `default`.**
v2: montblanc_base.yml
v3: montblanc_defaultyml

v2: wedge800bact_base.yml
v3: wedge800bact_default.yml

Pull Request resolved: #1221

Test Plan:
Ran `fboss/lib/asic_config_v3/run-helper.sh` to generate `asic_config_v3` output:
```
Completed build for fboss-asic-config-v3-gen.GEN_PY_EXE
...
Writing to /var/FBOSS/fboss/fboss/lib/asic_config_v3/generated_asic_configs/icecube800banw_default.yml
...
Writing to /var/FBOSS/fboss/fboss/lib/asic_config_v3/generated_asic_configs/wedge800bact_default.yml
...
Writing to /var/FBOSS/fboss/fboss/lib/asic_config_v3/generated_asic_configs/montblanc_default.yml
...
Writing to /var/FBOSS/fboss/fboss/lib/asic_config_v3/generated_asic_configs/icecube800bc_default.yml
Configs have been written to specified output directory

$ ls -1 fboss/lib/asic_config_v3/generated_asic_configs
icecube800banw_default.yml
icecube800bc_default.yml
montblanc_default.yml
wedge800bact_default.yml
```

The generated output files are byte-identical with `asic_config_v2`
output
```
$ diff -r fboss/lib/asic_config_v3/generated_asic_configs/ fboss/lib/asic_config_v2/generated_asic_configs/
<no diff>
```

Schema validation also passed for all files
```
$ python3 ./fboss/lib/asic_config_v3/validation/validate_asic_configs.py
Vendor common configs (vendor_common.schema.json):
  vendors/broadcom/xgs/sai_common.json: PASSED
  vendors/broadcom/xgs/sdk_common.json: PASSED

Broadcom XGS ASIC configs (broadcom_xgs_asic_config.schema.json):
  vendors/broadcom/xgs/asics/tomahawk5.json: PASSED
  vendors/broadcom/xgs/asics/tomahawk6.json: PASSED

Platform configs (platform_config.schema.json):
  platforms/icecube800banw/asic_config.json: PASSED
  platforms/icecube800bc/asic_config.json: PASSED
  platforms/montblanc/asic_config.json: PASSED
  platforms/wedge800bact/asic_config.json: PASSED

8 passed, 0 failed
```

**This PR is created on top of**
- #1131
- #1149
- #1198
- #1199
- #1220

**so it contains diff from these PRs. When these PRs will merge, this PR will have a shorter diff.**

Reviewed By: daiwei1983

Differential Revision: D109735092

Pulled By: joseph5wu

fbshipit-source-id: 936409ca309759f8feab3c29046ca0d8ad645189
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment