Skip to content

【igl nanovg part-2】Core Implementation#217

Closed
vinsentli wants to merge 18 commits into
facebook:mainfrom
vinsentli:igl_nanovg_part2_iglu_nanovg
Closed

【igl nanovg part-2】Core Implementation#217
vinsentli wants to merge 18 commits into
facebook:mainfrom
vinsentli:igl_nanovg_part2_iglu_nanovg

Conversation

@vinsentli

@vinsentli vinsentli commented Nov 26, 2024

Copy link
Copy Markdown
Contributor

This is the core implementation.

And this is a prerequisite pull request for igl nanovg(#213).

@vinsentli vinsentli changed the title iglu | nanovg | implement Nov 26, 2024
@vinsentli vinsentli changed the title 【igl nanovg part-2】iglu | nanovg | implement Nov 26, 2024
@vinsentli vinsentli marked this pull request as draft November 28, 2024 04:05
@vinsentli vinsentli changed the title 【igl nanovg part-2】iglu | nanovg | Implementation Nov 29, 2024
@vinsentli vinsentli changed the title 【igl nanovg part-2】iglu | nanovg | Core Implementation Nov 29, 2024
@vinsentli vinsentli marked this pull request as ready for review November 29, 2024 12:59
@vinsentli vinsentli marked this pull request as draft November 29, 2024 13:01
@vinsentli vinsentli marked this pull request as ready for review December 2, 2024 02:03
@vinsentli vinsentli marked this pull request as draft December 2, 2024 02:03
@vinsentli vinsentli marked this pull request as ready for review December 2, 2024 03:30

@corporateshark corporateshark left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a new CMake option IGLU_WITH_NANOVG (default: off) to control this new IGLU module.

This new option should be declared inside the root file CMakeLists.txt.

@vinsentli

Copy link
Copy Markdown
Contributor Author

Please add a new CMake option IGLU_WITH_NANOVG (default: off) to control this new IGLU module.

This new option should be declared inside the root file CMakeLists.txt.

done

Comment thread IGLU/CMakeLists.txt Outdated
…here the total size of uniform buffers cannot exceed 64K.
@facebook-github-bot

Copy link
Copy Markdown
Contributor

@corporateshark has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@corporateshark

Copy link
Copy Markdown
Contributor

After internal discussion, we have decided not to add NanoVG as an IGLU module due to its incompatibility with our contribution guidelines. One of our primary design objectives is to minimize the number of dependencies within IGL itself. We will only accept new third-party dependencies if they are crucial to the core functionality of the IGL project. This ensures that we avoid creating unnecessary burdens on our team for future support and testing.

You are welcome to create your own standalone wrapper for NanoVG. This can be a separate repository for the NanoVG IGLU module, where our IGL repository is treated as a submodule. We are more than happy to discuss IGL bug fixes and issues related to it.

Before creating new PRs, please review our contributor guidelines and consider opening a GitHub issue first to determine whether your PR can be potentially accepted.

@vinsentli

Copy link
Copy Markdown
Contributor Author

It is OK.

@vinsentli vinsentli deleted the igl_nanovg_part2_iglu_nanovg branch June 15, 2026 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

3 participants