【igl nanovg part-4】Android : add seperate nanovg sample project#218
Closed
vinsentli wants to merge 12 commits into
Closed
【igl nanovg part-4】Android : add seperate nanovg sample project#218vinsentli wants to merge 12 commits into
vinsentli wants to merge 12 commits into
Conversation
vinsentli
changed the title
corporateshark
requested changes
Nov 29, 2024
corporateshark
left a comment
corporateshark
left a comment
Contributor
There was a problem hiding this comment.
There should be a separate NanoVG sample which does this. We cannot change SampleActivity.java like that.
Contributor
Author
|
This is a general operation,not only for nanovg sample. |
Contributor
All existing samples do not require this behavior and we do not want to touch the SD card like that. |
vinsentli
changed the title
vinsentli
changed the title
corporateshark
requested changes
Dec 22, 2024
vinsentli
changed the title
Contributor
vinsentli
deleted the
igl_nanovg_part2_android_copy_assert_file_to_sdcard
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a prerequisite pull request for igl nanovg(#213).