Skip to content
This repository was archived by the owner on Mar 1, 2026. It is now read-only.

Add ddst_dict_init api support for rocksdb dd#1297

Open
sunshine-Chun wants to merge 1 commit into
facebook:fb-mysql-8.0.28from
sunshine-Chun:fb-mysql-8.0.28-dd-api2
Open

Add ddst_dict_init api support for rocksdb dd#1297
sunshine-Chun wants to merge 1 commit into
facebook:fb-mysql-8.0.28from
sunshine-Chun:fb-mysql-8.0.28-dd-api2

Conversation

@sunshine-Chun

@sunshine-Chun sunshine-Chun commented Apr 24, 2023

Copy link
Copy Markdown
Contributor

Summary: Add ddst_dict_init api support for rocksdb dd

Test Plan: Test locally, not crush....

Reviewers:

Subscribers:

Tasks:

Tags:
laurynas-biveinis
laurynas-biveinis reviewed Apr 25, 2023
View reviewed changes
Comment thread storage/rocksdb/ha_rocksdb.cc Outdated
Comment thread storage/rocksdb/ha_rocksdb.cc Outdated
Comment thread storage/rocksdb/ha_rocksdb.cc
laurynas-biveinis
laurynas-biveinis reviewed Apr 25, 2023
View reviewed changes
Comment thread storage/rocksdb/ha_rocksdb.cc Outdated
@sunshine-Chun sunshine-Chun force-pushed the fb-mysql-8.0.28-dd-api2 branch from 66fa355 to 4fddbc6 Compare April 25, 2023 18:55
laurynas-biveinis
laurynas-biveinis reviewed Apr 26, 2023
View reviewed changes
Comment thread storage/rocksdb/rdb_global.h Outdated
Comment thread storage/rocksdb/ha_rocksdb.cc Outdated
laurynas-biveinis
laurynas-biveinis reviewed Apr 27, 2023
View reviewed changes
Comment thread storage/rocksdb/ha_rocksdb.cc Outdated

static Plugin_tablespace dd_space(rocksdb_dd_space_name, "", "", "",
rocksdb_hton_name);
tablespaces->push_back(&dd_space);

@laurynas-biveinis laurynas-biveinis Apr 27, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On a second thought, tablespaces are purely InnoDB concept. So nothing should be added here?

@luqun luqun Apr 27, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think DD expect mysql namespace always exists.. Let me find related code in a while..

@laurynas-biveinis laurynas-biveinis Apr 28, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current DD layer assumes it does, but I am patching it out in my prototype.
I am concerned about pretending something exists when MyRocks does not even support the concept of it.
@sunshine-Chun sunshine-Chun force-pushed the fb-mysql-8.0.28-dd-api2 branch 2 times, most recently from 88b36f4 to 7897e70 Compare April 28, 2023 23:12
laurynas-biveinis
laurynas-biveinis reviewed May 1, 2023
View reviewed changes
Comment thread storage/rocksdb/rdb_native_dd.h Outdated

namespace myrocks {

constexpr const char *rocksdb_dd_space_name = "mysql";

@laurynas-biveinis laurynas-biveinis May 1, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
constexpr const char *rocksdb_dd_space_name = "mysql";
constexpr const char rocksdb_dd_space_name[] = "mysql";

The pointer version works, but its sizeof is 8, which is very annoying to find
@sunshine-Chun

sunshine-Chun commented May 4, 2023

Copy link
Copy Markdown
Contributor Author

Do we still need this diff. Sounds like we are not adding the. dd_space in the ddst_dict_init function now.
@laurynas-biveinis

laurynas-biveinis commented May 5, 2023

Copy link
Copy Markdown
Contributor

As with the rest of the current diffs, it's hard to say, as the code is too incomplete to run. IMHO we can hold until it becomes clear.
@facebook-github-bot

facebook-github-bot commented Jun 13, 2023

Copy link
Copy Markdown

@sunshine-Chun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
@luqun

luqun commented Jun 14, 2023

Copy link
Copy Markdown
Contributor

@laurynas-biveinis , according to previous conversation, we may still need this mysql tablespace. Currently #1319 will fail if there is testcase using rocksdb DD.
@sunshine-Chun sunshine-Chun force-pushed the fb-mysql-8.0.28-dd-api2 branch from 7897e70 to 8dcbca4 Compare June 14, 2023 17:44
@facebook-github-bot

facebook-github-bot commented Jun 14, 2023

Copy link
Copy Markdown

@sunshine-Chun has updated the pull request. You must reimport the pull request before landing.
@facebook-github-bot

facebook-github-bot commented Jun 14, 2023

Copy link
Copy Markdown

@sunshine-Chun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
@sunshine-Chun sunshine-Chun force-pushed the fb-mysql-8.0.28-dd-api2 branch from 8dcbca4 to 4d98701 Compare June 14, 2023 17:53
@facebook-github-bot

facebook-github-bot commented Jun 14, 2023

Copy link
Copy Markdown

@sunshine-Chun has updated the pull request. You must reimport the pull request before landing.
@sunshine-Chun sunshine-Chun force-pushed the fb-mysql-8.0.28-dd-api2 branch from 4d98701 to 0593d65 Compare June 14, 2023 17:58
@facebook-github-bot

facebook-github-bot commented Jun 14, 2023

Copy link
Copy Markdown

@sunshine-Chun has updated the pull request. You must reimport the pull request before landing.
@sunshine-Chun
Add ddst_dict_init api support for rocksdb dd
0f1e9a8 
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:
@sunshine-Chun sunshine-Chun force-pushed the fb-mysql-8.0.28-dd-api2 branch from 0593d65 to 0f1e9a8 Compare June 14, 2023 17:59
@facebook-github-bot

facebook-github-bot commented Jun 14, 2023

Copy link
Copy Markdown

@sunshine-Chun has updated the pull request. You must reimport the pull request before landing.
@facebook-github-bot

facebook-github-bot commented Jun 14, 2023

Copy link
Copy Markdown

@sunshine-Chun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
@laurynas-biveinis

laurynas-biveinis commented Jun 15, 2023

Copy link
Copy Markdown
Contributor

@sunshine-Chun , @luqun, It is true that we'll need the mysql tablespace. But, in the current prototype it is InnoDB that sets it up, thus at this point I am not comfortable to committing to RocksDB creating it. We could quickly merge a PR for ddse_dict_init, which would be mostly empty, and leave the tablespace for later.
facebook-github-bot pushed a commit that referenced this pull request Jun 17, 2023
@sunshine-Chun @facebook-github-bot
Add ddst_dict_init api support for rocksdb ddse (#1297)
5813c1a 
Summary:
Add ddst_dict_init handler api support for rocksdb dd

Currently rocksdb ddst_dict_init() doesn't add any rocksdb specific tables and tablespace during ddse initialize.

Pull Request resolved: #1297

Test Plan: CI

Differential Revision: D46700996

fbshipit-source-id: fbb8003
luqun pushed a commit to luqun/mysql-5.6 that referenced this pull request Jun 20, 2023
@sunshine-Chun
[mysql-5.6][PR] Add ddst_dict_init api support for rocksdb ddse
fbb8003 
Summary:
 Add ddst_dict_init handler api support for rocksdb dd

Currently rocksdb ddst_dict_init() doesn't add any rocksdb specific tables and tablespace during ddse initialize. 


Pull Request resolved: facebook#1297
GitHub Author: Chun Ni <chni@fb.com>

Test Plan: CI

Reviewers: luqun

Subscribers: webscalesql-eng@fb.com

Differential Revision: https://phabricator.intern.facebook.com/D46700996

Tags: accept2ship
hermanlee pushed a commit to hermanlee/mysql-5.6 that referenced this pull request Oct 3, 2023
@sunshine-Chun
Add ddst_dict_init api support for rocksdb ddse (facebook#1297)
3eeb90a 
Summary:
Add ddst_dict_init handler api support for rocksdb dd

Currently rocksdb ddst_dict_init() doesn't add any rocksdb specific tables and tablespace during ddse initialize.

Pull Request resolved: facebook#1297

Test Plan: CI

Differential Revision: D46700996
hermanlee pushed a commit to hermanlee/mysql-5.6 that referenced this pull request Oct 18, 2023
@sunshine-Chun
Add ddst_dict_init api support for rocksdb ddse (facebook#1297)
ba19681 
Summary:
Add ddst_dict_init handler api support for rocksdb dd

Currently rocksdb ddst_dict_init() doesn't add any rocksdb specific tables and tablespace during ddse initialize.

Pull Request resolved: facebook#1297

Test Plan: CI

Differential Revision: D46700996
@laurynas-biveinis

laurynas-biveinis commented Nov 6, 2023

Copy link
Copy Markdown
Contributor

@sunshine-Chun , please close this PR
inikep pushed a commit to inikep/percona-server that referenced this pull request Dec 20, 2023
@sunshine-Chun @inikep
Add ddst_dict_init api support for rocksdb ddse (percona#1297)
564b995 
Summary:
Add ddst_dict_init handler api support for rocksdb dd

Currently rocksdb ddst_dict_init() doesn't add any rocksdb specific tables and tablespace during ddse initialize.

Pull Request resolved: facebook/mysql-5.6#1297

Test Plan: CI

Differential Revision: D46700996

fbshipit-source-id: fbb80035b54cc068c845e63fe6903c8488fce1d3
inikep pushed a commit to inikep/percona-server that referenced this pull request Dec 20, 2023
@sunshine-Chun @inikep
Add ddst_dict_init api support for rocksdb ddse (percona#1297)
9693166 
Summary:
Add ddst_dict_init handler api support for rocksdb dd

Currently rocksdb ddst_dict_init() doesn't add any rocksdb specific tables and tablespace during ddse initialize.

Pull Request resolved: facebook/mysql-5.6#1297

Test Plan: CI

Differential Revision: D46700996

fbshipit-source-id: fbb80035b54cc068c845e63fe6903c8488fce1d3
inikep pushed a commit to inikep/mysql-5.6 that referenced this pull request May 7, 2024
@sunshine-Chun @inikep
Add ddst_dict_init api support for rocksdb ddse (facebook#1297)
4c30a21 
Summary:
Add ddst_dict_init handler api support for rocksdb dd

Currently rocksdb ddst_dict_init() doesn't add any rocksdb specific tables and tablespace during ddse initialize.

Pull Request resolved: facebook#1297

Test Plan: CI

Differential Revision: D46700996
inikep pushed a commit to inikep/mysql-5.6 that referenced this pull request May 8, 2024
@sunshine-Chun @inikep
Add ddst_dict_init api support for rocksdb ddse (facebook#1297)
88d5c97 
Summary:
Add ddst_dict_init handler api support for rocksdb dd

Currently rocksdb ddst_dict_init() doesn't add any rocksdb specific tables and tablespace during ddse initialize.

Pull Request resolved: facebook#1297

Test Plan: CI

Differential Revision: D46700996
inikep pushed a commit to inikep/mysql-5.6 that referenced this pull request May 9, 2024
@sunshine-Chun @inikep
Add ddst_dict_init api support for rocksdb ddse (facebook#1297)
1ca6a6c 
Summary:
Add ddst_dict_init handler api support for rocksdb dd

Currently rocksdb ddst_dict_init() doesn't add any rocksdb specific tables and tablespace during ddse initialize.

Pull Request resolved: facebook#1297

Test Plan: CI

Differential Revision: D46700996
inikep pushed a commit to inikep/mysql-5.6 that referenced this pull request May 10, 2024
@sunshine-Chun @inikep
Add ddst_dict_init api support for rocksdb ddse (facebook#1297)
7a4a692 
Summary:
Add ddst_dict_init handler api support for rocksdb dd

Currently rocksdb ddst_dict_init() doesn't add any rocksdb specific tables and tablespace during ddse initialize.

Pull Request resolved: facebook#1297

Test Plan: CI

Differential Revision: D46700996
inikep pushed a commit to inikep/mysql-5.6 that referenced this pull request May 13, 2024
@sunshine-Chun @inikep
Add ddst_dict_init api support for rocksdb ddse (facebook#1297)
cc83637 
Summary:
Add ddst_dict_init handler api support for rocksdb dd

Currently rocksdb ddst_dict_init() doesn't add any rocksdb specific tables and tablespace during ddse initialize.

Pull Request resolved: facebook#1297

Test Plan: CI

Differential Revision: D46700996
inikep pushed a commit to inikep/mysql-5.6 that referenced this pull request May 15, 2024
@sunshine-Chun @inikep
Add ddst_dict_init api support for rocksdb ddse (facebook#1297)
0528874 
Summary:
Add ddst_dict_init handler api support for rocksdb dd

Currently rocksdb ddst_dict_init() doesn't add any rocksdb specific tables and tablespace during ddse initialize.

Pull Request resolved: facebook#1297

Test Plan: CI

Differential Revision: D46700996
inikep pushed a commit to inikep/mysql-5.6 that referenced this pull request May 16, 2024
@sunshine-Chun @inikep
Add ddst_dict_init api support for rocksdb ddse (facebook#1297)
8efb5c4 
Summary:
Add ddst_dict_init handler api support for rocksdb dd

Currently rocksdb ddst_dict_init() doesn't add any rocksdb specific tables and tablespace during ddse initialize.

Pull Request resolved: facebook#1297

Test Plan: CI

Differential Revision: D46700996
inikep pushed a commit to inikep/mysql-5.6 that referenced this pull request May 17, 2024
@sunshine-Chun @inikep
Add ddst_dict_init api support for rocksdb ddse (facebook#1297)
701feba 
Summary:
Add ddst_dict_init handler api support for rocksdb dd

Currently rocksdb ddst_dict_init() doesn't add any rocksdb specific tables and tablespace during ddse initialize.

Pull Request resolved: facebook#1297

Test Plan: CI

Differential Revision: D46700996
inikep pushed a commit to inikep/mysql-5.6 that referenced this pull request May 17, 2024
@sunshine-Chun @inikep
Add ddst_dict_init api support for rocksdb ddse (facebook#1297)
a06573e 
Summary:
Add ddst_dict_init handler api support for rocksdb dd

Currently rocksdb ddst_dict_init() doesn't add any rocksdb specific tables and tablespace during ddse initialize.

Pull Request resolved: facebook#1297

Test Plan: CI

Differential Revision: D46700996
inikep pushed a commit to inikep/mysql-5.6 that referenced this pull request May 21, 2024
@sunshine-Chun @inikep
Add ddst_dict_init api support for rocksdb ddse (facebook#1297)
798c5d7 
Summary:
Add ddst_dict_init handler api support for rocksdb dd

Currently rocksdb ddst_dict_init() doesn't add any rocksdb specific tables and tablespace during ddse initialize.

Pull Request resolved: facebook#1297

Test Plan: CI

Differential Revision: D46700996
inikep pushed a commit to inikep/mysql-5.6 that referenced this pull request May 21, 2024
@sunshine-Chun @inikep
Add ddst_dict_init api support for rocksdb ddse (facebook#1297)
c88183b 
Summary:
Add ddst_dict_init handler api support for rocksdb dd

Currently rocksdb ddst_dict_init() doesn't add any rocksdb specific tables and tablespace during ddse initialize.

Pull Request resolved: facebook#1297

Test Plan: CI

Differential Revision: D46700996
inikep pushed a commit to inikep/mysql-5.6 that referenced this pull request May 30, 2024
@sunshine-Chun @inikep
Add ddst_dict_init api support for rocksdb ddse (facebook#1297)
87f76c5 
Summary:
Add ddst_dict_init handler api support for rocksdb dd

Currently rocksdb ddst_dict_init() doesn't add any rocksdb specific tables and tablespace during ddse initialize.

Pull Request resolved: facebook#1297

Test Plan: CI

Differential Revision: D46700996
inikep pushed a commit to inikep/mysql-5.6 that referenced this pull request Jul 16, 2024
@sunshine-Chun @inikep
Add ddst_dict_init api support for rocksdb ddse (facebook#1297)
64579ea 
Summary:
Add ddst_dict_init handler api support for rocksdb dd

Currently rocksdb ddst_dict_init() doesn't add any rocksdb specific tables and tablespace during ddse initialize.

Pull Request resolved: facebook#1297

Test Plan: CI

Differential Revision: D46700996
inikep pushed a commit to inikep/mysql-5.6 that referenced this pull request Jul 16, 2024
@sunshine-Chun @inikep
Add ddst_dict_init api support for rocksdb ddse (facebook#1297)
7a8ffe4 
Summary:
Add ddst_dict_init handler api support for rocksdb dd

Currently rocksdb ddst_dict_init() doesn't add any rocksdb specific tables and tablespace during ddse initialize.

Pull Request resolved: facebook#1297

Test Plan: CI

Differential Revision: D46700996
inikep pushed a commit to inikep/mysql-5.6 that referenced this pull request Jul 17, 2024
@sunshine-Chun @inikep
Add ddst_dict_init api support for rocksdb ddse (facebook#1297)
348cb65 
Summary:
Add ddst_dict_init handler api support for rocksdb dd

Currently rocksdb ddst_dict_init() doesn't add any rocksdb specific tables and tablespace during ddse initialize.

Pull Request resolved: facebook#1297

Test Plan: CI

Differential Revision: D46700996
inikep pushed a commit to inikep/mysql-5.6 that referenced this pull request Jul 19, 2024
@sunshine-Chun @inikep
Add ddst_dict_init api support for rocksdb ddse (facebook#1297)
3aa6d84 
Summary:
Add ddst_dict_init handler api support for rocksdb dd

Currently rocksdb ddst_dict_init() doesn't add any rocksdb specific tables and tablespace during ddse initialize.

Pull Request resolved: facebook#1297

Test Plan: CI

Differential Revision: D46700996
inikep pushed a commit to inikep/mysql-5.6 that referenced this pull request Jul 19, 2024
@sunshine-Chun @inikep
Add ddst_dict_init api support for rocksdb ddse (facebook#1297)
5efff80 
Summary:
Add ddst_dict_init handler api support for rocksdb dd

Currently rocksdb ddst_dict_init() doesn't add any rocksdb specific tables and tablespace during ddse initialize.

Pull Request resolved: facebook#1297

Test Plan: CI

Differential Revision: D46700996
inikep pushed a commit to inikep/mysql-5.6 that referenced this pull request Jul 30, 2024
@sunshine-Chun @inikep
Add ddst_dict_init api support for rocksdb ddse (facebook#1297)
b822c36 
Summary:
Add ddst_dict_init handler api support for rocksdb dd

Currently rocksdb ddst_dict_init() doesn't add any rocksdb specific tables and tablespace during ddse initialize.

Pull Request resolved: facebook#1297

Test Plan: CI

Differential Revision: D46700996
inikep pushed a commit to inikep/mysql-5.6 that referenced this pull request Jul 31, 2024
@sunshine-Chun @inikep
Add ddst_dict_init api support for rocksdb ddse (facebook#1297)
3e9ca7c 
Summary:
Add ddst_dict_init handler api support for rocksdb dd

Currently rocksdb ddst_dict_init() doesn't add any rocksdb specific tables and tablespace during ddse initialize.

Pull Request resolved: facebook#1297

Test Plan: CI

Differential Revision: D46700996
inikep pushed a commit to inikep/mysql-5.6 that referenced this pull request Aug 2, 2024
@sunshine-Chun @inikep
Add ddst_dict_init api support for rocksdb ddse (facebook#1297)
9a6e0a3 
Summary:
Add ddst_dict_init handler api support for rocksdb dd

Currently rocksdb ddst_dict_init() doesn't add any rocksdb specific tables and tablespace during ddse initialize.

Pull Request resolved: facebook#1297

Test Plan: CI

Differential Revision: D46700996
inikep pushed a commit to inikep/mysql-5.6 that referenced this pull request Aug 6, 2024
@sunshine-Chun @inikep
Add ddst_dict_init api support for rocksdb ddse (facebook#1297)
98bc7f7 
Summary:
Add ddst_dict_init handler api support for rocksdb dd

Currently rocksdb ddst_dict_init() doesn't add any rocksdb specific tables and tablespace during ddse initialize.

Pull Request resolved: facebook#1297

Test Plan: CI

Differential Revision: D46700996
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

CLA Signed

4 participants

@sunshine-Chun @laurynas-biveinis @facebook-github-bot @luqun