This repository was archived by the owner on Mar 1, 2026. It is now read-only.
Refactor the acquisition of DDSE handlerton#1319
Closed
laurynas-biveinis wants to merge 3 commits into
Closed
Conversation
In c3f1703, get_rocksdb_files.sh invocation got PATH setting. The public discussion is incomplete but b739eac suggests that there is a problem with CentOS 9 and make 4.3 that undefined PATH does not get a default fallback, thus a PATH value is provided for the invocation. The provided PATH value is however incompatible with building on macOS. Fix by setting the fallback PATH value in the get_rocksdb_files.sh script itself.
Make it support both InnoDB and MyRocks DDSEs by introducing a helper function dd::get_dd_engine that returns either based on the default_dd_storage_engine sysvar setting. To have correct diagnostics in one instance at least, introduce a get_dd_engine_name utility function too. No functional changes if default_dd_storage_engine == InnoDB.
|
@sunshine-Chun has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
|
still work on update one MTR(rocksdb.early_load_rocksdb_plugin) according to this PR. |
Contributor
Author
@luqun, I am sorry, I forgot that we already have an MTR test for DDSE == RocksDB. Do you need me to do anything at this point? |
facebook-github-bot
pushed a commit
that referenced
this pull request
Jun 18, 2023
Summary: Make it support both InnoDB and MyRocks DDSEs by introducing a helper function dd::get_dd_engine that returns either based on the default_dd_storage_engine sysvar setting. To have correct diagnostics in one instance at least, introduce a get_dd_engine_name utility function too. No functional changes if default_dd_storage_engine == InnoDB. Pull Request resolved: #1319 Differential Revision: D46649458 fbshipit-source-id: d861347
luqun
pushed a commit
to luqun/mysql-5.6
that referenced
this pull request
Jun 20, 2023
Summary: Make it support both InnoDB and MyRocks DDSEs by introducing a helper function dd::get_dd_engine that returns either based on the default_dd_storage_engine sysvar setting. To have correct diagnostics in one instance at least, introduce a get_dd_engine_name utility function too. No functional changes if default_dd_storage_engine == InnoDB. Pull Request resolved: facebook#1319 GitHub Author: Laurynas Biveinis <laurynas.biveinis@gmail.com> Test Plan: Imported from GitHub, without a `Test Plan:` line. Reviewers: herman, chni Reviewed By: chni Subscribers: webscalesql-eng@fb.com Differential Revision: https://phabricator.intern.facebook.com/D46649458 Tags: accept2ship
hermanlee
pushed a commit
to hermanlee/mysql-5.6
that referenced
this pull request
Oct 3, 2023
Summary: Make it support both InnoDB and MyRocks DDSEs by introducing a helper function dd::get_dd_engine that returns either based on the default_dd_storage_engine sysvar setting. To have correct diagnostics in one instance at least, introduce a get_dd_engine_name utility function too. No functional changes if default_dd_storage_engine == InnoDB. Pull Request resolved: facebook#1319 Differential Revision: D46649458
hermanlee
pushed a commit
to hermanlee/mysql-5.6
that referenced
this pull request
Oct 18, 2023
Summary: Make it support both InnoDB and MyRocks DDSEs by introducing a helper function dd::get_dd_engine that returns either based on the default_dd_storage_engine sysvar setting. To have correct diagnostics in one instance at least, introduce a get_dd_engine_name utility function too. No functional changes if default_dd_storage_engine == InnoDB. Pull Request resolved: facebook#1319 Differential Revision: D46649458
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 7, 2024
Summary: Make it support both InnoDB and MyRocks DDSEs by introducing a helper function dd::get_dd_engine that returns either based on the default_dd_storage_engine sysvar setting. To have correct diagnostics in one instance at least, introduce a get_dd_engine_name utility function too. No functional changes if default_dd_storage_engine == InnoDB. Pull Request resolved: facebook#1319 Differential Revision: D46649458
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 8, 2024
Summary: Make it support both InnoDB and MyRocks DDSEs by introducing a helper function dd::get_dd_engine that returns either based on the default_dd_storage_engine sysvar setting. To have correct diagnostics in one instance at least, introduce a get_dd_engine_name utility function too. No functional changes if default_dd_storage_engine == InnoDB. Pull Request resolved: facebook#1319 Differential Revision: D46649458
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 9, 2024
Summary: Make it support both InnoDB and MyRocks DDSEs by introducing a helper function dd::get_dd_engine that returns either based on the default_dd_storage_engine sysvar setting. To have correct diagnostics in one instance at least, introduce a get_dd_engine_name utility function too. No functional changes if default_dd_storage_engine == InnoDB. Pull Request resolved: facebook#1319 Differential Revision: D46649458
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 10, 2024
Summary: Make it support both InnoDB and MyRocks DDSEs by introducing a helper function dd::get_dd_engine that returns either based on the default_dd_storage_engine sysvar setting. To have correct diagnostics in one instance at least, introduce a get_dd_engine_name utility function too. No functional changes if default_dd_storage_engine == InnoDB. Pull Request resolved: facebook#1319 Differential Revision: D46649458
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 13, 2024
Summary: Make it support both InnoDB and MyRocks DDSEs by introducing a helper function dd::get_dd_engine that returns either based on the default_dd_storage_engine sysvar setting. To have correct diagnostics in one instance at least, introduce a get_dd_engine_name utility function too. No functional changes if default_dd_storage_engine == InnoDB. Pull Request resolved: facebook#1319 Differential Revision: D46649458
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 15, 2024
Summary: Make it support both InnoDB and MyRocks DDSEs by introducing a helper function dd::get_dd_engine that returns either based on the default_dd_storage_engine sysvar setting. To have correct diagnostics in one instance at least, introduce a get_dd_engine_name utility function too. No functional changes if default_dd_storage_engine == InnoDB. Pull Request resolved: facebook#1319 Differential Revision: D46649458
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 16, 2024
Summary: Make it support both InnoDB and MyRocks DDSEs by introducing a helper function dd::get_dd_engine that returns either based on the default_dd_storage_engine sysvar setting. To have correct diagnostics in one instance at least, introduce a get_dd_engine_name utility function too. No functional changes if default_dd_storage_engine == InnoDB. Pull Request resolved: facebook#1319 Differential Revision: D46649458
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 17, 2024
Summary: Make it support both InnoDB and MyRocks DDSEs by introducing a helper function dd::get_dd_engine that returns either based on the default_dd_storage_engine sysvar setting. To have correct diagnostics in one instance at least, introduce a get_dd_engine_name utility function too. No functional changes if default_dd_storage_engine == InnoDB. Pull Request resolved: facebook#1319 Differential Revision: D46649458
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 17, 2024
Summary: Make it support both InnoDB and MyRocks DDSEs by introducing a helper function dd::get_dd_engine that returns either based on the default_dd_storage_engine sysvar setting. To have correct diagnostics in one instance at least, introduce a get_dd_engine_name utility function too. No functional changes if default_dd_storage_engine == InnoDB. Pull Request resolved: facebook#1319 Differential Revision: D46649458
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 21, 2024
Summary: Make it support both InnoDB and MyRocks DDSEs by introducing a helper function dd::get_dd_engine that returns either based on the default_dd_storage_engine sysvar setting. To have correct diagnostics in one instance at least, introduce a get_dd_engine_name utility function too. No functional changes if default_dd_storage_engine == InnoDB. Pull Request resolved: facebook#1319 Differential Revision: D46649458
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 21, 2024
Summary: Make it support both InnoDB and MyRocks DDSEs by introducing a helper function dd::get_dd_engine that returns either based on the default_dd_storage_engine sysvar setting. To have correct diagnostics in one instance at least, introduce a get_dd_engine_name utility function too. No functional changes if default_dd_storage_engine == InnoDB. Pull Request resolved: facebook#1319 Differential Revision: D46649458
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 30, 2024
Summary: Make it support both InnoDB and MyRocks DDSEs by introducing a helper function dd::get_dd_engine that returns either based on the default_dd_storage_engine sysvar setting. To have correct diagnostics in one instance at least, introduce a get_dd_engine_name utility function too. No functional changes if default_dd_storage_engine == InnoDB. Pull Request resolved: facebook#1319 Differential Revision: D46649458
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jul 16, 2024
Summary: Make it support both InnoDB and MyRocks DDSEs by introducing a helper function dd::get_dd_engine that returns either based on the default_dd_storage_engine sysvar setting. To have correct diagnostics in one instance at least, introduce a get_dd_engine_name utility function too. No functional changes if default_dd_storage_engine == InnoDB. Pull Request resolved: facebook#1319 Differential Revision: D46649458
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jul 16, 2024
Summary: Make it support both InnoDB and MyRocks DDSEs by introducing a helper function dd::get_dd_engine that returns either based on the default_dd_storage_engine sysvar setting. To have correct diagnostics in one instance at least, introduce a get_dd_engine_name utility function too. No functional changes if default_dd_storage_engine == InnoDB. Pull Request resolved: facebook#1319 Differential Revision: D46649458
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jul 17, 2024
Summary: Make it support both InnoDB and MyRocks DDSEs by introducing a helper function dd::get_dd_engine that returns either based on the default_dd_storage_engine sysvar setting. To have correct diagnostics in one instance at least, introduce a get_dd_engine_name utility function too. No functional changes if default_dd_storage_engine == InnoDB. Pull Request resolved: facebook#1319 Differential Revision: D46649458
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jul 19, 2024
Summary: Make it support both InnoDB and MyRocks DDSEs by introducing a helper function dd::get_dd_engine that returns either based on the default_dd_storage_engine sysvar setting. To have correct diagnostics in one instance at least, introduce a get_dd_engine_name utility function too. No functional changes if default_dd_storage_engine == InnoDB. Pull Request resolved: facebook#1319 Differential Revision: D46649458
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jul 19, 2024
Summary: Make it support both InnoDB and MyRocks DDSEs by introducing a helper function dd::get_dd_engine that returns either based on the default_dd_storage_engine sysvar setting. To have correct diagnostics in one instance at least, introduce a get_dd_engine_name utility function too. No functional changes if default_dd_storage_engine == InnoDB. Pull Request resolved: facebook#1319 Differential Revision: D46649458
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jul 30, 2024
Summary: Make it support both InnoDB and MyRocks DDSEs by introducing a helper function dd::get_dd_engine that returns either based on the default_dd_storage_engine sysvar setting. To have correct diagnostics in one instance at least, introduce a get_dd_engine_name utility function too. No functional changes if default_dd_storage_engine == InnoDB. Pull Request resolved: facebook#1319 Differential Revision: D46649458
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jul 31, 2024
Summary: Make it support both InnoDB and MyRocks DDSEs by introducing a helper function dd::get_dd_engine that returns either based on the default_dd_storage_engine sysvar setting. To have correct diagnostics in one instance at least, introduce a get_dd_engine_name utility function too. No functional changes if default_dd_storage_engine == InnoDB. Pull Request resolved: facebook#1319 Differential Revision: D46649458
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Aug 2, 2024
Summary: Make it support both InnoDB and MyRocks DDSEs by introducing a helper function dd::get_dd_engine that returns either based on the default_dd_storage_engine sysvar setting. To have correct diagnostics in one instance at least, introduce a get_dd_engine_name utility function too. No functional changes if default_dd_storage_engine == InnoDB. Pull Request resolved: facebook#1319 Differential Revision: D46649458
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Aug 6, 2024
Summary: Make it support both InnoDB and MyRocks DDSEs by introducing a helper function dd::get_dd_engine that returns either based on the default_dd_storage_engine sysvar setting. To have correct diagnostics in one instance at least, introduce a get_dd_engine_name utility function too. No functional changes if default_dd_storage_engine == InnoDB. Pull Request resolved: facebook#1319 Differential Revision: D46649458
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make it support both InnoDB and MyRocks DDSEs by introducing a helper function
dd::get_dd_engine that returns either based on the default_dd_storage_engine
sysvar setting. To have correct diagnostics in one instance at least, introduce
a get_dd_engine_name utility function too.
No functional changes if default_dd_storage_engine == InnoDB.