This repository was archived by the owner on Mar 1, 2026. It is now read-only.
Remove format version checking code#483
Closed
lth wants to merge 1 commit into
Closed
Conversation
|
@lth has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
hermanlee
approved these changes
Dec 21, 2016
hermanlee
left a comment
hermanlee
left a comment
Contributor
There was a problem hiding this comment.
Red diffs look great. Thanks for removing this code.
|
@lth has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
george-lorch
pushed a commit
to george-lorch/percona-server
that referenced
this pull request
Feb 2, 2017
Upstream commit ID: e44e0b0892c726fd0592ce7e1e310463c3f9edd2 Summary: Now that the new format is deployed, we don't need to check for old formats anymore. Remove the checks as well as associated tests that exercises the format upgrade path. Closes percona#296. Closes facebook/mysql-5.6#483 Differential Revision: D4355790 Pulled By: lth fbshipit-source-id: d1ba23f
george-lorch
pushed a commit
to george-lorch/percona-server
that referenced
this pull request
Feb 6, 2017
Upstream commit ID: e44e0b0892c726fd0592ce7e1e310463c3f9edd2 Summary: Now that the new format is deployed, we don't need to check for old formats anymore. Remove the checks as well as associated tests that exercises the format upgrade path. Closes percona#296. Closes facebook/mysql-5.6#483 Differential Revision: D4355790 Pulled By: lth fbshipit-source-id: d1ba23f
george-lorch
pushed a commit
to george-lorch/percona-server
that referenced
this pull request
Feb 6, 2017
Upstream commit ID: e44e0b0892c726fd0592ce7e1e310463c3f9edd2 Summary: Now that the new format is deployed, we don't need to check for old formats anymore. Remove the checks as well as associated tests that exercises the format upgrade path. Closes percona#296. Closes facebook/mysql-5.6#483 Differential Revision: D4355790 Pulled By: lth fbshipit-source-id: d1ba23f
VitaliyLi
pushed a commit
to VitaliyLi/mysql-5.6
that referenced
this pull request
Feb 9, 2017
Summary: Now that the new format is deployed, we don't need to check for old formats anymore. Remove the checks as well as associated tests that exercises the format upgrade path. Closes facebook#296. Closes facebook#483 Differential Revision: D4355790 Pulled By: lth fbshipit-source-id: d1ba23f
gunnarku
pushed a commit
to facebook/mysql-8.0
that referenced
this pull request
Jul 21, 2017
Summary: Now that the new format is deployed, we don't need to check for old formats anymore. Remove the checks as well as associated tests that exercises the format upgrade path. Closes mysql#296. Closes facebook/mysql-5.6#483 Differential Revision: D4355790 Pulled By: lth fbshipit-source-id: d1ba23f
gunnarku
pushed a commit
to facebook/mysql-8.0
that referenced
this pull request
Jul 25, 2017
Summary: Now that the new format is deployed, we don't need to check for old formats anymore. Remove the checks as well as associated tests that exercises the format upgrade path. Closes mysql#296. Closes facebook/mysql-5.6#483 Differential Revision: D4355790 Pulled By: lth fbshipit-source-id: d1ba23f
facebook-github-bot
pushed a commit
that referenced
this pull request
Dec 23, 2019
Summary: Now that the new format is deployed, we don't need to check for old formats anymore. Remove the checks as well as associated tests that exercises the format upgrade path. Closes #296. Closes #483 Differential Revision: D4355790 Pulled By: lth fbshipit-source-id: d1ba23f fbshipit-source-id: 36860c3
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Aug 12, 2020
Summary: Now that the new format is deployed, we don't need to check for old formats anymore. Remove the checks as well as associated tests that exercises the format upgrade path. Closes facebook#296. Closes facebook#483 Differential Revision: D4355790 Pulled By: lth fbshipit-source-id: d1ba23f fbshipit-source-id: 36860c3
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Sep 9, 2020
Summary: Now that the new format is deployed, we don't need to check for old formats anymore. Remove the checks as well as associated tests that exercises the format upgrade path. Closes facebook#296. Closes facebook#483 Differential Revision: D4355790 Pulled By: lth fbshipit-source-id: d1ba23f fbshipit-source-id: 36860c3
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Sep 16, 2020
Summary: Now that the new format is deployed, we don't need to check for old formats anymore. Remove the checks as well as associated tests that exercises the format upgrade path. Closes facebook#296. Closes facebook#483 Differential Revision: D4355790 Pulled By: lth fbshipit-source-id: d1ba23f fbshipit-source-id: 36860c3
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Oct 5, 2020
Summary: Now that the new format is deployed, we don't need to check for old formats anymore. Remove the checks as well as associated tests that exercises the format upgrade path. Closes facebook#296. Closes facebook#483 Differential Revision: D4355790 Pulled By: lth fbshipit-source-id: d1ba23f fbshipit-source-id: 36860c3
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Nov 11, 2020
Summary: Now that the new format is deployed, we don't need to check for old formats anymore. Remove the checks as well as associated tests that exercises the format upgrade path. Closes facebook#296. Closes facebook#483 Differential Revision: D4355790 Pulled By: lth fbshipit-source-id: d1ba23f fbshipit-source-id: 36860c3
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Aug 16, 2021
Summary: Now that the new format is deployed, we don't need to check for old formats anymore. Remove the checks as well as associated tests that exercises the format upgrade path. Closes facebook#296. Closes facebook#483 Differential Revision: D4355790 (facebook@e44e0b0) Pulled By: lth fbshipit-source-id: 0dabcfc5b3b
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Aug 17, 2021
Summary: Now that the new format is deployed, we don't need to check for old formats anymore. Remove the checks as well as associated tests that exercises the format upgrade path. Closes facebook#296. Closes facebook#483 Differential Revision: D4355790 (facebook@e44e0b0) Pulled By: lth fbshipit-source-id: 0dabcfc5b3b
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Aug 30, 2021
Summary: Now that the new format is deployed, we don't need to check for old formats anymore. Remove the checks as well as associated tests that exercises the format upgrade path. Closes facebook#296. Closes facebook#483 Differential Revision: D4355790 (facebook@e44e0b0) Pulled By: lth fbshipit-source-id: 0dabcfc5b3b
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Aug 30, 2021
Summary: Now that the new format is deployed, we don't need to check for old formats anymore. Remove the checks as well as associated tests that exercises the format upgrade path. Closes facebook#296. Closes facebook#483 Differential Revision: D4355790 (facebook@e44e0b0) Pulled By: lth fbshipit-source-id: 0dabcfc5b3b
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Sep 1, 2021
Summary: Now that the new format is deployed, we don't need to check for old formats anymore. Remove the checks as well as associated tests that exercises the format upgrade path. Closes facebook#296. Closes facebook#483 Differential Revision: D4355790 (facebook@e44e0b0) Pulled By: lth fbshipit-source-id: 0dabcfc5b3b
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Sep 2, 2021
Summary: Now that the new format is deployed, we don't need to check for old formats anymore. Remove the checks as well as associated tests that exercises the format upgrade path. Closes facebook#296. Closes facebook#483 Differential Revision: D4355790 (facebook@e44e0b0) Pulled By: lth fbshipit-source-id: 0dabcfc5b3b
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jan 17, 2022
Summary: Now that the new format is deployed, we don't need to check for old formats anymore. Remove the checks as well as associated tests that exercises the format upgrade path. Closes facebook#296. Closes facebook#483 Differential Revision: D4355790 Pulled By: lth
ldonoso
pushed a commit
to ldonoso/percona-server
that referenced
this pull request
Mar 15, 2022
Summary: Now that the new format is deployed, we don't need to check for old formats anymore. Remove the checks as well as associated tests that exercises the format upgrade path. Closes percona#296. Closes facebook/mysql-5.6#483 Differential Revision: D4355790 Pulled By: lth
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Apr 26, 2022
Summary: Now that the new format is deployed, we don't need to check for old formats anymore. Remove the checks as well as associated tests that exercises the format upgrade path. Closes facebook#296. Closes facebook#483 Differential Revision: D4355790 Pulled By: lth
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
May 20, 2022
Summary: Now that the new format is deployed, we don't need to check for old formats anymore. Remove the checks as well as associated tests that exercises the format upgrade path. Closes facebook#296. Closes facebook#483 Differential Revision: D4355790 Pulled By: lth
laurynas-biveinis
pushed a commit
to laurynas-biveinis/mysql-5.6
that referenced
this pull request
Aug 11, 2022
Summary: Now that the new format is deployed, we don't need to check for old formats anymore. Remove the checks as well as associated tests that exercises the format upgrade path. Closes facebook#296. Closes facebook#483 Differential Revision: D4355790 Pulled By: lth
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Mar 28, 2023
Summary: Now that the new format is deployed, we don't need to check for old formats anymore. Remove the checks as well as associated tests that exercises the format upgrade path. Closes facebook#296. Closes facebook#483 Differential Revision: D4355790 Pulled By: lth
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jun 1, 2023
Summary: Now that the new format is deployed, we don't need to check for old formats anymore. Remove the checks as well as associated tests that exercises the format upgrade path. Closes facebook#296. Closes facebook#483 Differential Revision: D4355790 Pulled By: lth
inikep
pushed a commit
to inikep/mysql-5.6
that referenced
this pull request
Jun 14, 2023
Summary: Now that the new format is deployed, we don't need to check for old formats anymore. Remove the checks as well as associated tests that exercises the format upgrade path. Closes facebook#296. Closes facebook#483 Differential Revision: D4355790 Pulled By: lth
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Apr 9, 2024
Summary: Now that the new format is deployed, we don't need to check for old formats anymore. Remove the checks as well as associated tests that exercises the format upgrade path. Closes percona#296. Closes facebook/mysql-5.6#483 Differential Revision: D4355790 Pulled By: lth
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that the new format is deployed, we don't need to check for old formats anymore. Remove the checks as well as associated tests that exercises the format upgrade path.
Closes #296.