Fix bug 1530918 (Utility user memory leak)#296
Merged
Conversation
The 5.7 port added allocation of acl_utility_user.auth_string in acl_init_utility_user without a corresponding deallocation in acl_free_utility_user. Fixed by adding it, and by moving the allocation to the start of acl_init_utility_user next to the other allocations to ensure proper cleanup in case of early returns.
laurynas-biveinis
added a commit
that referenced
this pull request
Jan 8, 2016
Fix bug 1530918 (Utility user memory leak)
george-lorch
pushed a commit
to george-lorch/percona-server
that referenced
this pull request
Feb 2, 2017
Upstream commit ID: e44e0b0892c726fd0592ce7e1e310463c3f9edd2 Summary: Now that the new format is deployed, we don't need to check for old formats anymore. Remove the checks as well as associated tests that exercises the format upgrade path. Closes percona#296. Closes facebook/mysql-5.6#483 Differential Revision: D4355790 Pulled By: lth fbshipit-source-id: d1ba23f
george-lorch
pushed a commit
to george-lorch/percona-server
that referenced
this pull request
Feb 6, 2017
Upstream commit ID: e44e0b0892c726fd0592ce7e1e310463c3f9edd2 Summary: Now that the new format is deployed, we don't need to check for old formats anymore. Remove the checks as well as associated tests that exercises the format upgrade path. Closes percona#296. Closes facebook/mysql-5.6#483 Differential Revision: D4355790 Pulled By: lth fbshipit-source-id: d1ba23f
george-lorch
pushed a commit
to george-lorch/percona-server
that referenced
this pull request
Feb 6, 2017
Upstream commit ID: e44e0b0892c726fd0592ce7e1e310463c3f9edd2 Summary: Now that the new format is deployed, we don't need to check for old formats anymore. Remove the checks as well as associated tests that exercises the format upgrade path. Closes percona#296. Closes facebook/mysql-5.6#483 Differential Revision: D4355790 Pulled By: lth fbshipit-source-id: d1ba23f
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Apr 23, 2020
Summary: Now that the new format is deployed, we don't need to check for old formats anymore. Remove the checks as well as associated tests that exercises the format upgrade path. Closes percona#296. Closes facebook/mysql-5.6#483 Differential Revision: D4355790 Pulled By: lth fbshipit-source-id: d1ba23f fbshipit-source-id: 36860c3be3c
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Feb 24, 2021
Summary: Now that the new format is deployed, we don't need to check for old formats anymore. Remove the checks as well as associated tests that exercises the format upgrade path. Closes percona#296. Closes facebook/mysql-5.6#483 Differential Revision: D4355790 Pulled By: lth fbshipit-source-id: d1ba23f fbshipit-source-id: 36860c3be3c
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Nov 15, 2021
Summary: Now that the new format is deployed, we don't need to check for old formats anymore. Remove the checks as well as associated tests that exercises the format upgrade path. Closes percona#296. Closes facebook/mysql-5.6#483 Differential Revision: D4355790 (facebook/mysql-5.6@e44e0b0) Pulled By: lth fbshipit-source-id: 0dabcfc5b3b
ldonoso
pushed a commit
to ldonoso/percona-server
that referenced
this pull request
Mar 15, 2022
Summary: Now that the new format is deployed, we don't need to check for old formats anymore. Remove the checks as well as associated tests that exercises the format upgrade path. Closes percona#296. Closes facebook/mysql-5.6#483 Differential Revision: D4355790 Pulled By: lth
inikep
pushed a commit
to inikep/percona-server
that referenced
this pull request
Apr 9, 2024
Summary: Now that the new format is deployed, we don't need to check for old formats anymore. Remove the checks as well as associated tests that exercises the format upgrade path. Closes percona#296. Closes facebook/mysql-5.6#483 Differential Revision: D4355790 Pulled By: lth
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 5.7 port added allocation of acl_utility_user.auth_string in
acl_init_utility_user without a corresponding deallocation in
acl_free_utility_user. Fixed by adding it, and by moving the
allocation to the start of acl_init_utility_user next to the other
allocations to ensure proper cleanup in case of early returns.
http://jenkins.percona.com/job/mysql-5.7-param/70/