Skip to content

Conversation

@mellyeliu
Copy link
Member

Pushed up a bad revision in #1272, re-tweaking priorityForAtRule

Also simplifying some of the logic in createTheme as the default at-rule behaviour was previously forked

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 13, 2025
@github-actions
Copy link

github-actions bot commented Oct 13, 2025

workflow: benchmarks/perf

Comparison of performance test results, measured in operations per second. Larger is better.

benchmarks@0.16.1 compare
node ./compare.js /tmp/tmp.xdcFVPMYKE /tmp/tmp.AD1yAxTV2z

Results Base Patch Ratio
babel-plugin: stylex.create
· basic create 613 583 0.95 -
· complex create 180 188 1.04 +
babel-plugin: stylex.createTheme
· basic themes 432 440 1.02 +
· complex themes 41 41 1.00
@github-actions
Copy link

github-actions bot commented Oct 13, 2025

workflow: benchmarks/size

Comparison of minified (terser) and compressed (brotli) size results, measured in bytes. Smaller is better.

benchmarks@0.16.1 compare
node ./compare.js /tmp/tmp.m8550aInVY /tmp/tmp.Ukzb2WKxMs

Results Base Patch Ratio
@stylexjs/stylex/lib/cjs/stylex.js
· compressed 1,278 1,278 1.00
· minified 3,986 3,986 1.00
@stylexjs/stylex/lib/cjs/inject.js
· compressed 1,223 1,223 1.00
· minified 3,216 3,216 1.00
benchmarks/size/.build/bundle.js
· compressed 496,650 496,650 1.00
· minified 4,847,840 4,847,840 1.00
benchmarks/size/.build/stylex.css
· compressed 99,853 99,853 1.00
· minified 747,541 747,541 1.00
@mellyeliu mellyeliu marked this pull request as ready for review October 13, 2025 05:20
@mellyeliu mellyeliu merged commit 4a6d8bd into main Oct 13, 2025
9 checks passed
@mellyeliu mellyeliu deleted the defineVars-tweak branch October 13, 2025 06:30
hiteshshetty-dev pushed a commit to hiteshshetty-dev/stylex that referenced this pull request Nov 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

3 participants