Skip to content

Conversation

@mellyeliu
Copy link
Member

Need to wrap ltr string in at-rule after unforking logic in #1274

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 13, 2025
@github-actions
Copy link

github-actions bot commented Oct 13, 2025

workflow: benchmarks/perf

Comparison of performance test results, measured in operations per second. Larger is better.

benchmarks@0.16.1 compare
node ./compare.js /tmp/tmp.zpw5KVvy0Z /tmp/tmp.HRiOaOhYER

Results Base Patch Ratio
babel-plugin: stylex.create
· basic create 619 616 1.00 -
· complex create 180 190 1.06 !!
babel-plugin: stylex.createTheme
· basic themes 446 443 0.99 -
· complex themes 42 41 0.98 -
@github-actions
Copy link

github-actions bot commented Oct 13, 2025

workflow: benchmarks/size

Comparison of minified (terser) and compressed (brotli) size results, measured in bytes. Smaller is better.

benchmarks@0.16.1 compare
node ./compare.js /tmp/tmp.PxjI0gqmjX /tmp/tmp.waMrbqkwAw

Results Base Patch Ratio
@stylexjs/stylex/lib/cjs/stylex.js
· compressed 1,278 1,278 1.00
· minified 3,986 3,986 1.00
@stylexjs/stylex/lib/cjs/inject.js
· compressed 1,223 1,223 1.00
· minified 3,216 3,216 1.00
benchmarks/size/.build/bundle.js
· compressed 496,650 496,650 1.00
· minified 4,847,840 4,847,840 1.00
benchmarks/size/.build/stylex.css
· compressed 99,853 99,853 1.00
· minified 747,541 747,541 1.00
@mellyeliu mellyeliu marked this pull request as ready for review October 13, 2025 19:46
@Prakshal-Jain Prakshal-Jain reopened this Oct 13, 2025
@mellyeliu mellyeliu merged commit 94b6f55 into main Oct 13, 2025
16 checks passed
@mellyeliu mellyeliu deleted the createTheme-fix branch October 13, 2025 20:24
hiteshshetty-dev pushed a commit to hiteshshetty-dev/stylex that referenced this pull request Nov 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

3 participants