My dev

[Hanbing59]

Fixed several typos in the documentation and exchanged the names of two variables in a source code file to make it less confused.

[tmayerguerr]

Hi Hanbing,

Thank you for your contribution. Can you split the PR into smaller PRs? Unfortunately, I don't know how to do that.

• The corrections to the typos are all fine, and I would like to accept them directly.
• source/plot/plotMapLayer.cpp: I need to take a closer look at the code changes. It's easier for me if you split improvements to the documentation and changes to the code into different PRs.
• source/classes/condition/condition.h: You are right that the escaping of the various parsers needs to be clarified. First the Text parser with # as escaping is applied. In my understanding the regex parser uses \ as escape. So in my opinion the escape sequence should be \#{. But there actually seems to be a bug in it. I'll have to take a closer look at that. Wildcards (?*) are not supported at the moment, but this could easily be added. Therefore, I would like to postpone the PR for this.

Thanks again. You really make GROOPS better.
Best regards
Torsten

[tmayerguerr]

Hi Hanbing,

I have already fixed the bug regarding the parser. In addition, condition now supports wildcards.

Best
Torsten

[Hanbing59]

source/plot/plotMapLayer.cpp: I need to take a closer look at the code changes. It's easier for me if you split improvements to the documentation and changes to the code into different PRs.

Hi Torsten,

I opened a new PR(#403) for the commit(3ba6ac9). The commit history may look a little bit messy as I am also not very familiar with the workflow. I hope somehow, I made it not very troublesome for you

Regards,
Hanbing

[Hanbing59]

The corrections to the typos are all fine, and I would like to accept them directly.

A new PR(#404 ) with only typo-fixings have been made.

[Hanbing59]

• In my understanding the regex parser uses \ as escape. So in my opinion the escape sequence should be #{

Hi Torsten,

by ##{, I mean, if I want to use a regex expression which contains { as part of the regex itself (not a literal "{"), it seems that, I need to escape the text parser twice as the input pattern would be processed by the text parser two times. For example, if I want to use the regex ^L.{2}$ to match 3-char RINEX-3 like phase observation types, I need to actually input ^L.##{2}$ to get a regex expression of ^L.{2}$.

I realized that you have update the code, so this issue may not exist anymore.

Regards,
Hanbing