Revert tui code so it does not rely on in-process app server#14899
Merged
etraut-openai merged 2 commits intomainfrom Mar 17, 2026
Merged
Revert tui code so it does not rely on in-process app server#14899etraut-openai merged 2 commits intomainfrom
etraut-openai merged 2 commits intomainfrom
Conversation
Collaborator
Author
|
@codex review |
Contributor
|
Codex Review: Didn't find any major issues. Swish! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
dylan-hurd-oai
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #14512 added an in-process app server and started to wire up the tui to use it. We were originally planning to modify the
tuicode in place, converting it to use the app server a bit at a time using a hybrid adapter. We've since decided to create an entirely new paralleltui_app_serverimplementation and do the conversion all at once but retain the existingtuiwhile we work the bugs out of the new implementation.This PR undoes the changes to the
tuimade in the PR #14512 and restores the old initialization to its previous state. This allows us to modify thetui_app_serverwithout the risk of regressing the oldtuicode. For example, we can start to remove support for all legacy core events, like the ones that PR #14892 needed to ignore.Testing:
tuistarts and shuts down without a problem.