Conversation
viyatb-oai
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
This is effectively a follow-up to #15812. That change removed the special skill-script exec path, but
skill_metadatawas still being threaded through command-approval payloads even though the approval flow no longer uses it to render prompts or resolve decisions.Keeping it around added extra protocol, schema, and client surface area without changing behavior.
Removing it keeps the command-approval contract smaller and avoids carrying a dead field through app-server, TUI, and MCP boundaries.
What changed
ExecApprovalRequestSkillMetadataand the correspondingskillMetadatafield from core approval events and the v2 app-server protocolskillMetadataTesting
cargo test -p codex-app-server-protocolcargo test -p codex-protocolcargo test -p codex-app-server-test-clientcargo test -p codex-mcp-serverjust argument-comment-lint