Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
This continues the
codex-toolsmigration by moving another passive tool-spec layer out ofcodex-core.After
ToolSpecmoved intocodex-tools,codex-corestill ownedConfiguredToolSpecandcreate_tools_json_for_responses_api(). Both are data-model and serialization helpers rather than runtime orchestration, so keeping them incore/src/tools/registry.rsandcore/src/tools/spec.rsleft passive tool-definition code coupled tocodex-corelonger than necessary.What changed
ConfiguredToolSpecintocodex-rs/tools/src/tool_spec.rscreate_tools_json_for_responses_api()intocodex-rs/tools/src/tool_spec.rscodex-rs/tools/src/lib.rs, which remains exports-onlycore/src/client.rs,core/src/tools/registry.rs, andcore/src/tools/router.rsto consume the extracted types and serializer fromcodex-toolscodex-rs/tools/src/tool_spec_tests.rsConfiguredToolSpec::name()core/src/tools/spec_tests.rsto use the extractedConfiguredToolSpec::name()directly and removed the now-redundant localtool_name()helpercodex-rs/tools/README.mdso the crate boundary reflects the newly extracted tool-spec wrapper and serialization helperTest plan
cargo test -p codex-toolsCARGO_TARGET_DIR=/tmp/codex-core-configured-spec cargo test -p codex-core --lib tools::spec::CARGO_TARGET_DIR=/tmp/codex-core-configured-spec cargo test -p codex-core --lib client::just fix -p codex-tools -p codex-corejust argument-comment-lintReferences