CallToFunctionStatementWithoutSideEffectsRule checks the purity of array_filter(), array_map(), and array_reduce()

[zonuexe]

resolve phpstan/phpstan#11101

The following functions can also cause side effects via callbacks, but since they are used infrequently and the processing is more complex, it is sufficient to follow the existing functionMetadata.

• array_udiff_assoc()
• array_udiff_uassoc()
• array_uintersect()
• array_uintersect_assoc()
• array_uintersect_uassoc()

phpstan-src/resources/functionMetadata.php

Lines 721 to 728 in 66a2fd0

	'array_udiff' => ['hasSideEffects' => false],
	'array_udiff_assoc' => ['hasSideEffects' => false],
	'array_udiff_uassoc' => ['hasSideEffects' => false],
	'array_uintersect' => ['hasSideEffects' => false],
	'array_uintersect_assoc' => ['hasSideEffects' => false],
	'array_uintersect_uassoc' => ['hasSideEffects' => false],
	'array_unique' => ['hasSideEffects' => false],
	'array_unshift' => ['hasSideEffects' => true],

[staabm]

Another case which should be tested: phpstan/phpstan#11100

[staabm]

We should test cases in which the callback is impure, e.g. because of calls to impure functions or access to global variables or similar from within the callable

[ondrejmirtes]

It's not sufficient to handle this in a rule. It needs to be considered in NodeScopeResolver, so that the statements produce or not produce impurePoints.

[ondrejmirtes]

This is a wrong direction. We need something like @phpstan-pure-unless-callable-is-impure $callable.