Implement @pure-unless-callable-impure#3482
Conversation
There was a problem hiding this comment.
Will be replaced by phpstan/phpdoc-parser#253
There was a problem hiding this comment.
WIP. = false will be removed.
|
Just updated phpdoc-parser here so you can use that. |
zonuexe
force-pushed
the
feature/pure-unless-callable-is-impure
branch
4 times, most recently
from
eddd22a to
f207c72
Compare
zonuexe
force-pushed
the
feature/pure-unless-callable-is-impure
branch
from
f207c72 to
8c756cc
Compare
|
@zonuexe any plans to move this forward? |
|
@staabm Hi, I know this branch is important but it was blocked due to my motivation. I'm going to rebase it on 2.0.x and do the necessary work. If I miss it tonight, I won't be able to start the rest of the work until next week, so it would be quicker for you to take over then. |
|
I don't want to put pressure on you. It was not clear to me whether you stopped working on it or not. I am totally fine if this takes a bit more time - thank you |
zonuexe
force-pushed
the
feature/pure-unless-callable-is-impure
branch
from
8c756cc to
389c7f0
Compare
|
No problem, this is a very interesting subject for me too, so I'm happy to work on it because I realized that there are other people who are interested in it. More importantly, I'm always helped by your hard work. |
zonuexe
force-pushed
the
feature/pure-unless-callable-is-impure
branch
4 times, most recently
from
2146ae0 to
1cc1fad
Compare
|
Friendly ping @zonuexe, still interested in this PR ? Do you have time to finish it ? |
|
@VincentLanglet |
zonuexe
force-pushed
the
feature/pure-unless-callable-is-impure
branch
from
adb02ca to
abc8cd8
Compare
zonuexe
force-pushed
the
feature/pure-unless-callable-is-impure
branch
from
abc8cd8 to
c4999be
Compare
|
Friendly ping @zonuexe I don't want to put pressure on you. It's just not clear to me whether you stopped working on it or not. It will unblock the phpstan/phpdoc-parser#259 pr :) |
|
Maybe I'm wrong, but I start to think this annotation is useless PHPStan already handle cb with immediately/later invoked callable, even for a pure function/method. So we just need to declare array_map and so as pure. |
|
i'm happy to help contribute towards a solution if it's decided which direction is best. |
|
Hi @devbanana feel free to work on this. Laybe @zonuexe could explain what he had in mind ; or @ondrejmirtes will have some guidelines |
5 participants
This PR is still a work in progress, no tests or rules have been added yet.
refs #3106, phpstan/phpstan#11100 and phpstan/phpstan#11710
closes phpstan/phpstan#11101
related issue phpstan/phpdoc-parser#253