php while loop error using mysql_fetch_array

Question

I can't see the:

Warning: mysql_fetch_array(): supplied argument is not a valid MySQL result resource

Can anyone help as my code looks spot on:

<?php
//retreive questions from database and put into question box

$query = "SELECT `QuestionId`, `Question`, `Opt1`, `Opt2`, `Opt3`, `Opt4`,`Answer` FROM `pf_questions`";

$question = mysql_query($query);

while($row = mysql_fetch_array($question)){

    $id         = $row['QuestionId'];
    $question   = $row['Question'];
    $opt1       = $row['Opt1'];
    $opt2       = $row['Opt2'];
    $opt3       = $row['Opt3'];
    $opt4       = $row['Opt4'];
    $answer     = $row["Answer"];

?>
<div id="ContainerQuestion">
    <span class="Question">Question <?php echo $id; ?>. <?php echo $question; ?></span>

        <p><input type=radio name='q<?php echo $id; ?>' value="<?php echo $opt1; ?>"> <?php echo $opt1; ?> </p>
        <p><input type=radio name='q<?php echo $id; ?>' value="<?php echo $opt2; ?>"> <?php echo $opt2; ?> </p>
        <p><input type=radio name='q<?php echo $id; ?>' value="<?php echo $opt3; ?>"> <?php echo $opt3; ?> </p>

        <p><input type=radio name='q<?php echo $id; ?>' value="<?php echo $opt4; ?>"> <?php echo $opt4; ?> </p>


</div>
<?php
}

Have tried the mysql_error() and nothing gets outputted so i'm assuming my query is correct?

many thanks

Fluffeh · Accepted Answer · 2012-08-24 08:59:39Z

2

You don't seem to make the mysql connection anywhere in your code at all. Are you sure there is a valid connection to the database?

Secondly, it would be rather advisable to swap over to PDO which is much safer, shinier and better than the old mysql_* functions.

Having said that, you need to use something like the following to connect using the oder functions:

mysql_connect("localhost", "mysql_user", "mysql_password") or
    die("Could not connect: " . mysql_error());
mysql_select_db("mydb");

Edit:

Could you add the following section of code and let me know the output?

$query = "SELECT `QuestionId`, `Question`, `Opt1`, `Opt2`, `Opt3`, `Opt4`,`Answer` FROM `pf_questions`";
$question = mysql_query($query);
$num_rows = mysql_num_rows($question);
echo "$num_rows Rows<br>";

edited Aug 24, 2012 at 8:59

answered Aug 24, 2012 at 8:36

Fluffeh

33.6k16 gold badges69 silver badges80 bronze badges

Sign up to request clarification or add additional context in comments.

8 Comments

user1611341 Over a year ago

im just putting it together as quick as with the knowledge I have: not really touched on PDO but know its something I've got to do.

user1611341 Over a year ago

mysql connection happens inside an init.php file in the core folder

Fluffeh Over a year ago

Okay, give that a go then, but swapping over to PDO is a really good idea :)

user1611341 Over a year ago

its pulling in the first question and the appropriate $opt variables, just not the rest :(

user1611341 Over a year ago

twenty rows in total and only the first question shows in the while loop - nothing else is shown, no questions and no options

|

Aerilys · Accepted Answer · 2012-08-24 08:36:40Z

0

Sounds like your query is invalid, so the question variable doesn't contain what mysql_fetch_array is waiting for.

answered Aug 24, 2012 at 8:36

Aerilys

1,6491 gold badge16 silver badges22 bronze badges

Comments

Anil agrahari · Accepted Answer · 2012-08-24 08:43:55Z

0

It seems that you have something missing in your mysql query, please match the fields (also match for lower case and uppercase) from the actual tables in the DB.

Also sometimes ` is not supported hence remove from all the fields and table name. Probably it will solve your issue.

answered Aug 24, 2012 at 8:43

Anil agrahari

3402 gold badges9 silver badges26 bronze badges

2 Comments

Anil agrahari Over a year ago

what do you mean by "its pulling in the first question and the appropriate $opt variables "...is that it's displaying only one equestion and it'soptions?

Anil agrahari Over a year ago

kindly make your div id dynamic '<div id="ContainerQuestion">' it should be id="ContainerQuestion1" then id="ContainerQuestion2" then id="ContainerQuestion3"...so on...

AlexeyKa · Accepted Answer · 2012-08-24 08:49:59Z

Don`t use mysql_* functions.

$question = mysql_query($query);

What happens if query is failed? Or if mysql server return 0 rows? From manual: "For SELECT, SHOW, DESCRIBE, EXPLAIN and other statements returning resultset, mysql_query() returns a resource on success, or FALSE on error."

if ( !$question ) {
    //Query is failed. 
    echo mysql_error(), $query; //for developer use. if error happens - you will see what happens
    exit(); //or something else you want
}

if ($question && mysql_num_rows($question) > 0) {
    while($row = mysql_fetch_array($question)){
       .....
    }
} else {
    // mysql server return 0 rows
}

Collectives™ on Stack Overflow

php while loop error using mysql_fetch_array

4 Answers 4

8 Comments

Comments

2 Comments

Comments

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

8 Comments

Comments

2 Comments

Comments

Related