PHP Variable in MySQL Query

Question

I have this code which is not working

  <body>
<?php $outerSql = mysql_query("select * from gree_menu"); ?>
<ul>
  <?php
    while($outerRow = mysql_fetch_array($outerSql)) {
      $outerMenu = $outerRow['menu_name'];
      $outerId = $outerRow['menu_id'];
    ?>
      <li>
        <?=$outerMenu; ?>
        <?php $innerSql = mysql_query("SELECT sp.* FROM gree_menu gm INNER JOIN silicon_prod sp ON gm.menu_id = sp.menu_parent_id WHERE gm.menu_id = {$outerID}");?>

        <ul>
          <?php

            while($innerRow = mysql_fetch_array($innerSql)) {
              $innerMenu = $innerRow['prod_name'];
          ?>
            <li><?= $innerMenu;?></li>
            <?php
            }
            ?>
        </ul>
      </li>
    <?php 
    } 
    ?>

</ul>

The line that is causing me trouble is

 <?php $innerSql = mysql_query("SELECT sp.* FROM gree_menu gm INNER JOIN silicon_prod sp ON gm.menu_id = sp.menu_parent_id WHERE gm.menu_id = {$outerID}");?>

If i give the query as

 <?php $innerSql = mysql_query("SELECT sp.* FROM gree_menu gm INNER JOIN silicon_prod sp ON gm.menu_id = sp.menu_parent_id WHERE gm.menu_id = 7");?>

it works fine. But i want it to be dynamic. Valid values for menu_id are 7, 8, 9

Please help

You made a typo, it should be outerID, not outerId. PHP is case sensitive. I recommend using copy/paste for variable names, or using a text editor that has autocomplete (try out Sublime Text or Eclipse). Using either copy/paste or autocomplete will save you time and frustration by reducing typos like this one. — Abhi Beckert
– Abhi Beckert, Commented Oct 20, 2012 at 7:13

Abubakkar · Accepted Answer · 2012-10-20 07:08:56Z

2

Try this

<?php $innerSql = mysql_query("SELECT sp.* FROM gree_menu gm INNER JOIN silicon_prod sp ON gm.menu_id = sp.menu_parent_id WHERE gm.menu_id =".{$outerID});?>

answered Oct 20, 2012 at 7:08

Abubakkar

15.7k8 gold badges58 silver badges84 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Justin John · Accepted Answer · 2012-10-20 07:30:51Z

2

Your have typo in outerID, not outerId as mentioned by @Abhi Beckert.

$outerId = $outerRow['menu_id'];

You used $outerID in query. So I don't think your query have errors. Correct the typo and try again.

If you like to change the query try like below

$innerSql = mysql_query("SELECT sp.* FROM gree_menu gm 
          INNER JOIN silicon_prod sp ON gm.menu_id = sp.menu_parent_id
          WHERE gm.menu_id = ".$outerId);

edited Oct 20, 2012 at 7:30

answered Oct 20, 2012 at 7:23

Justin John

9,74814 gold badges73 silver badges131 bronze badges

Comments

Md. Mahabubur Rahman · Accepted Answer · 2012-10-20 07:28:03Z

0

You may try this one

 <?php $innerSql = mysql_query("SELECT sp.* FROM gree_menu gm INNER JOIN silicon_prod sp ON gm.menu_id = sp.menu_parent_id WHERE gm.menu_id = ".$outerID."");?>

answered Oct 20, 2012 at 7:28

Md. Mahabubur Rahman

8201 gold badge8 silver badges21 bronze badges

Comments

Mohit Bumb · Accepted Answer · 2012-10-20 07:29:02Z

0

<?php $innerSql = mysql_query("SELECT sp.* FROM gree_menu gm INNER JOIN silicon_prod sp ON gm.menu_id = sp.menu_parent_id WHERE gm.menu_id = ".$outerID);?>

answered Oct 20, 2012 at 7:29

Mohit Bumb

2,4935 gold badges33 silver badges54 bronze badges

Comments

Arun Killu · Accepted Answer · 2012-10-20 07:29:36Z

0

mysql_query("SELECT sp.* FROM gree_menu gm 
INNER JOIN silicon_prod sp ON gm.menu_id = sp.menu_parent_id 
WHERE gm.menu_id =$outerID");

answered Oct 20, 2012 at 7:29

Arun Killu

14.3k5 gold badges38 silver badges66 bronze badges

Collectives™ on Stack Overflow

PHP Variable in MySQL Query

5 Answers 5

Comments

Comments

Comments

Comments

Comments

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

Comments

Comments

Comments

Comments

Comments

Related