Creating and populating a generic list

Question

I would like to know if this is being done correctly.

using System;
using System.Collections;
using System.Collections.Generic;
using System.Data;
using System.Diagnostics;
using System.Linq;
using System.Text;

public class InnerJoinTables
{

    public List<InnerJoinTable> Items = new List<InnerJoinTable>();

}

public class InnerJoinTable
{
    public int ID { get; set; }
    public string RightTable { get; set; }
    public string LeftTable { get; set; }

    public InnerJoinTable(int ID, string RightTable, string LeftTable)
    {
        this.ID = ID;
        this.RightTable = RightTable;
        this.LeftTable = LeftTable;
    }
}

Calling code:

InnerJoinTables m = new InnerJoinTables();

m.Items.Add(new InnerJoinTable(1, "A", "B"));

Does it seem to work? What exactly are you worried about? Why do you think it might not be the correct way? — svick
– svick, Commented Mar 16, 2013 at 14:15
You can achieve the same result using a stored procedure, an ORM or LINQ. What do you find the need to implement this join yourself? — Leonid
– Leonid, Commented Mar 16, 2013 at 16:30

svick · Accepted Answer · 2013-03-16 14:18:36Z

6

The code will work, so from that point of view, it is correct.

But there are also some issues with it:

I don't see any reason for the InnerJoinTables class to exist. You should just use List<InnerJoinTable> directly in the calling code. That's unless there's something else going on that you're not showing.
Public fields should not be used. Use a property instead.

answered Mar 16, 2013 at 14:18

svick

24.5k4 gold badges53 silver badges89 bronze badges

Add a comment |

Vivek Dixit · Accepted Answer · 2013-03-19 12:11:38Z

0

You can directly derive your InnerJoinTables class with List. Then you can use it as normal list object. No need of having items as member there.

answered Mar 19, 2013 at 12:11

Vivek Dixit

11 bronze badge

2

\$\begingroup\$ This is not necessarily a good idea. I prefer composition over inheritance, given a choice. \$\endgroup\$

Brian
– Brian

2013-03-19 13:14:28 +00:00
Commented Mar 19, 2013 at 13:14
\$\begingroup\$ Could you explain how is that better than using List directly? \$\endgroup\$

svick
– svick

2013-03-20 22:39:53 +00:00
Commented Mar 20, 2013 at 22:39
\$\begingroup\$ It just change the way you would use that object in your code. If you have an InnerJoinTables and Items as collection of InnerJoinTable object. Each time you want to access the object you would write innerJoinTables.Items.Add(). If you just have it derived with list then it would be like innerJoinTables.Add(new InnerJoinTable()), that's why I thought its better than using list directly. \$\endgroup\$

Vivek Dixit
– Vivek Dixit

2013-04-09 08:09:51 +00:00
Commented Apr 9, 2013 at 8:09

Add a comment |

Stack Exchange Network

Creating and populating a generic list

2 Answers 2

You must log in to answer this question.

Hot Network Questions

Creating and populating a generic list

2 Answers 2

You must log in to answer this question.

Related

Hot Network Questions