Better pattern than large if/else if/else for checking conditionals [duplicate]

Question

I've got a fairly large set of booleans I'm checking in javascript, and then using them to alter the state of a layout in my React app. The whole thing is unwieldy, difficult to read, inelegant, and feels terribly amateurish. I was wondering if there was a better pattern for handling something like this.

Example code snippet (in coffeescript). Replaced object variables with ints for brevity:

setNeeded = _.contains(sessionInitialStates, codingSession.state)
sessionUpdating = codingSession.state is 'UPDATING'
sessionFailed = codingSession.state is 'FAILED'
setExtended = _.contains extStates, codingSession.state
setInReview = _.contains(reviewStates, controlSet.state) or
  _.contains(controlSetSyncStates, controlSet.state)
sessionIsTagging = _.contains tagStates, codingSession.state
sessionComplete = codingSession.state is 'COMPLETE'
sessionIsNew = _.isEmpty(codingSession.state) or
  codingSession.state is 'CREATED'

commError = controlSet.state is 'COMMUNICATION_ERROR'
if setNeeded and @props.creds
  someVar = 1

else if _.contains(sessionInitialStates, codingSession.state) and
    controlSet.state is 'PROCESSING_FAILED'
  someVar = 2

else if codingSession.state is 'CONTROL_SET_GENERATION' and
    controlSet.state is 'SELECTION_FAILED' and @props.creds
  someVar = 3

else if !sessionIsTagging or !sessionComplete
  if _.isEmpty @props.connector
    someVar = 4

  else if [email protected]
    someVar = 5

  else if sessionFailed
    someVar = 6

  else if sessionIsNew
    someVar = 7

  else if sessionUpdating
    someVar = 8

  else if setInReview and !setExtended
    someVar = 9

see also Elegant ways to handle if(if else) else

gnat
– gnat

2015-02-19 08:31:25 +00:00
Commented Feb 19, 2015 at 8:31 — gnat
– gnat, Commented Feb 19, 2015 at 8:31

Community · Accepted Answer · 2017-04-13 12:40:37Z

0

When you notice large blocks of if/else, it usually means that your class or method is doing too much.

Instead of trying to rewrite the logic inside the method:

Ensure the method does one and one only thing.
Replace the class by multiple classes which inherit from a common one.

For practical examples, if you have an actual working piece of code but contains too much if/else statements, you may post it on CodeReview.SE.

edited Apr 13, 2017 at 12:40

CommunityBot

1

answered Feb 18, 2015 at 23:02

Arseni Mourzenko

139k32 gold badges360 silver badges544 bronze badges

Add a comment |

Stack Exchange Network

Better pattern than large if/else if/else for checking conditionals [duplicate]

1 Answer 1

Linked

Hot Network Questions

Better pattern than large if/else if/else for checking conditionals [duplicate]

1 Answer 1

Linked

Related

Hot Network Questions