JavaScript: Accessing Nested Objects

Question

The code looks like this

function Scripts() {this.FindById = function (id) {
    this.FindById.constructor.prototype.value = function () {
        return document.getElementById(id).value;

    }}}

var Control = new Scripts();

Now when i say Control.FindById("T1").value(). I am not able to get the textInput("T1")'s value.

Ja͢ck · Accepted Answer · 2012-06-13 06:16:38Z

1

It seems that your code is a bit more complicated then it should be ;-)

Personally I would write it this way (not tested):

function Scripts() {
  this.findById = function(id) {
    var el = document.getElementById(id);

    return {
      value: function() { 
        return el.value;
      }
    }
  }
}

The findById() now closes over a node and returns an interface that can return its value.

Also, your idea sounds a lot like Singleton, so you wouldn't even need the extra Scripts constructor:

var Control = {
    findById: function(id) {
        var el = document.getElementById(id);

        return {
            value: function() { 
                return el.value;
            }
        }
    }
}

Working example: http://jsfiddle.net/YYkD7/

edited Jun 13, 2012 at 6:16

answered Jun 13, 2012 at 5:21

Ja͢ck

174k39 gold badges269 silver badges317 bronze badges

Sign up to request clarification or add additional context in comments.

5 Comments

Rakesh Over a year ago

Sorry my mistake it is return document.getElementById(id).value. I dont know how "=" came in between

Ja͢ck Over a year ago

@Rakesh sorry to hear that, but here's a working fiddle: jsfiddle.net/YYkD7

Rakesh Over a year ago

sorry, it was working fine just that i dint check it properly.Thanks for the help man. I have on more question. How can i have more methods similar to "value" inside "FindById". Something like this var Control = { findById: function(id) { var el = document.getElementById(id); return { value: function() { return el.value; } } } }

Ja͢ck Over a year ago

@Rakesh You can just add your function after the value: function() { ... } definition.

Rakesh Over a year ago

Thanks mate, found out it has to be comma separated :).

Anonymous · Accepted Answer · 2012-06-13 05:27:09Z

0

Try this:

function Scripts() {this.FindById = function (id) {
    this.FindById.constructor.prototype.value = function () {
        return document.getElementById(id).value
    }}}

You didn't close the last "}" :-)

answered Jun 13, 2012 at 5:27

Anonymous

4,64110 gold badges66 silver badges99 bronze badges

Collectives™ on Stack Overflow

JavaScript: Accessing Nested Objects

2 Answers 2

5 Comments

Comments

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

5 Comments

Comments

Related