Inserting php array data into mysql isn't working

Question

Hello I have an array $name[] that I am trying to insert into the second field of my table but it's not working (table remains completely blank). I cannot find the error in my code what am I doing wrong?

$username="us";
$password="pw";
$database="db";
mysql_connect(localhost,$username,$password);
@mysql_select_db($database) or die( "error");

$i=0;
while ($i < 5) {


$query = "INSERT INTO table VALUES ('','$name[i]','','')";
mysql_query($query);

$i++
}

mysql_close();

Any ideas please? Thank you.

Protip: using a for-loop will save you 2 lines of code. for ($i = 0; $i < 5; $i++) { ... } — Matt Huggins
– Matt Huggins, Commented Oct 18, 2009 at 19:51
This solved it. There is an error in the above in the while loop, I don't know what it is. But replacing the while loop with the for loop solves it. — David Willis
– David Willis, Commented Oct 18, 2009 at 20:13

Gumbo · Accepted Answer · 2009-10-18 19:47:18Z

5

You used a constant i instead of $i for the key of $name. So try this:

"INSERT INTO table VALUES ('','".$name[$i]."','','')"

You should also escape the value for the MySQL query using mysql_real_escape_string:

"INSERT INTO table VALUES ('','".mysql_real_escape_string($name[$i])."','','')"

answered Oct 18, 2009 at 19:47

Gumbo

657k112 gold badges792 silver badges852 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Matt Huggins Over a year ago

Or this: "INSERT INTO table VALUES ('','{$name[$i]}','','')"

user153498 · Accepted Answer · 2009-10-18 19:49:09Z

2

Well, first, all that will do is put an entry with columns 1, 3, and 4 blank, and column 2 with the value $name[i]. To have a variable in a string, it needs to be in double quotes. But I don't see the point of doing that when you can just have the variable.

Also, $name[i] is supposed to be $name[$i].

answered Oct 18, 2009 at 19:49

user153498

1 Comment

David Willis Over a year ago

I changed it to $name[$i] and it made no difference. I am leaving the other columns blank for now as I try and just get one column of data in and when it works I can get my other arrays into the columns.

Jason Keene · Accepted Answer · 2009-10-18 19:50:49Z

1

Make sure to escape when you are concatenating queries like that.

$query = "INSERT INTO table VALUES ('', '" . mysql_real_escape_string($name[$i]) . "', '', '')";

If you don't you might be vulnerable to SQL injection badness

answered Oct 18, 2009 at 19:50

Jason Keene

1,1953 gold badges12 silver badges20 bronze badges

Comments

Paige Ruten · Accepted Answer · 2009-10-18 19:47:30Z

0

Try running the query like this:

mysql_query($query) or die(mysql_error());

This will give you a better idea of what you're doing wrong if there's a problem with your query. You may also want to print your SQL for debugging:

echo "Query $i: $query<br />"

answered Oct 18, 2009 at 19:47

Paige Ruten

177k37 gold badges183 silver badges199 bronze badges

Collectives™ on Stack Overflow

Inserting php array data into mysql isn't working

4 Answers 4

1 Comment

1 Comment

Comments

Comments

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

1 Comment

1 Comment

Comments

Comments

Related