foreach loop returning 2 values from array

Question

I have a for each loop inside a function that i pass an office region too (101,102), it should loop thorugh the array to get the value in OLevel (Red,Amber,Yellow) of a matching OfficeRegion and return a value.

The issue im having is that only the first row in the array is returning a value and it always returns "#red#red", how can i stop it returning 2 values and make it loop through the entire array?

The array:

array(115) { 
    [0]=> object(stdClass)#93 (2) { ["OfficeRegion"]=> string(3) "101" ["OLevel"]=> string(1) "R" } 
    [1]=> object(stdClass)#94 (2) { ["OfficeRegion"]=> string(3) "102" ["OLevel"]=> string(1) "R" } 
    [2]=> object(stdClass)#95 (2) { ["OfficeRegion"]=> string(3) "103" ["OLevel"]=> string(1) "R" } 
    [3]=> object(stdClass)#96 (2) { ["OfficeRegion"]=> string(3) "201" ["OLevel"]=> string(1) "R" } 
    [4]=> object(stdClass)#97 (2) { ["OfficeRegion"]=> string(3) "202" ["OLevel"]=> string(1) "R" }
    [5]=> object(stdClass)#98 (2) { ["OfficeRegion"]=> string(3) "301" ["OLevel"]=> string(1) "R" } 
    [6]=> object(stdClass)#99 (2) { ["OfficeRegion"]=> string(3) "302" ["OLevel"]=> string(1) "R" } 
    [7]=> object(stdClass)#100 (2) { ["OfficeRegion"]=> string(3) "401" ["OLevel"]=> string(1) "R" } 
    [8]=> object(stdClass)#101 (2) { ["OfficeRegion"]=> string(3) "403" ["OLevel"]=> string(1) "R" } 
}

The for each:

foreach($sqlarray as $index => $columns) {
    foreach($columns as $key => $value) {
        if ($key == 'OfficeRegion' && $value == $OfficeRegion) {
            if($columns->OLevel == "R") {
                return '#red'; 
            } elseif ($columns->OLevel == "O")  {
                return '#amber'; 
            } elseif ($columns->OLevel == "Y")  {
                return '#yellow';
            } else {
                return '#green';
            }
        } elseif ($key == 'OfficeRegion' && $value != $OfficeRegion) {
            return "#green";
        }
    }
}

Any suggestions welcome! thanks

For one, you don't need a foreach for this. How are you calling the function? — ʰᵈˑ
– ʰᵈˑ, Commented Oct 23, 2014 at 11:57
Really? Calling function like so: GenerateKML::GetColour('101') — matt gooch
– matt gooch, Commented Oct 23, 2014 at 12:00
Why foreach, and why a nested loop? All you do is find the first element in the outer array that has a OfficeRegion key/property, you return. You're not processing the entire array — Elias Van Ootegem
– Elias Van Ootegem, Commented Oct 23, 2014 at 12:00
1. Get result set. 2. Loop through result set (displaying the results to the screen). 3. Call GetColour by passing in the current sub-array of the result set. 4. Modify GetColour to switch on the contents of OfficeRegion -> OLevel — ʰᵈˑ
– ʰᵈˑ, Commented Oct 23, 2014 at 12:02

Marcin Nabiałek · Accepted Answer · 2014-10-23 12:05:01Z

1

If $OfficeRegion is array, you should rather use code like this and you don't need inner loop here:

foreach($sqlarray as $index => $columns) {

    if (in_array($columns->OfficeRegion, $OfficeRegion)) {

        switch ($columns->OLevel) {
            case 'R':
                echo '#red';
            case 'O':
                echo '#amber';
            case 'Y':
                echo '#yellow';
            default:
                echo '#green';
        }
    } else {
        echo '#green';    
    }
}

I've also changed here return to echo to loop over all items as you probably want.

answered Oct 23, 2014 at 12:05

Marcin Nabiałek

112k43 gold badges271 silver badges299 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

matt gooch Over a year ago

Thanks i can see how that would be better, I change the in_array around as it was complaning about the 2nd value not being an array. This issue now is that it always returns the last else and echos '#green'

Collectives™ on Stack Overflow

foreach loop returning 2 values from array

1 Answer 1

1 Comment

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Related