Array values in SQL query?

Question

$sql = mysql_query("INSERT INTO `users` VALUES(
        '',
        '$form['name']',
        '$form['saddress']',
        '$form['apt']',
        '$form['zip']',
        '$form['homephone']',
        '$form['cellphone']',
        '$form['email']',
        '$form['    ']',
        '$form['city']',
        '$form['state']',
        '$form['country']',
        '$salt','$hash',
        '$form['username']'
    )");

How would I make that work? It's giving me Parse error: syntax error, unexpected T_ENCAPSED_AND_WHITESPACE, expecting T_STRING or T_VARIABLE or T_NUM_STRING

Why are dots necessary? I've never used them before when inserting normal variables into a SQL query. — Jason
– Jason, Commented Sep 23, 2011 at 1:45
you can use the dots of curly brace. I prefer the dots since it's easier to read. see Nexerus or rfausak answer and see what you prefer. — Book Of Zeus
– Book Of Zeus, Commented Sep 23, 2011 at 1:47

Rusty Fausak · Accepted Answer · 2011-09-23 01:46:05Z

2

Try using curly brackets around the variables, like this:

..
'{$form['name']}',
'{$form['saddress']}',
..

answered Sep 23, 2011 at 1:46

Rusty Fausak

7,5541 gold badge30 silver badges39 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Nexerus · Accepted Answer · 2011-09-23 01:58:51Z

1

Either by removing the single quotes from the $form['x'] or by doing something like:

mysql_query("INSERT INTO x VALUES(
  '" . mysql_real_escape_string($form['x']) . "',
  '" . mysql_real_escape_string($form['x']) . "'
");

Notice that there are double quotes inside the single quotes.

edited Sep 23, 2011 at 1:58

answered Sep 23, 2011 at 1:46

Nexerus

1,0867 silver badges8 bronze badges

Comments

Stephen · Accepted Answer · 2011-09-23 01:48:48Z

This is a classic problem that stems from PHP's ability to parse strings for variables, which can get confusing. I prefer to keep my variables outside of the strings, and concatenate when needed.

Here's what I would do:

$sql = mysql_query("INSERT INTO `users` VALUES('" .
    implode("','", array(
        "",
        $form['name'],
        $form['saddress'],
        $form['apt'],
        $form['zip'],
        $form['homephone'],
        $form['cellphone'],
        $form['email'],
        $form['    '],
        $form['city'],
        $form['state'],
        $form['country'],
        $salt,
        $hash,
        $form['username']
    )) . "')";
);

Collectives™ on Stack Overflow

Array values in SQL query?

3 Answers 3

Comments

Comments

Comments

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Related