Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The recent
codex-toolsmigration steps have moved shared tool models and low-coupling spec helpers out ofcodex-core, butcore/src/tools/spec.rsstill owned a large block of pure collaboration-tool spec construction. Those builders do not need session state or runtime behavior; they only need a small amount of core-owned configuration injected at the seam.Moving that cohesive slice into
codex-toolsmakes the crate boundary more honest and removes a substantial amount of passive tool-spec logic fromcodex-corewithout trying to move the runtime-coupled multi-agent handlers at the same time.What changed
agent_tool.rs,request_user_input_tool.rs, andagent_job_tool.rstocodex-tools, with sibling*_tests.rscoverage and an exports-onlylib.rsToolSpecbuilders for:spawn_agent,send_input,send_message,assign_task,resume_agent,wait_agent,list_agents, andclose_agentrequest_user_inputspawn_agents_on_csvandreport_agent_job_resultcore/src/tools/spec.rsto call the extracted builders while still supplying the core-owned inputs, such as spawn-agent role descriptions and wait timeout boundscore/src/tools/spec.rsseam tests to build expected collaboration specs throughcodex-toolscodex-rs/tools/README.mdso the crate documentation reflects the broader collaboration-tool boundaryTest plan
CARGO_TARGET_DIR=/tmp/codex-tools-collab-specs cargo test -p codex-toolsCARGO_TARGET_DIR=/tmp/codex-core-collab-specs cargo test -p codex-core --lib tools::spec::just fix -p codex-tools -p codex-corejust argument-comment-lintReferences