Skip to content

Support for @pure-unless-callable-is-impure#253

Merged
ondrejmirtes merged 1 commit into
phpstan:1.23.xfrom
staabm:pure-cb
Sep 26, 2024
Merged

Support for @pure-unless-callable-is-impure#253
ondrejmirtes merged 1 commit into
phpstan:1.23.xfrom
staabm:pure-cb

Conversation

@staabm

@staabm staabm commented Sep 18, 2024

Copy link
Copy Markdown
Contributor

required for phpstan/phpstan#11100

@staabm staabm marked this pull request as ready for review September 18, 2024 14:10
@ondrejmirtes

Copy link
Copy Markdown
Member

Pinging some people in the community about an opinion first, stay tuned :)

@ondrejmirtes

Copy link
Copy Markdown
Member

Decided to go for it. Other suggestions similar to how Hack handles things are more general, but very complicated to do right now.

@ondrejmirtes ondrejmirtes merged commit 6ca22b1 into phpstan:1.23.x Sep 26, 2024
@ondrejmirtes

Copy link
Copy Markdown
Member

Thank you!

@staabm staabm deleted the pure-cb branch September 26, 2024 07:55
@hrach

hrach commented Sep 26, 2024

Copy link
Copy Markdown

What a missed opportunity to name it @pure-iff-callable-is-pure

@ondrejmirtes

Copy link
Copy Markdown
Member

iff is something math nerds use 😂

@hrach

hrach commented Sep 26, 2024

Copy link
Copy Markdown

Maybe an alias? 😇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants