Skip to content

Support for @pure-unless-parameter-passed#259

Open
staabm wants to merge 1 commit into
phpstan:2.0.xfrom
staabm:pure-cb-param
Open

Support for @pure-unless-parameter-passed#259
staabm wants to merge 1 commit into
phpstan:2.0.xfrom
staabm:pure-cb-param

Conversation

@staabm

@staabm staabm commented Nov 18, 2024

Copy link
Copy Markdown
Contributor
@staabm staabm marked this pull request as ready for review November 18, 2024 15:47
@ondrejmirtes

Copy link
Copy Markdown
Member

We already have other similar implementation lined up. There's @pure-unless-callable-is-impure which is implemented in the parser (#253) but not yet in PHPStan (phpstan/phpstan-src#3482).

It's not a great look when there's a tag understood by the parser but not by the analyser. I'd like to minimize that coming into the future. It'd be nice to also have the implementation ready in phpstan-src before merging the parser countepart.

I will look at this again when phpstan/phpstan-src#3482 is merged and the implementation for @pure-unless-parameter-passed is ready in phpstan-src.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants