Get URL Parameters Using Javascript

Question

I am trying to get the ULR parameter, but my code does not run because at debugging it shows me an error which is: Cannot read property 'split' of undefined and I am not sure what I am doing wrong. For example: default.html?pid=405 I need to get in a JavaScript variable the 405 value. This is the code i am using:

<script type="text/javascript">
    function getUrlParameters(parameter, staticURL, decode) {
        var currLocation = (staticURL.length) ? staticURL : window.location.search,
            parArr = currLocation.split("?")[1].split("&"),
            returnBool = true;

        for (var i = 0; i < parArr.length; i++) {
            parr = parArr[i].value.split("=");
            if (parr[0] == parameter) {
                return (decode) ? decodeURIComponent(parr[1]) : parr[1];
                returnBool = true;
            } else {
                returnBool = false;
            }
        }

        if (!returnBool) return false;
    }
</script>

<script type="text/javascript">
    function runDepo()
    {
        var idParameter = getUrlParameters("pid", "", true);
    }

Can somebody help me? Thanks in advance.

Possible duplicate of How can I get query string values in JavaScript? — Ava
– Ava, Commented Apr 29, 2016 at 20:14
If parArr is actually an array then you would just use parArr[i].split("=") — Jonathan Michalik
– Jonathan Michalik, Commented Apr 29, 2016 at 20:16

Shady Alset · Accepted Answer · 2016-04-29 20:47:16Z

2

Just remove .value from parr = parArr[i].value.split("=");

function getUrlParameters(parameter, staticURL, decode) {
        var currLocation = (staticURL.length) ? staticURL : window.location.search,
            parArr = currLocation.split("?")[1].split("&"),
            returnBool = true;

        for (var i = 0; i < parArr.length; i++) {
            parr = parArr[i].split("=");
            if (parr[0] == parameter) {
                return (decode) ? decodeURIComponent(parr[1]) : parr[1];
                returnBool = true;
            } else {
                returnBool = false;
            }
        };

        if (!returnBool) return false;
    };
    
    document.getElementById('Result').value = getUrlParameters("pid", "default.html?pid=405", true);

    alert(getUrlParameters("pid", "default.html?pid=405", true));

PID : <input type="text" id="Result" placeholder="Result">

edited Apr 29, 2016 at 20:47

answered Apr 29, 2016 at 20:19

Shady Alset

5,7044 gold badges24 silver badges36 bronze badges

Sign up to request clarification or add additional context in comments.

5 Comments

Lanshore Over a year ago

I tried this, but should I have to code this alert(getUrlParameters("pid", "default.html?pid=405", true)); is there any way not to have to write it?

Shady Alset Over a year ago

@Lanshore no it's just for testing functionality, but where do you want displaying result ?

Lanshore Over a year ago

Post this as answer, I cannot answer myself, I solved it by my own.

Lanshore Over a year ago

function getUrlVars() {                 var vars = {};                 var parts = window.location.href.replace(/[?&]+([^=&]+)=([^&]*)/gi, function (m, key, value) {                     vars[key] = value;                 });                 return vars;             }               var first = getUrlVars()["pid"];

Lanshore Over a year ago

This is a better way to get what I needed.

Collectives™ on Stack Overflow

Get URL Parameters Using Javascript

1 Answer 1

5 Comments

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

5 Comments

Linked

Related